Bug 283973 - devel/zycore-c: update to 1.5.1
Summary: devel/zycore-c: update to 1.5.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL: https://github.com/zyantific/zycore-c...
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-10 08:56 UTC by Martin Filla
Modified: 2025-01-15 19:14 UTC (History)
1 user (show)

See Also:


Attachments
0001-zycore-c-update-to-1.5.1.patch (1.57 KB, patch)
2025-01-10 08:56 UTC, Martin Filla
no flags Details | Diff
0001-zycore-c-update-to-1.5.1.patch (1.89 KB, patch)
2025-01-14 20:16 UTC, Martin Filla
freebsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Filla 2025-01-10 08:56:06 UTC
Created attachment 256595 [details]
0001-zycore-c-update-to-1.5.1.patch

Hi,
this is an update to 1.5.1. Poudriere is ok.
Comment 1 Zsolt Udvari freebsd_committer freebsd_triage 2025-01-14 13:22:47 UTC
The 'make test' fails:
===>  Testing for zycore-c-1.5.1
CMake Deprecation Warning at CMakeLists.txt:5 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.


CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.


CMake Error at /usr/local/share/cmake/Modules/ExternalProject/shared_internal_commands.cmake:943 (message):
  error: could not find git for clone of googletest
Call Stack (most recent call first):
  /usr/local/share/cmake/Modules/ExternalProject.cmake:3041 (_ep_add_download_command)
  CMakeLists.txt:6 (ExternalProject_Add)


-- Configuring incomplete, errors occurred!
CMake Error at CMakeLists.txt:88 (message):
  CMake step for googletest failed: 1


-- Configuring incomplete, errors occurred!
*** Error code 1


Could you please check?
Comment 2 Martin Filla 2025-01-14 20:16:50 UTC
Created attachment 256697 [details]
0001-zycore-c-update-to-1.5.1.patch
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2025-01-15 19:14:49 UTC
Great, thank you! Committed!
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-01-15 19:14:49 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2488d26b1b82f69c6e5d19a646b1a7387586506c

commit 2488d26b1b82f69c6e5d19a646b1a7387586506c
Author:     Martin Filla <freebsd@sysctl.cz>
AuthorDate: 2025-01-15 19:13:26 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2025-01-15 19:14:23 +0000

    devel/zycore-c: Update to 1.5.1

    Add devel/googletest to TEST_DEPENDS.

    PR:             283973
    Approved by:    submitter is maintainer

 devel/zycore-c/Makefile  | 4 +++-
 devel/zycore-c/distinfo  | 6 +++---
 devel/zycore-c/pkg-plist | 2 +-
 3 files changed, 7 insertions(+), 5 deletions(-)