Bug 284585 - www/vimb: Switch webkit2-gtk from 40 to 41
Summary: www/vimb: Switch webkit2-gtk from 40 to 41
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-05 10:03 UTC by mew14930xvi
Modified: 2025-02-06 11:00 UTC (History)
1 user (show)

See Also:

Attachments
Switch webkit2-gtk from 40 to 41 (3.36 KB, patch)
2025-02-05 10:03 UTC, mew14930xvi 		mew14930xvi: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mew14930xvi 2025-02-05 10:03:46 UTC 
Created attachment 257253 [details]
Switch webkit2-gtk from 40 to 41
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2025-02-05 19:49:34 UTC 
Hello,

Can't understand what's wrong with change:

- MAKE_ARGS= version="${DISTVERSION}"

+ post-patch:
+ ${ECHO_CMD} "#define VERSION \"${DISTVERSION}\"" > ${WRKSRC}/version.h

Does it mean that MAKE_ARGS was not working?
Comment 2 mew14930xvi 2025-02-06 02:00:52 UTC 
(In reply to Nuno Teixeira from comment #1)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283504
This is to prevent the build from failing.
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2025-02-06 09:35:40 UTC 
(In reply to mew14930xvi from comment #2)

Thanks, I understand now the change.
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-02-06 10:58:58 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dbb11cfc892db2046e29afebabbea9b5e799b6b1

commit dbb11cfc892db2046e29afebabbea9b5e799b6b1
Author:     mew14930xvi <mew14930xvi@inbox.lv>
AuthorDate: 2025-02-06 10:56:53 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2025-02-06 10:57:51 +0000

    www/vimb: Switch webkit2-gtk from 40 to 41

    PR:             284585

 www/vimb/Makefile                     | 12 +++++++-----
 www/vimb/files/patch-Makefile         | 11 +++++------
 www/vimb/files/patch-config.mk (gone) | 23 -----------------------
 3 files changed, 12 insertions(+), 34 deletions(-)
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2025-02-06 11:00:48 UTC 
Committed, thanks!