the pkg-install file references 5.6.0 instead of 5.6.1. Also, wouldn't it be better if the PERL_VER value was set before PORTVERSION uses it? Fix: patch:
On Wed, Jun 27, 2001 at 03:37:03PM -0400, khera@kciLink.com wrote: > >Synopsis: pkg-install script for perl5.6.1 references 5.6.0 directory > the pkg-install file references 5.6.0 instead of 5.6.1. Makes sense, thanks! > Also, wouldn't it be better if the PERL_VER value was set before > PORTVERSION uses it? Umm, no, it's not like make(1) works. The real problem is the fact that bsd.port.mk sets PERL_VER unconditionally. I would say that it does the right thing - it is not unreasonable to expect that the person who will dare to override the forbidden port will modify the bsd.port.mk accordingly. > >Fix: > > patch: > > --- #pkg-install~ Wed Jun 27 15:22:38 2001 > +++ pkg-install Wed Jun 27 15:22:38 2001 > @@ -6,7 +6,7 @@ > > INCLUDEDIR=/usr/include > > -install -d ${PREFIX}/lib/perl5/site_perl/5.6.0/arch > +install -d ${PREFIX}/lib/perl5/site_perl/5.6.1/arch > cd ${INCLUDEDIR} && ${PREFIX}/bin/h2ph *.h machine/*.h sys/*.h Cheers, +Anton. -- May the tuna salad be with you.
Responsible Changed From-To: freebsd-ports->tobez tobez is the maintainer of this port.
On Wed, Jun 27, 2001 at 03:00:19PM -0700, Anton Berezin wrote: > > Also, wouldn't it be better if the PERL_VER value was set before > > PORTVERSION uses it? > > Umm, no, it's not like make(1) works. The real problem is the fact > that bsd.port.mk sets PERL_VER unconditionally. I would say that it > does the right thing - it is not unreasonable to expect that the > person who will dare to override the forbidden port will modify the > bsd.port.mk accordingly. Following up to my own post... Argh. The port Makefile even has a comment to this effect: # This will need to be "fixed" in ../../Mk/bsd.port.mk as well. \Anton. -- May the tuna salad be with you.
State Changed From-To: open->closed Fix committed, thanks!