Bug 284701 - net/py-impacket: RUN_DEPENDS should include net/py-pcapy
Summary: net/py-impacket: RUN_DEPENDS should include net/py-pcapy
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jose Alonso Cardenas Marquez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-10 04:16 UTC by John Hein
Modified: 2025-04-15 04:53 UTC (History)
3 users (show)

See Also:
jcfyecrayz: maintainer-feedback? (acm)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2025-02-10 04:16:20 UTC 
bin/sniff.py and bin/split.py import pcapy (from net/py-pcapy).

Other python flavors than the default (currently py311) can be installed as well, so adding USES+=concurrent is useful.

Patch included inline...

--- a/net/py-impacket/Makefile
+++ b/net/py-impacket/Makefile
@@ -17,13 +17,14 @@ RUN_DEPENDS=        ${PYTHON_PKGNAMEPREFIX}pyasn1>=0:devel/py-pyasn1@${PY_FLAVOR} \
                ${PYTHON_PKGNAMEPREFIX}openssl>0:security/py-openssl@${PY_FLAVOR} \
                ${PYTHON_PKGNAMEPREFIX}six>0:devel/py-six@${PY_FLAVOR} \
                ${PYTHON_PKGNAMEPREFIX}ldap3>0:net/py-ldap3@${PY_FLAVOR} \
+               ${PYTHON_PKGNAMEPREFIX}pcapy>0:net/py-pcapy@${PY_FLAVOR} \
                ${PYTHON_PKGNAMEPREFIX}flask>0:www/py-flask@${PY_FLAVOR} \
                ${PYTHON_PKGNAMEPREFIX}future>0:devel/py-future@${PY_FLAVOR} \
                ${PYTHON_PKGNAMEPREFIX}charset-normalizer>0:textproc/py-charset-normalizer@${PY_FLAVOR} \
                ${PYTHON_PKGNAMEPREFIX}ldapdomaindump>0:net/py-ldapdomaindump@${PY_FLAVOR}

 USES=          dos2unix python
-USE_PYTHON=    autoplist distutils
+USE_PYTHON=    autoplist concurrent distutils
 NO_ARCH=       yes

 PORTDOCS=      *
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2025-02-13 12:01:50 UTC 
^Triage: Assign to maintainer.
Comment 2 commit-hook freebsd_committer freebsd_triage 2025-04-15 04:52:54 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2ecad6e4a51a5a40a1e145a80f183537f3f1d037

commit 2ecad6e4a51a5a40a1e145a80f183537f3f1d037
Author:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
AuthorDate: 2025-04-15 04:50:43 +0000
Commit:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
CommitDate: 2025-04-15 04:50:43 +0000

    net/py-impacket: Add missing dependency

    - Add concurrent to USES
    - Bump PORTREVISION
    PR:             284701
    Reported by:    John Hein <jcfyecrayz __at__ liamekaens.com>

 net/py-impacket/Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Comment 3 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2025-04-15 04:53:14 UTC 
Committed thanks!