Created attachment 257613 [details] update to 3.2.0 Update WWW. Add SVG and WEBP OPTION.
(In reply to mew14930xvi from comment #0) Why are SVG and WEBP default options? Please explain. Why is this one commit?
> Why are SVG and WEBP default options? Please explain. Because enable=yes is set in configure.ac. > Why is this one commit? It seems like a lot of committers don't mind consolidating things.
> Why is this one commit? Is it wrong to combine the things introduced in 3.2.0 into one? Or am I misunderstanding the question and asking something different?
(In reply to mew14930xvi from comment #2) >> Why are SVG and WEBP default options? Please explain. > Because enable=yes is set in configure.ac. Explaining this to me isn't good enough. This needs to be put in the commit log. You must word such a way that you are following the upstream defaults. In this case it might be acceptable it be one commit but it must be documented as such, including why, in the commit log >> Why is this one commit? >It seems like a lot of committers don't mind consolidating things. It's best practice. When I got my src commit bit I was taught to break commits into their functional parts. When ports replaced SVN with GIT we adopted the same policy. It makes dissecting commits easier when trying to find and fix bugs. These are good practices. And with the options the question why also needs to be answered. You haven't answered this question in the commit. This also makes it possible to figure out what is going on simply by reading the commit logs. You need to upload a new format-patch before I will consider it. Maintainer feedback is "-". The patch is denied until these points are fixed. In the mean time I will look at the existing ports to see if it enables SVG and WEBP by default.
(In reply to mew14930xvi from comment #3) If they are introduced, no, it is not wrong. But it must be clearly documented in the commit log. The question why is more important than what. See https://docs.freebsd.org/en/articles/committers-guide/#commit-log-message.
I'm closing this because learning English takes time.
(In reply to mew14930xvi from comment #6) I can help you with that. If you prefer, just email me directly. My first language was German. I now can barely speak the language as I haven't spoken it in decades. And my mom speaks a hybrid German-English now. I totally get that. I've updated the port to add GIF and make DOCS default (because that's the FreeBSD ports standard now). The last commit will be yours. Email me and we can talk.
Created attachment 257621 [details] Three commits to dillo2 Here are my proposed patches: 1. The first patch adds a GIF option, already supported by dillo2 3.1.1. 2. The second patch makes DOCS default. This is a FreeBSD standard. 3. The third patch updates dillo2 to 3.2.0. Like your patch it adds the SVG and WEBP options, making them default because the upstream ./configure defaults them. The commit log for each explains the rationale
Yes. I understand. Thank you.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=72abb4d199a9662e24fb1ce5da182ba17a05c434 commit 72abb4d199a9662e24fb1ce5da182ba17a05c434 Author: Cy Schubert <cy@FreeBSD.org> AuthorDate: 2025-02-18 16:38:27 +0000 Commit: Cy Schubert <cy@FreeBSD.org> CommitDate: 2025-02-18 18:31:17 +0000 www/dillo2: Update to 3.2.0 Update dillo2 to 3.2.0. 3.2.0 adds support for SVG and WEBP image formats. These are enabled by default by ./configure. Thus we add knobs for SVG and WEB, enabling them by default as upstream has in ./configure. PR: 284873 www/dillo2/Makefile | 12 ++++++++---- www/dillo2/distinfo | 6 +++--- 2 files changed, 11 insertions(+), 7 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=02d6332326414495cc0c1c7144f6c091ccfa9049 commit 02d6332326414495cc0c1c7144f6c091ccfa9049 Author: Cy Schubert <cy@FreeBSD.org> AuthorDate: 2025-02-18 15:22:15 +0000 Commit: Cy Schubert <cy@FreeBSD.org> CommitDate: 2025-02-18 18:31:13 +0000 www/dillo2: Make DOCS default In keeping with current ports standards, enable DOCS by default. PR: 284873 www/dillo2/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9c1d7dcbc16262b2c2f10cb92be102de6a97638d commit 9c1d7dcbc16262b2c2f10cb92be102de6a97638d Author: Cy Schubert <cy@FreeBSD.org> AuthorDate: 2025-02-18 15:17:56 +0000 Commit: Cy Schubert <cy@FreeBSD.org> CommitDate: 2025-02-18 18:31:05 +0000 www/dillo2: Add GIF option This option was enabled by default by the dillo2 ./configurure. Add a knob to control this option. PR: 284873 www/dillo2/Makefile | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)