Will start working on this ASAP. Changelog: https://github.com/netdata/netdata/releases/tag/v2.3.0
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285548 is a duplicate of this one.
(In reply to Trond Endrestøl from comment #1) Which to be closed?
(In reply to Jordan Ostreff from comment #3) I should like to close this one, 285530, as the other one is more actionable.
I'm working on the update and thanks to Trond for providing a patch for the ipfw plugin. Will try to get the update ready in the next few days. Either bug can be closed, but this one was submitted earlier I think. I'll import the ipfw patch in my update to v2.3 anyways.
(In reply to Namkhai B. from comment #5) Actually https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285548 was reported: 2025-03-20 13:26 UTC. But really for me this is not criteria. If port maintainer prefer i'm ok with every decision.
(In reply to Namkhai B. from comment #5) I just want to point out that my patch needs more attention. It may contain logical flaws as I only have a rudimentary understanding of the internals of ipfw. And as stated in the other PR, ipfw isn't displayed in the netdata UI at all for src/main. src/stable/{13,14} and releng/{13.5,14.2} are all okay. I'm able to test the new netdata on the branches I have mentioned.
*** Bug 285548 has been marked as a duplicate of this bug. ***
anything as working patch ?
(In reply to Jordan Ostreff from comment #9) I have something close but I'm traveling until April 7th and away from my workstation.
2.3.1 is published already https://github.com/netdata/netdata/releases/tag/v2.3.1
https://github.com/netdata/netdata/releases/tag/v2.3.2 new version published.
2.4.0 released https://github.com/netdata/netdata/tree/v2.4.0 any plans when new patches will be provided for testing?
Is anybody working on this changes?
I have some time now, will work on new patches this afternoon.
Created attachment 259627 [details] incomplete patch Here's a patch that solves some issues. It doesn't work when ML is on and even then it doesn't stage. (I forgot to check for an existing PR before I took a look at this for a friend who needs 2.4.0.
Created attachment 259656 [details] net-mgmt/netdata: Update to v2.4.0 Initial v2.4.0 patch. Dropped legacy dashboard as it was removed by netdata. Lightly tested on 14.2-RELEASE-p1
(In reply to Namkhai B. from comment #17) Your patch doesn't apply for me; I think your diff is against an older version of the port Makefile. -------------------------- Patching file net-mgmt/netdata/Makefile using Plan A... Hunk #1 failed at 1. Hunk #2 succeeded at 75 (offset 1 line). Hunk #3 succeeded at 156 (offset 1 line). 1 out of 3 hunks failed--saving rejects to net-mgmt/netdata/Makefile.rej Hmm... The next patch looks like a unified diff to me... The text leading up to this was: -------------------------- If I manually make failed change it fails to stage. I'm building with the default options. =======================<phase: package >============================ ===== env: 'PKG_NOTES=build_timestamp ports_top_git_hash ports_top_checkout_unclean port_git_hash port_checkout_unclean built_by' 'PKG_NOTE_build_timestamp=2025-04-18T19:42:06+0000' 'PKG_NOTE_ports_top_git_hash=14a57cfea9d' 'PKG_NOTE_ports_top_checkout_unclean=yes' 'PKG_NOTE_port_git_hash=186a8781b0d' 'PKG_NOTE_port_checkout_unclean=yes' 'PKG_NOTE_built_by=poudriere-git-3.4.2' NO_DEPENDS=yes USER=root UID=0 GID=0 ===> Building packages for netdata-2.4.0 ===> Building netdata-2.4.0 pkg-static: Unable to access file /wrkdirs/usr/ports/net-mgmt/netdata/work/stage/usr/local/libexec/netdata/plugins.d/ndsudo:No such file or directory *** Error code 1 Stop. make: stopped in /usr/ports/net-mgmt/netdata =>> Cleaning up wrkdir ===> Cleaning for netdata-2.4.0 build of net-mgmt/netdata | netdata-2.4.0 ended at Fri Apr 18 12:45:31 PDT 2025 build time: 00:03:25
Today they have bumped port revision, this is the only problem. You must manually edit Makefile, before apply proposed patch.
Created attachment 259684 [details] net-mgmt/netdata: Update to v2.4.0 Fixed stage with DASHBOARD=off. Rebased ports tree
(In reply to Namkhai B. from comment #20) It works perfectly for me, on bare metal 14.3-PRERELEASE stable/14-n271131-ee7a874557f4.
https://github.com/netdata/netdata/releases/tag/v2.5.1
(In reply to Namkhai B. from comment #20) v2.5.1 was published already.
Will work on this ASAP
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d52fa838d9cbd860339f6e1bc37837f05184a298 commit d52fa838d9cbd860339f6e1bc37837f05184a298 Author: Namkhai Bourquin <nk@nkeor.me> AuthorDate: 2025-05-21 19:46:04 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2025-05-21 21:04:30 +0000 net-mgmt/netdata: Update to 2.4.0 Changelog: https://github.com/netdata/netdata/releases/tag/v2.4.0 PR: 285530 net-mgmt/netdata/Makefile | 18 +- net-mgmt/netdata/distinfo | 14 +- net-mgmt/netdata/files/patch-CMakeLists.txt | 73 +- ...collectors_freebsd.plugin_freebsd__ipfw.c (new) | 14 + .../patch-src_ml_ml__calculated__number.h (gone) | 11 - .../files/patch-src_ml_ml__kmeans.cc (gone) | 11 - net-mgmt/netdata/pkg-plist | 1094 +++++++++++--------- 7 files changed, 655 insertions(+), 580 deletions(-)
Thanks! =)