Bug 285738 - devel/qt6-base: Drop xmlstarlet as a build dependency
Summary: devel/qt6-base: Drop xmlstarlet as a build dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks: 279705
  Show dependency tree / graph
 
Reported: 2025-03-29 09:00 UTC by Daniel Engberg
Modified: 2025-04-12 02:52 UTC (History)
1 user (show)

See Also:
jhale: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2025-03-29 09:00:29 UTC 
xmlstarlet is dead upstream and is troublesome with new versions of its dependencies and compilers, it's alkso only optional for building qt6.

Usage is only referenced in src/corelib/QtCompressMimeDatabase.cmake as far as I can tell and majority of distros have dropped this already.
Comment 1 Jason E. Hale freebsd_committer freebsd_triage 2025-03-29 15:54:50 UTC 
I'll look into it for Qt 6.9.0. Only fixing critical bugs for 6.8.3 at this time.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2025-04-05 14:04:16 UTC 
Blocks due to PR 279976
Comment 3 Jason E. Hale freebsd_committer freebsd_triage 2025-04-06 08:13:54 UTC 
(In reply to Daniel Engberg from comment #2)

I'm working on Qt 6.9.0 now and it is pretty much ready to go. I just need to tweak a few minor things and ask for an exp-run. It doesn't look like removing xmlstarlet will be an issue, since we are using zstd as the mime database compression type, so this shouldn't be a blocker for too much longer.
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2025-04-06 08:23:18 UTC 
Sounds great, thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2025-04-12 02:42:48 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7ac865e740c85737a68dbca87734efa4545d065b

commit 7ac865e740c85737a68dbca87734efa4545d065b
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2025-04-12 02:08:16 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2025-04-12 02:40:25 +0000

    devel/qt6-base: Drop unused textproc/xmlstarlet

    xmlstarlet is only used as a last resort attempt to reduce MIME database
    size if no actual file compression methods are found. Since we enable
    zstd support, this is the effective compression method used.

    PR:             285738
    Reported by:    diizzy
    MFH:            2025Q2

 devel/qt6-base/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2025-04-12 02:43:50 UTC 
A commit in branch 2025Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d952c466904ef8af222e00c7fd3150af6e7c3616

commit d952c466904ef8af222e00c7fd3150af6e7c3616
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2025-04-12 02:08:16 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2025-04-12 02:42:58 +0000

    devel/qt6-base: Drop unused textproc/xmlstarlet

    xmlstarlet is only used as a last resort attempt to reduce MIME database
    size if no actual file compression methods are found. Since we enable
    zstd support, this is the effective compression method used.

    PR:             285738
    Reported by:    diizzy
    MFH:            2025Q2

    (cherry picked from commit 7ac865e740c85737a68dbca87734efa4545d065b)

 devel/qt6-base/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 7 Jason E. Hale freebsd_committer freebsd_triage 2025-04-12 02:52:31 UTC 
(In reply to Daniel Engberg from comment #4)
There may be some delay importing Qt 6.9.x due to Webengine rendering issues that are not FreeBSD-related, so I've decided to just commit this separately. I didn't want this to be an indefinite blocker to your work.