Created attachment 260803 [details] sysutils/vtm.patch: update 2025.05.21 -> 2025.05.28 Poudriere testport do pass for both 142amd64 and 142i386. Port{clippy,fmt,lint} are OK. Also added a conditional to not run patch stage if it's not needed. Thanks in advance.
There's not much point in this: .if ${LUA_VER} != "5.4" But if you really want to, I can add it.
(In reply to Vladimir Druzenko from comment #2) > There's not much point in this: .if ${LUA_VER} != "5.4" > But if you really want to, I can add it. Hmm, actually I wrote the conditional because of the "reinplace_cmd ran but did not modify contents of ..." warning, so with this conditional, it won't run the patch if lua version didn't change and therefore no warning will be thrown i guess. Thanks for giving a look quickly!
(In reply to Yusuf Yaman from comment #3) I treat this warning as "are you absolutely sure that this is how it should be?" That is, it does not indicate an error, but suggests rechecking whether everything is correct. IMHO this code just complicates the port for no real reason.
BTW: "NOTE: This vtm release is not compatible with previous versions" Something needs to be done about this. Add record to pkg-message or/and to UPDATING.
(In reply to Vladimir Druzenko from comment #4) > I treat this warning as "are you absolutely sure that this is how it should be?" > That is, it does not indicate an error, but suggests rechecking whether everything is correct. > IMHO this code just complicates the port for no real reason. Hmm, thanks for opinions. it's not a complicated conditional for me but anyways i will remove it back. (In reply to Vladimir Druzenko from comment #5) > BTW: "NOTE: This vtm release is not compatible with previous versions" > Something needs to be done about this. > Add record to pkg-message or/and to UPDATING. I will research pkg-message files on ports tree that records something like this as i do have no idea how i could do it in pkg-message. If i can't do it in pkg-message, i'll see if i can do it in UPDATING. Is there something wrong with Bugzilla? I don't get emails from bugzilla for replies and this causing me to reply a while late. Thanks.
Does it look good? I am not well informed about changes so i can't recommend something for users of previous versions, i just gave a link to changelog. # pkg upgrade Updating Poudriere repository catalogue... Poudriere repository is up to date. All repositories are up to date. Updating database digests format: 100% Checking for upgrades (3 candidates): 100% Processing candidates (3 candidates): 100% Checking integrity... done (0 conflicting) The following 1 package(s) will be affected (of 0 checked): Installed packages to be UPGRADED: vtm: 0.9.99.71 -> 2025.05.28 Number of packages to be upgraded: 1 Proceed with this action? [y/N]: y [1/1] Upgrading vtm from 0.9.99.71 to 2025.05.28... [1/1] Extracting vtm-2025.05.28: 100% ===== Message from vtm-2025.05.28: -- Upgrades to vtm 2025.05.28 ===================== vtm 2025.05.28 contains changes that are made to configuration settings which are backward-incompatible for previous versions of vtm. The configuration settings file has changed significantly due to the introduction of Pure XML with dynamic element referencing and templating. See also: https://github.com/directvt/vtm/releases/tag/v2025.05.27
Created attachment 260807 [details] sysutils/vtm.patch: update 2025.05.21 -> 2025.05.28
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=640e5969e0be2cf703b0b738ca84aeb160164b75 commit 640e5969e0be2cf703b0b738ca84aeb160164b75 Author: Yusuf Yaman <nxjoseph@protonmail.com> AuthorDate: 2025-05-30 16:38:07 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2025-05-30 16:51:29 +0000 sysutils/vtm: Update 2025.05.21 => 2025.05.28 Changelogs: https://github.com/directvt/vtm/releases/tag/v2025.05.27 https://github.com/directvt/vtm/releases/tag/v2025.05.28 Add record to pkg-message about incompatibility with previous versions. PR: 287159 sysutils/vtm/Makefile | 5 ++--- sysutils/vtm/distinfo | 6 +++--- sysutils/vtm/pkg-message (new) | 17 +++++++++++++++++ 3 files changed, 22 insertions(+), 6 deletions(-)
Thanks.
(In reply to Vladimir Druzenko from comment #10) Thanks to you, i learn new things in general. Have a good one.