Bug 2936 - The teTeX port runs strup on /usr/local/bin
Summary: The teTeX port runs strup on /usr/local/bin
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Thomas Gellekum
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 1997-03-11 03:10 UTC by eivind
Modified: 1997-08-05 07:57 UTC (History)
0 users

See Also:


Attachments
file.diff (1.99 KB, patch)
1997-03-11 03:10 UTC, eivind
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description eivind freebsd_committer freebsd_triage 1997-03-11 03:10:02 UTC
teTeX run strip on /usr/local/bin/* instead of using install -s.
This do (among other things) give anybody that have non-stripped suid
binaries in /usr/local/bin a very good scare.

Fix: Apply this patch to ports/print/patches/patch-aa  (This is NOT a
replacement patch - it is a patch to the patch.)
How-To-Repeat: Install teTeX with non-stripped binaries in /usr/local/bin
Comment 1 Satoshi Asami freebsd_committer freebsd_triage 1997-03-11 10:46:44 UTC
State Changed
From-To: open->closed

Thanks, committed.  By the way, two things: your patch was mangled 
(why is it a patch from "patch-aa" to "/tmp/mkdiff"?) and the last 
hunk didn't apply, and I had to recreate it by myself.  Also, 
please don't do cut & paste from an unintelligent terminal 
emulator (like xterm), it causes patches to fail rather miserably. 

By the way, I ignored the first hunk; it was only changing the 
Comment 2 Satoshi Asami freebsd_committer freebsd_triage 1997-03-11 11:12:50 UTC
State Changed
From-To: closed->open

D'oh!  This is what I get for committing a change without 
testing the patch. :( 

This patch completely breaks the installation.  Please fix and 
re-submit.  Don't be fooled by "make install" making it to the end, 
there are errors in the middle that will kill "make package".  (Actually 
that's another bug in teTeX, that an error in the middle doesn't kill 
the make process.) 

Comment 3 eivind 1997-03-11 13:13:23 UTC
At 03:15 AM 3/11/97 -0800, Satoshi Asami wrote:
>Synopsis: The teTeX port runs strup on /usr/local/bin
>
>State-Changed-From-To: closed->open
>State-Changed-By: asami
>State-Changed-When: Tue Mar 11 03:12:50 PST 1997
>State-Changed-Why: 
>D'oh!  This is what I get for committing a change without
>testing the patch. :(
>
>This patch completely breaks the installation.  Please fix and
>re-submit.  Don't be fooled by "make install" making it to the end,
>there are errors in the middle that will kill "make package".  (Actually
>that's another bug in teTeX, that an error in the middle doesn't kill
>the make process.)

At least on my machine, the same problems were present prior and after
applying my patch.
I just re-tested it - using the original port, and

% make
% su
# make install
# exit
% make package

I get errors for missing inimf, virmf, install-info, xdvi.bin, texinfo-12,
web2c/mf.log, and web2c/mf.base.

Replacing the old patch-aa with my new version (the one in /tmp/mktemp :)
and doing
% su
# pkg_delete teTeX-0.4
# make clean
# exit
% make
% su
# make install
# exit
% make package

give me errors in the exact same files.

Most of this seems due to -lXt missing during compile, which I assumed was
a -stable problem. For some reason, this port does not accept
LD_LIBRARY_PATH - but I assumed it worked under -current.

All files but the ones listed above seems to be installed fine, with or
without the patch.

Did it package OK when you reverted?
If it did, I have no clue what can be wrong - and there is no way for me to
test it until I get my -current box up.


Eivind Eklund perhaps@yes.no http://maybe.yes.no/perhaps/ eivind@freebsd.org
Comment 4 asami 1997-03-11 23:30:09 UTC
 * I get errors for missing inimf, virmf, install-info, xdvi.bin, texinfo-12,
 * web2c/mf.log, and web2c/mf.base.

 * Did it package OK when you reverted?

You are right -- I reverted the patch but I still can't build it.  I
have the same problem with or without your patch.  However, the list
of errors is different, I have a bunch of bin/* files missing.

-------
===>  Building package for teTeX-0.4
tar: can't add file bin/gftodvi : No such file or directory
tar: can't add file bin/gftopk : No such file or directory
tar: can't add file bin/mft : No such file or directory
tar: can't add file bin/pktogf : No such file or directory
tar: can't add file bin/pktype : No such file or directory
tar: can't add file bin/vftovp : No such file or directory
tar: can't add file bin/vptovf : No such file or directory
tar: can't add file bin/gftype : No such file or directory
tar: can't add file bin/pltotf : No such file or directory
tar: can't add file bin/tftopl : No such file or directory
tar command failed with code 256
-------

I put the log in

ftp://han.cs.berkeley.edu/pub/tetex.log.gz

If you can take a look, it will be appreciated.  My system is
RELENG_2_2 (naturally, it's the packages-2.2 building machine).

Satoshi
Comment 5 eivind 1997-03-12 22:48:11 UTC
At 03:30 PM 3/11/97 -0800, Satoshi Asami wrote:
> * I get errors for missing inimf, virmf, install-info, xdvi.bin, texinfo-12,
> * web2c/mf.log, and web2c/mf.base.
>
> * Did it package OK when you reverted?
>
>You are right -- I reverted the patch but I still can't build it.  I
>have the same problem with or without your patch.  However, the list
>of errors is different, I have a bunch of bin/* files missing.
>
>-------
>===>  Building package for teTeX-0.4
>tar: can't add file bin/gftodvi : No such file or directory
>tar: can't add file bin/gftopk : No such file or directory
>tar: can't add file bin/mft : No such file or directory
>tar: can't add file bin/pktogf : No such file or directory
>tar: can't add file bin/pktype : No such file or directory
>tar: can't add file bin/vftovp : No such file or directory
>tar: can't add file bin/vptovf : No such file or directory
>tar: can't add file bin/gftype : No such file or directory
>tar: can't add file bin/pltotf : No such file or directory
>tar: can't add file bin/tftopl : No such file or directory
>tar command failed with code 256
>-------
>
>I put the log in
>
>ftp://han.cs.berkeley.edu/pub/tetex.log.gz
>
>If you can take a look, it will be appreciated.  My system is
>RELENG_2_2 (naturally, it's the packages-2.2 building machine).

Compiler dying with signal 6.  There is something DEFINEATLY weird about
this port; everything looks OK, it compiles on some machine but not others,
and the EXACT SAME COMMANDS written in a shell will compile the things that
fail consistently under gmake (at least on my box).  Can you try that for
your errors?



Eivind Eklund perhaps@yes.no http://maybe.yes.no/perhaps/ eivind@freebsd.org
Comment 6 Thomas Gellekum freebsd_committer freebsd_triage 1997-06-17 07:38:42 UTC
Responsible Changed
From-To: freebsd-ports->tg

I have all the other teTeX related PRs. 
Comment 7 Thomas Gellekum freebsd_committer freebsd_triage 1997-08-05 07:57:18 UTC
State Changed
From-To: open->closed


Fixed in latest port update.