benchmarks/iozone/Makefile redefines FETCH_CMD to add a variable to fetch's environment. However, in order to make sure that fetch knows how to get through my firewall, I already set FETCH_CMD in /etc/make.conf. This means that iozone doesn't work for me. I suspect that a good solution may be to define FETCH_ENV and add it to the beginning of ${FETCH_CMD} when running fetch so that I can have "FETCH_ENV=HTTP_PROXY=wwwproxy:8000" and iozone can have "FETCH_ENV+=FTP_PASSWORD=president@whitehouse.gov". Fix: Of course, this doesn't help all the ports who use ${FETCH_CMD} to fetch a file directly. I don't know if that means that this idea is broken or using ${FETCH_CMD} directly is broken. How-To-Repeat: "make fetch" in iozone when you have FETCH_CMD redefinied in /etc/make.conf and see your definition get overridden.
Responsible Changed From-To: freebsd-ports->asami
Hi Bill, Couldn't the we do something like make.conf: FETCH_ENV="HTTP_PROXY=perhaps.yet.no:8080" bsd.port.mk FETCH_CMD?= env ${FETCH_ENV} /usr/bin/fetch I know this has been discussed to death quite recently on CURRENT, but I don't remember anyone else suggesting this, and it seems sound to me. Ciao, Sheldon.
I like the solution in the PR better; what if you redefine FETCH_CMD to something that still knows what ${HTTP_PROXY} or ${FTP_USERNAME} means? Bill
* I like the solution in the PR better; what if you redefine FETCH_CMD * to something that still knows what ${HTTP_PROXY} or ${FTP_USERNAME} * means? I agree with you. It is also more consistent with the way the other *_ENV variables are used. I've put it in my copy of bsd.port.mk, it will be committed with the next batch of changes. Satoshi
State Changed From-To: open->closed Thanks, committed!