Bug 30033 - [Patch] maintainer update of port audio/ecasound
Summary: [Patch] maintainer update of port audio/ecasound
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-08-24 17:30 UTC by AnarCat
Modified: 2001-08-24 18:06 UTC (History)
0 users

See Also:


Attachments
file.diff (2.15 KB, patch)
2001-08-24 17:30 UTC, AnarCat
no flags Details | Diff
file.diff (1.52 KB, patch)
2001-08-24 17:30 UTC, AnarCat
no flags Details | Diff
file.diff (231 bytes, patch)
2001-08-24 17:30 UTC, AnarCat
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description AnarCat 2001-08-24 17:30:00 UTC
Update of the ecasound port. Now at version 2.0.2. The port seems to be a
bit nicer and cleaner now. Still compiles cleanly out of the box (eg no
patches necessary). A new port (ecawave) should logically follow shortly.

I had problems figuring out the python dependencies and pkg-plist
hacking, so I simply disabled python support for now. If someone could
give me a hand here, I just need to understand how to put "conditional"
lines in pkg-plist.

Fix: First, makefile. I changed my email in there and I disabled python
supoprt. I also made a post-install target to install some html doc in
there.

Oh, and the master_site_subdir was ridiculously wrong here. :)

Second, pkg-plist. I sorted the plist so there are a few "false
positives" in there. Also note that this will croak under make package
NOPORTDOCS=yes.

Then, last but not least, distinfo:
How-To-Repeat: 
N/A.
Comment 1 Peter Pentchev 2001-08-24 17:35:20 UTC
On Fri, Aug 24, 2001 at 12:25:45PM -0400, The Anarcat wrote:
> 
> >Number:         30033
> >Category:       ports
> >Synopsis:       [Patch] maintainer update of port audio/ecasound
> >Originator:     The Anarcat
> >Release:        FreeBSD 4.4-RC i386
> >Organization:
> Nada, Inc
> >Environment:
> System: FreeBSD shall.anarcat.dyndns.org 4.4-RC FreeBSD 4.4-RC #4: Wed Aug 22 12:21:57 EDT 2001 anarcat@shall.anarcat.dyndns.org:/usr/obj/usr/src/sys/SHALL i386
> 
> >Description:
> 
> Update of the ecasound port. Now at version 2.0.2. The port seems to be a
> bit nicer and cleaner now. Still compiles cleanly out of the box (eg no
> patches necessary). A new port (ecawave) should logically follow shortly.
> 
> I had problems figuring out the python dependencies and pkg-plist
> hacking, so I simply disabled python support for now. If someone could
> give me a hand here, I just need to understand how to put "conditional"
> lines in pkg-plist.
> 
> >Fix:
[snip]
> 
> 
> Second, pkg-plist. I sorted the plist so there are a few "false
> positives" in there. Also note that this will croak under make package
> NOPORTDOCS=yes.
> 
> --- pkg-plist.orig      Thu Aug 23 19:03:11 2001
> +++ pkg-plist.sort      Fri Aug 24 12:16:14 2001
[snip]
>  lib/libkvutils.so
>  lib/libkvutils.so.2
> +share/doc/ecasound/ecasound-iam_manpage.html

As mentioned in my other mail, make this
%%PORTDOCS%%share/doc/ecasound/ecasound-iam_manpage.html

After that, wait for a sound- and/or Python-aware committer to review
and commit this update :)  It looks good to me, but I cannot really
test it here..

G'luck,
Peter

-- 
This sentence no verb.
Comment 2 AnarCat 2001-08-24 17:48:42 UTC
> As mentioned in my other mail, make this
> %%PORTDOCS%%share/doc/ecasound/ecasound-iam_manpage.html

Ok. Here is the new patch, replacing the original pr one:

--- pkg-plist.orig      Thu Aug 23 19:03:11 2001
+++ pkg-plist   Fri Aug 24 12:44:44 2001
@@ -79,8 +79,8 @@
 include/ecasound/file-preset.h
 include/ecasound/finite-envelope.h
 include/ecasound/generic-controller.h
+include/ecasound/generic-linear-envelope.h
 include/ecasound/global-preset.h
-include/ecasound/ladspa.h
 include/ecasound/layer.h
 include/ecasound/linear-envelope.h
 include/ecasound/midi-cc.h
@@ -126,15 +126,27 @@
 lib/libecasound.so.7
 lib/libecasoundc.a
 lib/libecasoundc.so
-lib/libecasoundc.so.0
+lib/libecasoundc.so.1
 lib/libkvutils.a
 lib/libkvutils.so
 lib/libkvutils.so.2
 share/ecasound/effect_presets
 share/ecasound/generic_oscillators
-%%WITH_PYECASOUND%%lib/%%PYTHON_VERSION%%/site-packages/libpyecasound.so
-%%WITH_PYECASOUND%%lib/%%PYTHON_VERSION%%/site-packages/pyeca.py
-@dirrm share/ecasound
-@dirrm lib/ecasound-plugins
+%%PORTDOCS%%share/doc/ecasound/ecasound-iam_manpage.html
+%%PORTDOCS%%share/doc/ecasound/ecasound_faq.html
+%%PORTDOCS%%share/doc/ecasound/ecasound_faq.txt
+%%PORTDOCS%%share/doc/ecasound/ecasound_manpage.html
+%%PORTDOCS%%share/doc/ecasound/ecasoundrc_manpage.html
+%%PORTDOCS%%share/doc/ecasound/ecatools_manpage.html
+%%PORTDOCS%%share/doc/ecasound/examples.html
+%%PORTDOCS%%share/doc/ecasound/index.html
+%%PORTDOCS%%share/doc/ecasound/programmers_guide/eci_doc.html
+%%PORTDOCS%%share/doc/ecasound/programmers_guide/programmers_guide.html
+%%PORTDOCS%%share/doc/ecasound/users_guide/users_guide.html
+%%PORTDOCS%%@dirrm share/doc/ecasound/
+%%PORTDOCS%%@dirrm share/doc/ecasound/programmers_guide
+%%PORTDOCS%%@dirrm share/doc/ecasound/users_guide
 @dirrm include/ecasound
 @dirrm include/kvutils
+@dirrm lib/ecasound-plugins
+@dirrm share/ecasound

> After that, wait for a sound- and/or Python-aware committer to review
> and commit this update :)  It looks good to me, but I cannot really
> test it here..

For the sound, this is ok. I am sound aware. ;) For python, it is simply
de-activated. I don't think it was very much used anyways. What is
important now is to have this port ready for the incoming ecawave, which
is the one that is really interesting. :)

The thing is that I'm pretty sure that uncommenting the python stuff in
the makefile and in the pkg-plist would *work*, but I had some problems
wrt that on bento, so I prefer to be on the safe side, even if that
means less functionality.

A.
Comment 3 Peter Pentchev freebsd_committer freebsd_triage 2001-08-24 18:04:31 UTC
State Changed
From-To: open->closed

Committed, thanks! 
BTW, your patch had some tabs converted to spaces, which leads to Bad Things 
in a Makefile :) 
Also, the pkg-plist listed a parent directory for removing before 
removal of the two child dirs; that would lead to a complaint and 
a leftover parent dir at pkg_deinstall time. 

Other than that, thanks for your work! 
ATS: Enter the reason for changing this PR's status here.