Bug 30349 - [PATCH] audio/grip port installs to /usr/local instead of /usr/X11
Summary: [PATCH] audio/grip port installs to /usr/local instead of /usr/X11
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-09-05 19:20 UTC by AnarCat
Modified: 2001-09-10 02:41 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description AnarCat 2001-09-05 19:20:00 UTC
For some reason, the grip port installs itself in a /usr/local PREFIX.

Now I'm no ports guru, but I think this should be /usr/X11R6

Fix: Workaround:



However, I think that the USE_GTK var should set this.

As bsd.gnome.mk puts it:

# Ports using GNOME should also have USE_X_PREFIX defined.
# (Perhaps we should add it??  XXX: aDe)

So I think either fixing bsd.gnome.mk or a sweep of the gnome/gtk should
be done.

I opt for fixing bsd.gnome.mk.--ihSKH9aSwuSDaqTGIzBKj0nsnJ0YkP3CJOSVQ0p7CFL4dijm
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile.orig	Wed Sep  5 14:10:30 2001
+++ Makefile	Wed Sep  5 14:10:39 2001
@@ -14,6 +14,7 @@
 MAINTAINER=	ports@FreeBSD.org
 
 USE_GMAKE=	yes
+USE_X_PREFIX=	yes
 USE_GTK=	yes
 ALL_TARGET=	gripnopar gcd
 MAN1=		grip.1
How-To-Repeat: 
pkg_add -r grip
Comment 1 Peter Pentchev 2001-09-06 12:39:59 UTC
On Wed, Sep 05, 2001 at 02:19:49PM -0400, The Anarcat wrote:
> 
> >Number:         30349
> >Category:       ports
> >Synopsis:       [PATCH] audio/grip port installs to /usr/local instead of /usr/X11
> >Originator:     The Anarcat

[snip]

>  USE_GMAKE=	yes
> +USE_X_PREFIX=	yes
>  USE_GTK=	yes
>  ALL_TARGET=	gripnopar gcd
>  MAN1=		grip.1
> 
> However, I think that the USE_GTK var should set this.
> 
> As bsd.gnome.mk puts it:
> 
> # Ports using GNOME should also have USE_X_PREFIX defined.
> # (Perhaps we should add it??  XXX: aDe)
> 
> So I think either fixing bsd.gnome.mk or a sweep of the gnome/gtk should
> be done.
> 
> I opt for fixing bsd.gnome.mk.

I'm not really sure if this would be correct.  There are several
utilities which are mainly console-based, but provide a GTK version
upon request.  Automatically adding USE_X_PREFIX would either move
them unconditionally to /usr/X11R6 even if they are compiled without
GTK support, or would place them in different locations in the two
cases - with or without GTK support.  I don't know if I would like it
if e.g. net/mtr were installed under /usr/X11R6..

G'luck,
Peter

-- 
This sentence is false.
Comment 2 AnarCat 2001-09-06 17:38:58 UTC
On Thu, 06 Sep 2001, Peter Pentchev wrote:

> On Wed, Sep 05, 2001 at 02:19:49PM -0400, The Anarcat wrote:
> > 
> > >Number:         30349
> > >Category:       ports
> > >Synopsis:       [PATCH] audio/grip port installs to /usr/local instead of /usr/X11
> > >Originator:     The Anarcat
> 
> [snip]
> 
> >  USE_GMAKE=	yes
> > +USE_X_PREFIX=	yes
> >  USE_GTK=	yes
> >  ALL_TARGET=	gripnopar gcd
> >  MAN1=		grip.1
> > 
> > I opt for fixing bsd.gnome.mk.
> 
> I'm not really sure if this would be correct.  There are several
> utilities which are mainly console-based, but provide a GTK version
> upon request.  Automatically adding USE_X_PREFIX would either move
> them unconditionally to /usr/X11R6 even if they are compiled without
> GTK support, or would place them in different locations in the two
> cases - with or without GTK support.  I don't know if I would like it
> if e.g. net/mtr were installed under /usr/X11R6..


Conceded. :) However, I don't think grip posseses any kind of console
counterpart, so it *should* be in X11R6, IMHO.

A.
Comment 3 dwcjr freebsd_committer freebsd_triage 2001-09-10 02:40:50 UTC
State Changed
From-To: open->closed

committed, thanks!