Comment 1 Peter Pentchev 2001-09-07 13:07:05 UTC

Responsible Changed
From-To: freebsd-ports->roam

I'll take a look at this one.

Hi,

What do you think about the following patch:
- move the PREFIX tweaking from do-configure to post-patch,
  as it is done in most ports in the tree;
- use ${PERL} instead of 'perl' and avoid an unnecessary cd;
- install the gpp.html file unless NOPORTDOCS is installed.

Apart from that, this port is commit-ready :)

G'luck,
Peter

-- 
.siht ekil ti gnidaer eb d'uoy ,werbeH ni erew ecnetnes siht fI

diff -urN gpp/Makefile gpp.roam/Makefile
--- gpp/Makefile	Sat Sep  8 19:09:48 2001
+++ gpp.roam/Makefile	Sat Sep  8 19:22:16 2001
@@ -17,7 +17,13 @@
 
 MAN1=		gpp.1
 
-do-configure:
-	cd ${WRKSRC} && perl -pi -e "s|/usr/local|${PREFIX}|g" Makefile
+post-patch:
+		${PERL} -pi -e "s|/usr/local|${PREFIX}|g" ${WRKSRC}/Makefile
+
+post-install:
+.if !defined(NOPORTDOCS)
+		${MKDIR} ${DOCSDIR}
+		${INSTALL_DATA} ${WRKSRC}/gpp.html ${DOCSDIR}
+.endif
 
 .include <bsd.port.mk>
diff -urN gpp/pkg-plist gpp.roam/pkg-plist
--- gpp/pkg-plist	Sat Sep  8 19:09:48 2001
+++ gpp.roam/pkg-plist	Sat Sep  8 19:22:32 2001
@@ -1 +1,3 @@
 bin/gpp
+%%PORTDOCS%%share/doc/gpp/gpp.html
+%%PORTDOCS%%@dirrm share/doc/gpp

Comment 3 Peter Pentchev 2001-09-12 14:41:13 UTC

State Changed
From-To: open->closed

Committed, thanks!