Bug 31060 - New port: textproc/docbook-to-man
Summary: New port: textproc/docbook-to-man
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-05 18:00 UTC by clefevre
Modified: 2001-10-07 17:33 UTC (History)
0 users

See Also:


Attachments
file.shar (6.52 KB, text/plain)
2001-10-05 18:00 UTC, clefevre
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description clefevre 2001-10-05 18:00:01 UTC
	this port is required to build the manual pages of the -devel GnuPG
	port I'm submitting.

How-To-Repeat: 	n/a
Comment 1 lioux 2001-10-05 18:33:25 UTC
Hi,

	I made the following changes to the port, what do you think?

	1) add missing trailing / in MASTER_SITES
	2) *_DEPENDS use {LOCAL,X11}BASE not PREFIX
	3) No need to conditionaly set PREFIX, it's in MAKE_ENV

	Regards,

diff -ruN docbook-to-man.orig/Makefile docbook-to-man/Makefile
--- docbook-to-man.orig/Makefile	Fri Oct  5 14:25:03 2001
+++ docbook-to-man/Makefile	Fri Oct  5 14:31:14 2001
@@ -8,7 +8,7 @@
 PORTNAME=	docbook-to-man
 PORTVERSION=	1.0
 CATEGORIES=	textproc
-MASTER_SITES=	http://www.oasis-open.org/docbook/tools/dtm
+MASTER_SITES=	http://www.oasis-open.org/docbook/tools/dtm/
 DISTNAME=	${PORTNAME}
 
 MAINTAINER=	clefevre@citeweb.net
@@ -33,7 +33,7 @@
 .else
 RUN_DEPENDS=	nsgmls:${PORTSDIR}/textproc/jade
 .endif
-RUN_DEPENDS+=	${PREFIX}/share/sgml/docbook:${PORTSDIR}/textproc/docbook
+RUN_DEPENDS+=	${LOCALBASE}/share/sgml/docbook:${PORTSDIR}/textproc/docbook
 
 USE_IMAKE=	yes
 USE_X_PREFIX=	no
diff -ruN docbook-to-man.orig/files/patch-Instant::Imakefile docbook-to-man/files/patch-Instant::Imakefile
--- docbook-to-man.orig/files/patch-Instant::Imakefile	Fri Oct  5 14:25:03 2001
+++ docbook-to-man/files/patch-Instant::Imakefile	Fri Oct  5 14:21:30 2001
@@ -1,6 +1,6 @@
---- Instant/Imakefile.orig	Mon Jun 17 05:50:29 1996
-+++ Instant/Imakefile	Fri Oct  5 18:18:22 2001
-@@ -1,14 +1,18 @@
+--- Instant/Imakefile.orig	Mon Jun 17 00:50:09 1996
++++ Instant/Imakefile	Fri Oct  5 14:20:29 2001
+@@ -1,14 +1,17 @@
  #define IHaveSubdirs
  #define PassCDebugFlags
 +#undef BuildInstallHtmlManPage
@@ -9,9 +9,8 @@
  SUBDIRS = tptregexp
  
 -ROOT		= /usr/local
-+PREFIX		?= /usr/local
 +ROOT		= ${PREFIX}
-+MANPATH		= ${ROOT}/man
++MANPATH		= $(ROOT)/man
  BINDIR		= $(ROOT)/bin
  
  INCLUDES	= -Itptregexp
@@ -21,7 +20,7 @@
  DEFINES		= -DDEF_TPT_LIB=\"$(TPTLIB)\"
  
  SRCS	= main.c util.c info.c translate.c traninit.c tranvar.c tables.c \
-@@ -19,4 +23,4 @@
+@@ -19,4 +22,4 @@
  MakeSubdirs($(SUBDIRS))
  DependSubdirs($(SUBDIRS))
  
diff -ruN docbook-to-man.orig/files/patch-Transpec::Imakefile docbook-to-man/files/patch-Transpec::Imakefile
--- docbook-to-man.orig/files/patch-Transpec::Imakefile	Fri Oct  5 14:25:03 2001
+++ docbook-to-man/files/patch-Transpec::Imakefile	Fri Oct  5 14:21:22 2001
@@ -1,9 +1,8 @@
---- Transpec/Imakefile.orig	Mon Jun 17 05:50:28 1996
-+++ Transpec/Imakefile	Fri Oct  5 18:20:17 2001
-@@ -1,5 +1,6 @@
+--- Transpec/Imakefile.orig	Mon Jun 17 00:50:08 1996
++++ Transpec/Imakefile	Fri Oct  5 14:20:04 2001
+@@ -1,5 +1,5 @@
 -ROOT =		/usr/local
 -TPTLIB =	$(ROOT)/lib/tpt
-+PREFIX ?=	/usr/local
 +ROOT =		${PREFIX}
 +TPTLIB =	$(ROOT)/share/sgml/otranspec
  
diff -ruN docbook-to-man.orig/files/patch-cmd::Imakefile docbook-to-man/files/patch-cmd::Imakefile
--- docbook-to-man.orig/files/patch-cmd::Imakefile	Fri Oct  5 14:25:03 2001
+++ docbook-to-man/files/patch-cmd::Imakefile	Fri Oct  5 14:21:44 2001
@@ -1,8 +1,7 @@
---- cmd/Imakefile.orig	Mon Jun 17 05:50:30 1996
-+++ cmd/Imakefile	Fri Oct  5 18:18:22 2001
-@@ -1,4 +1,5 @@
+--- cmd/Imakefile.orig	Mon Jun 17 00:50:10 1996
++++ cmd/Imakefile	Fri Oct  5 14:20:40 2001
+@@ -1,4 +1,4 @@
 -ROOT =	/usr/local
-+PREFIX ?=	/usr/local
 +ROOT =		${PREFIX}
  BINDIR =	$(ROOT)/bin

-- 
Mario S F Ferreira - UnB - Brazil - "I guess this is a signature."
lioux at ( freebsd dot org | linf dot unb dot br )
flames to beloved devnull@someotherworldbeloworabove.org
feature, n: a documented bug | bug, n: an undocumented feature
Comment 2 clefevre 2001-10-06 01:23:01 UTC
Mario Sergio Fujikawa Ferreira wrote:
> Hi,
> 
> 	I made the following changes to the port, what do you think?
> 
> 	1) add missing trailing / in MASTER_SITES
> 	2) *_DEPENDS use {LOCAL,X11}BASE not PREFIX

well, textproc/docbook and textproc/sgmlformat (and probably more)
are also wrong since I use them as a model.

> 	3) No need to conditionaly set PREFIX, it's in MAKE_ENV

I know that, but it may be needed if you build the port directly
in WRKSRC such as for testing purpose, etc. so, I prefer to keep
them.

how about the naming of instant -> oinstant and transpec -> otranspec ?

thanks for your review.

Cyrille.
-- 
Cyrille Lefevre                 mailto:clefevre@citeweb.net
Comment 3 Mario Sergio Fujikawa Ferreira freebsd_committer freebsd_triage 2001-10-07 17:33:30 UTC
State Changed
From-To: open->closed

Committed, thanks!