Bug 31508 - Coding error in py-4suite: Ft/Lib/Uuid.py throws away half of generated UUID
Summary: Coding error in py-4suite: Ft/Lib/Uuid.py throws away half of generated UUID
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Johann Visagie
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-26 15:40 UTC by Alan Eldridge
Modified: 2002-01-07 13:04 UTC (History)
0 users

See Also:


Attachments
file.diff (366 bytes, patch)
2001-10-26 15:40 UTC, Alan Eldridge
no flags Details | Diff
py-4suite-Uuid.patch (696 bytes, patch)
2002-01-06 08:16 UTC, Alan Eldridge
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Eldridge 2001-10-26 15:40:01 UTC
There's a typo (?) in Ft.Lib.Uuid.UuidAsString(uuid), where a loop to convert an integer to a string of bytes is only picking up the lower 4 bits of each byte.

This results in half of the bits of the UUID being thrown away in the conversion to string.

I have not yet checked, but this is probably fixed in the newest version of the the 4suite code.

Fix: Make this fix (changing 0xF to 0xFF).

[alane@wwweasel ~/sw/ftom/linkman]$ diff -u Uuid.py.or Uuid.py
How-To-Repeat: [alane@wwweasel ~/sw/ftom/linkman]$ python
Python 2.1.1 (#1, Sep 13 2001, 18:12:15)
[GCC 2.95.3 20010315 (release) [FreeBSD]] on freebsd4
Type "copyright", "credits" or "license" for more information.
Comment 1 Mario Sergio Fujikawa Ferreira freebsd_committer freebsd_triage 2001-12-20 18:26:21 UTC
Responsible Changed
From-To: freebsd-ports->wjv

Over to maintainer
Comment 2 Alan Eldridge 2001-12-20 18:46:44 UTC
Just checked and problem exists in current version in ports.
Comment 3 Alan Eldridge 2002-01-06 08:16:22 UTC
Submitted on Oct 26. Over to maintainer on Dec 20. No response.

Please commit this patch. Also, I will take maintainship if the current 
maintainer doesn't want it anymore.

-- 
Alan Eldridge
Pmmfmffmmfmp mmmpppppffmpmfpmpppff $PffMmmPppMpmPpfPpm mfpmmmmmfpmpmpppff.
Comment 4 johann 2002-01-07 08:58:19 UTC
Alan E on 2002-01-06 (Sun) at 03:16:22 -0500:
> 
> Submitted on Oct 26. Over to maintainer on Dec 20. No response.
> 
> Please commit this patch. Also, I will take maintainship if the current 
> maintainer doesn't want it anymore.

*ahem*  It's summer vacation here in the Southern Hemisphere, and (as
I've notified the other committers) I have been out of touch for a
while.  Back now;  I'll handle this PR soon.

BTW, I admit that I sometimes miss things in the noise on -ports.  Since
this isn't a perfect world, you may get a faster response if you Cc: the
maintainer on ports PRs.  :-)

-- V
Comment 5 Johann Visagie freebsd_committer freebsd_triage 2002-01-07 13:02:52 UTC
State Changed
From-To: open->closed

Committed, thanks for your patience! 

BTW, 0.11.1 is still the current version of 4Suite;  I therefore 
recmmend that you liaise with the 4Suite authors about including 
your fix in subsequent versions.