First off, this is my fault. I had an old muttprint installation in /opt, so this didn't get the right testing before commit. Oh hell let's be honest: it didn't get tested. Muttprint does a "use warnings;", which doesn't work on perl < 5.6. This patch also makes minor corrections to the pkg-comment and pkg-descr files for accuracy and English usage. :) To Oliver: please email dwcjr@freebsd.org and approve committing this patch. This supercedes the one you got a few minutes ago that didn't go anywhere else due to hub.freebsd.org problem. Thanks. To David: Please commit once you get maintainer's approval. Thanks. My sincere apologies to all for the mistake. Fix: ---8<-snip---8<-snip---8<-snip---8<-snip---8<-snip---8<-snip---8<--- How-To-Repeat: Run it.
in message <200202120742.g1C7gZf59864@wwweasel.geeksrus.net>, wrote Alan Eldridge thusly... > > > >Number: 34867 > >Category: ports > >Synopsis: muttprint port doesn't work with perl < 5.6 ... > Muttprint does a "use warnings;", which doesn't work on perl < 5.6. ... > Index: print/muttprint/files/patch-ab > =================================================================== > RCS file: /home/alane/cvsroot/ports/print/muttprint/files/patch-ab,v > retrieving revision 1.1 > diff -u -3 -r1.1 patch-ab > --- print/muttprint/files/patch-ab 12 Feb 2002 04:18:19 -0000 1.1 > +++ print/muttprint/files/patch-ab 12 Feb 2002 06:49:17 -0000 > @@ -1,5 +1,14 @@ > ---- muttprint.orig Fri Jan 4 15:04:45 2002 > -+++ muttprint Fri Jan 4 15:05:31 2002 > +--- muttprint.orig Sat Dec 15 08:49:39 2001 > ++++ muttprint Tue Feb 12 01:48:40 2002 > +@@ -34,7 +34,7 @@ > + # Deklaration erzwingen > + use strict; > + # for developing and testing only > +-use warnings; > ++#use warnings; > + # Deklaration nach Perl-5.005-Art > + use vars qw($VERSION %String $LPack $charset); > + use sigtrap qw(die INT QUIT); > @@ -158,8 +158,8 @@ if "use warnings;" can't be used, then how about just using the "-w" switch (on the shebang line: "#!/usr/bin/perl -w") ? as far as i know, perl 5.6 supports both the "warnings" pragma and the switch. - parv --
On Tue, Feb 12, 2002 at 04:51:42AM -0500, parv wrote: >in message <200202120742.g1C7gZf59864@wwweasel.geeksrus.net>, >wrote Alan Eldridge thusly... >> >> >> >Number: 34867 >> >Category: ports >> >Synopsis: muttprint port doesn't work with perl < 5.6 >... >> Muttprint does a "use warnings;", which doesn't work on perl < 5.6. > >if "use warnings;" can't be used, then how about just using the "-w" >switch (on the shebang line: "#!/usr/bin/perl -w") ? as far as i >know, perl 5.6 supports both the "warnings" pragma and the switch. Thanks. I'll put that in the next patch to this port. -- Alan Eldridge "Dave's not here, man."
State Changed From-To: open->closed Committed, thanks!