Bug 34909 - Porters Handbook or portlint problem
Summary: Porters Handbook or portlint problem
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Books & Articles (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-doc (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-02-13 16:30 UTC by Jeroen Ruigrok/Asmodai
Modified: 2002-04-05 23:28 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Ruigrok/Asmodai 2002-02-13 16:30:02 UTC
	The Porters Handbook, part 4.10 lists a dependency on ${PREFIX}, while
	a portlint check says people should use ${LOCALBASE} or ${X11BASE}
	instead.

Fix: 

Not sure.  Either the documenation is faulty, or portlint is outdated.
	Hence submitted to ports at first, but can/needs to be reassigned to
	docs if it is a documenation error.
How-To-Repeat: 	Have a port with a dependency which contains ${PREFIX} and unleash
	portlint -abcvtN on it.
Comment 1 Mario Sergio Fujikawa Ferreira freebsd_committer freebsd_triage 2002-02-13 19:38:59 UTC
Responsible Changed
From-To: freebsd-ports->freebsd-doc

portlint is accurate. This is a documentation issue
Comment 2 Mario Sergio Fujikawa Ferreira freebsd_committer freebsd_triage 2002-02-13 19:47:35 UTC
What about the following patch, for starters.

Also, perhaps we should add a line stating that unless a *_DEPENDS
target is a library or binary in the path, it should be prepended
with either LOCALBASE or X11BASE where appropriate; LOCALBASE if
the dependency port has a standard PREFIX; or X11BASE if USE_X_PREFIX.

--- book.sgml.orig	Wed Feb 13 17:41:08 2002
+++ book.sgml	Wed Feb 13 17:42:28 2002
@@ -1129,7 +1129,7 @@
 
           <para>For example,</para>
 
-            <programlisting>RUN_DEPENDS=   ${PREFIX}/etc/innd:${PORTSDIR}/news/inn \
+            <programlisting>RUN_DEPENDS=   ${LOCALBASE}/etc/innd:${PORTSDIR}/news/inn \
                wish8.0:${PORTSDIR}/x11-toolkits/tk80</programlisting>
 
           <para>will check if the file or directory

-- 
Mario S F Ferreira - DF - Brazil - "I guess this is a signature."
Computer Science Undergraduate | FreeBSD Committer | CS Developer
flames to beloved devnull@someotherworldbeloworabove.org
feature, n: a documented bug | bug, n: an undocumented feature
Comment 3 Jeroen Ruigrok/Asmodai 2002-02-13 20:00:02 UTC
-On [20020213 20:49], Mario Sergio Fujikawa Ferreira (lioux@FreeBSD.org) wrote:
>What about the following patch, for starters.

Looks fine to me.

>Also, perhaps we should add a line stating that unless a *_DEPENDS
>target is a library or binary in the path, it should be prepended
>with either LOCALBASE or X11BASE where appropriate; LOCALBASE if
>the dependency port has a standard PREFIX; or X11BASE if USE_X_PREFIX.

Yes, like portlint warns you about.

*nod*

-- 
Jeroen Ruigrok van der Werven / asmodai / Kita no Mono / xMach coreteam
asmodai@[wxs.nl|xmach.org], finger asmodai@ninth-circle.org
http://www.softweyr.com/asmodai/
The distance to here is infinite...
Comment 4 Jeroen Ruigrok van der Werven freebsd_committer freebsd_triage 2002-04-05 23:28:35 UTC
State Changed
From-To: open->closed

Committed.