KDEPIM port uses malloc.h for 'libical'. malloc.h is deprecated, and stdlib.h should be used instead. This problem breaks the build on 5.0-CURRENT, where use of malloc.h generates a #error not a #warning. A patch needs to be applied that removes use of malloc.h, and if necessary, adds a #include of stdlib.h How-To-Repeat: Attempt to build kdepim on 5.0: /bin/sh ../../libtool --mode=compile cc -DHAVE_CONFIG_H -I. -I. -I../.. -I../..-I../../src -I../../src -I. -I/usr/local/include -L/usr/local/lib -I/usr/include -D_GETOPT_H -D_PTH_H_ -D_PTH_PTHREAD_H_ -I/usr/local/include -I/usr/local/include -I/usr/X11R6/include/qt2 -DNDEBUG -O2 -O -pipe -g -c icallangbind.c cc -DHAVE_CONFIG_H -I. -I. -I../.. -I../.. -I../../src -I../../src -I. -I/usr/local/include -L/usr/local/lib -I/usr/include -D_GETOPT_H -D_PTH_H_ -D_PTH_PTHREAD_H_ -I/usr/local/include -I/usr/local/include -I/usr/X11R6/include/qt2 -DNDEBUG -O2 -O -pipe -g -Wp,-MD,.deps/icallangbind.pp -c icallangbind.c -fPIC -DPIC -o .libs/icallangbind.o In file included from icallangbind.c:25: /usr/include/malloc.h:3: #error "<malloc.h> has been replaced by <stdlib.h>" gmake[5]: *** [icallangbind.lo] Error 1 gmake[5]: Leaving directory `/usr/ports/deskutils/kdepim/work/kdepim-2.2.2/libical/src/libical' gmake[4]: *** [all-recursive] Error 1 gmake[4]: Leaving directory `/usr/ports/deskutils/kdepim/work/kdepim-2.2.2/libical/src' gmake[3]: *** [all-recursive] Error 1 gmake[3]: Leaving directory `/usr/ports/deskutils/kdepim/work/kdepim-2.2.2/libical' gmake[2]: *** [all-recursive-am] Error 2 gmake[2]: Leaving directory `/usr/ports/deskutils/kdepim/work/kdepim-2.2.2/libical' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/usr/ports/deskutils/kdepim/work/kdepim-2.2.2' gmake: *** [all-recursive-am] Error 2 *** Error code 2 Stop in /usr/ports/deskutils/kdepim. *** Error code 1 Stop in /usr/ports/deskutils/kdepim. *** Error code 1 Stop in /usr/ports/deskutils/kdepim.
On Sun, Mar 03, 2002 at 01:33:50PM -0500, Robert Watson wrote: > >>Number: 35519 >>Category: ports >>Synopsis: kdepim port doesn't know that malloc.h is now broken >>Confidential: no I prepared a set of patches for KDE that eliminated the malloc.h problem. I don't know if they were ever committed. Pete, do you remember? -- Alan Eldridge "Dave's not here, man."
++ 04/03/02 12:27 -0500 - Alan Eldridge: | On Sun, Mar 03, 2002 at 01:33:50PM -0500, Robert Watson wrote: | > | >>Number: 35519 | >>Category: ports | >>Synopsis: kdepim port doesn't know that malloc.h is now broken | >>Confidential: no | | I prepared a set of patches for KDE that eliminated the malloc.h problem. | I don't know if they were ever committed. Pete, do you remember? I've got something local in my tree, just forgot to commit it. I'll do that in a few. --pete -- Pete Fritchman [petef@(databits.net|freebsd.org|csh.rit.edu)] finger petef@databits.net for PGP key
State Changed From-To: open->closed Fixed, thanks for the report!
Great, thanks muchly. I'll try installing again later tonight. Someone needs to teach people to stop including malloc.h. Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services On Mon, 4 Mar 2002, Pete Fritchman wrote: > ++ 04/03/02 12:27 -0500 - Alan Eldridge: > | On Sun, Mar 03, 2002 at 01:33:50PM -0500, Robert Watson wrote: > | > > | >>Number: 35519 > | >>Category: ports > | >>Synopsis: kdepim port doesn't know that malloc.h is now broken > | >>Confidential: no > | > | I prepared a set of patches for KDE that eliminated the malloc.h problem. > | I don't know if they were ever committed. Pete, do you remember? > > I've got something local in my tree, just forgot to commit it. I'll do > that in a few. > > --pete > > -- > Pete Fritchman [petef@(databits.net|freebsd.org|csh.rit.edu)] > finger petef@databits.net for PGP key >