Bug 36566 - [smbfs] System reboot with dead smb mount and umount
Summary: [smbfs] System reboot with dead smb mount and umount
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 4.5-RELEASE
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-fs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-03-31 09:20 UTC by Johan Mulder
Modified: 2014-05-02 22:32 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Mulder 2002-03-31 09:20:01 UTC
When a windows box dies and a freebsd system has a windows share mounted,
the FreeBSD box will reboot upon the unmount of the mounted share (after the
mount has been dead a while).

Fix: 

Unknown.
How-To-Repeat: Mount a share, firewall the windows box, wait a while and try to umount -f.
Comment 1 goran 2005-06-23 11:42:17 UTC
I can confirm that this is still an issue on FreeBSD 5.4-RELEASE.

After doing this my system crashed:

bash-2.05b# umount -fv /mnt/backup

umount: /mnt/backup: statfs: RPC struct is bad

//BACKUP-USER@SERVER/SHARE: unmount from /mnt/backup

I had the same problem before on FreeBSD 4.9-RELEASE.

Still no fix for this?

Best Regards

Goran
Comment 2 joe 2008-02-16 23:16:29 UTC
Here's another datapoint...

I am running FreeBSD 7.0-RC1, and I just got a reboot on doing the mount
itself (i.e. "mount_smbfs ...").

I suspect this could be the same issue.  I had network connectivity at
the time, but the Windows box *had* been firewalled during serveral
previous attempts to mount (this is due to a recent upgrade from Windows
2000 to Windows XP Pro), resulting in timeouts.  Once unfirewalled, I
was then getting authentication errors because the drive on the Windows
box did not have sharing enabled (Windows XP must have disabled this
during upgrade).

Once I got this setting changed (and while the Windows box was busy for
a while setting permissions on files), I tried to mount the Windows
share, causing a reboot  When FreeBSD came back up, I could mount and
umount fine.
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2009-05-18 05:24:19 UTC
Responsible Changed
From-To: freebsd-bugs->freebsd-fs

Over to maintainer(s).
Comment 4 dfilter service freebsd_committer freebsd_triage 2014-04-17 13:22:11 UTC
Author: ae
Date: Thu Apr 17 12:22:08 2014
New Revision: 264600
URL: http://svnweb.freebsd.org/changeset/base/264600

Log:
  Remove redundant unlock.
  
  This code was removed from the opensolaris and darwin's
  netsmb implementations, in DfBSD it also has been disabled.
  
  PR:		36566, 87859, 139407, 161579, 175557, 178412, 186652
  MFC after:	2 weeks
  Sponsored by:	Yandex LLC

Modified:
  head/sys/netsmb/smb_iod.c

Modified: head/sys/netsmb/smb_iod.c
==============================================================================
--- head/sys/netsmb/smb_iod.c	Thu Apr 17 12:16:51 2014	(r264599)
+++ head/sys/netsmb/smb_iod.c	Thu Apr 17 12:22:08 2014	(r264600)
@@ -87,8 +87,6 @@ smb_iod_invrq(struct smbiod *iod)
 	 */
 	SMB_IOD_RQLOCK(iod);
 	TAILQ_FOREACH(rqp, &iod->iod_rqlist, sr_link) {
-		if (rqp->sr_flags & SMBR_INTERNAL)
-			SMBRQ_SUNLOCK(rqp);
 		rqp->sr_flags |= SMBR_RESTART;
 		smb_iod_rqprocessed(rqp, ENOTCONN);
 	}
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 5 Andrey V. Elsukov freebsd_committer freebsd_triage 2014-05-02 22:31:29 UTC
State Changed
From-To: open->closed