Bug 4164 - pcvt VT_WAITACTIVE ioctl busted
Summary: pcvt VT_WAITACTIVE ioctl busted
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 2.2.2-RELEASE
Hardware: Any Any
: Normal Affects Only Me
Assignee: Joerg Wunsch
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 1997-07-25 04:40 UTC by Joe Traister
Modified: 1997-09-14 20:03 UTC (History)
0 users

See Also:


Attachments
file.diff (618 bytes, patch)
1997-07-25 04:40 UTC, Joe Traister
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Traister 1997-07-25 04:40:01 UTC
	The pcvt VT_WAITACTIVE ioctl, when passed a 0 third argument,
	puts the calling process to sleep until the current vt is
	switched away from.  The syscons driver, when passed a 0 third
	argument, waits until the vt represented by the passed file
	descriptor is switched to.  Both claim to be USL-compatible.
	I wasn't sure which was correct, but the latter behavior seems
	more useful, since the former doesn't care whether the current
	vt is related to the calling process or not.  Also, a comment
	in the pcvt code makes it clear that the author was unsure of
	the correct behavior.

How-To-Repeat: 
	A code example would be rather involved, but can be provided.
	A comparison of the code in scioctl() in i386/isa/syscons.c and
	usl_vt_ioctl() in i386/isa/pcvt/pcvt_ext.c is straightforward.
Comment 1 Joerg Wunsch freebsd_committer freebsd_triage 1997-07-31 22:18:55 UTC
Responsible Changed
From-To: freebsd-bugs->joerg

I've been the last one mucking with kernel sppp, so i'll deal with 
this problem.  The submitted patch looks simple enough... 

Comment 2 Joerg Wunsch 1997-07-31 22:25:12 UTC
As Joerg Wunsch wrote:

> Synopsis: pcvt VT_WAITACTIVE ioctl busted
> 
> Responsible-Changed-From-To: freebsd-bugs->joerg
> Responsible-Changed-By: joerg
> Responsible-Changed-When: Thu Jul 31 23:18:55 MEST 1997
> Responsible-Changed-Why: 
> I've been the last one mucking with kernel sppp, so i'll deal with
> this problem.  The submitted patch looks simple enough...

Needless to say, i've totally confused this one.  :-<>  Anyway, still
my field, since i'm supposed to handle pcvt problems...
-- 
cheers, J"org

joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE
Never trust an operating system you don't have sources for. ;-)
Comment 3 Joerg Wunsch freebsd_committer freebsd_triage 1997-09-14 20:02:25 UTC
State Changed
From-To: open->closed


Suggested fix applied in rev 1.13 of pcvt_ext.c.  Thanks! 
(Well, i actually collapsed the code a little afterwards.)