Bug 43326 - [PATCH?] <nl_types.h> needs previous inclusion of <sys/_types.h>
Summary: [PATCH?] <nl_types.h> needs previous inclusion of <sys/_types.h>
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: standards (show other bugs)
Version: 5.0-CURRENT
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-standards (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-09-24 12:10 UTC by Stefan Farfeleder
Modified: 2002-09-24 18:30 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (272 bytes, patch)
2002-09-24 12:10 UTC, Stefan Farfeleder
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Farfeleder 2002-09-24 12:10:05 UTC
This commit:

mike        2002/09/17 22:51:23 PDT

  Modified files:
    include              nl_types.h
    sys/sys              _types.h
  Log:
  Move definition of nl_item type to <sys/_types.h>, so that it can be
  shared.
 
  Revision  Changes    Path
  1.9       +5 -1      src/include/nl_types.h
  1.8       +1 -0      src/sys/sys/_types.h

made it necessary to include sys/_types.h before including nl_types.h
since the new typedef of __nl_item was put into the former header.

Fix: If nl_types.h would include sys/_types.h itself instead of sys/cdefs.h,
the old behaviour would be restored. I don't know whether this would introduce
any namespace pollution.
How-To-Repeat: ports/x11-wm/blackbox doens't build anymore on -current because of this.
According to catopen(3), the following test program should compile:

#include <nl_types.h>

int
main(void)
{
        catopen("", 0);
        return 0;
}
Comment 1 Mike Barcroft freebsd_committer freebsd_triage 2002-09-24 18:29:51 UTC
State Changed
From-To: open->closed


Problem fixed.