Bug 44582 - usr.bin/bin/Makefile issues
Summary: usr.bin/bin/Makefile issues
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: Johan Karlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-10-29 00:50 UTC by Jon Disnard
Modified: 2003-02-02 10:05 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Disnard 2002-10-29 00:50:01 UTC
/usr/src/usr/bin/less/Makefile has an absolute path where a variable should be writen. Since the $LINKS line is writen with a absolute-path instead of the normal $BINDIR variable, it causes problems when $BINDIR is on another filesystem. This has caused me problems when

Fix: 

in the 'less' Makefile, do this:
LINKS=  ${BINDIR}/less ${BINDIR}/more
How-To-Repeat: Makesure /usr is on another file system from /root. Change into '/usr/src/usr.bin/less', and run the following make command: "make BINDIR=/root/build_area/usr.bin/ install all clean". That will but 'less' in the '/root/build_area/usr.bin/' directory, and next attempt to make a hardlink that targets /usr/bin/more. Since /root, and /usr live on different filesystems, that is imposible. For example: a make fiel might have:
PROG=foo
LINKS= $BINDIR/foo $BINDIR/bar

The 'less' Makefile has:
LINKS= $BINDIR/less /usr/bin/more

That is inconsitent with all the other Makefiles in the /usr/src/usr/bin src area that have the $LINK variable in their Makefile.
Comment 1 Johan Karlsson freebsd_committer freebsd_triage 2002-11-24 11:35:32 UTC
Responsible Changed
From-To: freebsd-bugs->johan

I will take care of this when the code-freeze for  
current is over.
Comment 2 Johan Karlsson freebsd_committer freebsd_triage 2002-12-18 10:15:28 UTC
State Changed
From-To: open->patched

Committed to current. I will MFC after X-mass.
Comment 3 Johan Karlsson freebsd_committer freebsd_triage 2003-02-02 10:05:08 UTC
State Changed
From-To: patched->closed

Committed to -stable