Update of port net/p5-Net-IP to version 1.20. Assume maintainership.
Responsible Changed From-To: freebsd-ports-bugs-> erwin I'll handle this
State Changed From-To: open->feedback ===> Configuring for p5-Net-IP-1.20 Perl 5.008 required--this is only version 5.00503, stopped at ./Makefile.PL line 1. BEGIN failed--compilation aborted at ./Makefile.PL line 1. Could you have try to fix this for lower perl versions or if this doesn't work, mark it IGNORE for anything lower the 5.8 ?
Please see the attachment again, add BUILD_DEPENDS to check Perl 5.8.0. foxfair
On Tue, Jul 01, 2003 at 11:23:29AM +0800, Foxfair Hu wrote: Hi Foxfair, > > Please see the attachment again, add BUILD_DEPENDS to check Perl 5.8.0. > > > +BUILD_DEPENDS= perl5.8.0:${PORTSDIR}/lang/perl5.8 > +PERL_VERSION= 5.8.0 > PERL_CONFIGURE= yes > Please don't do that, this gives more trouble than it's worth. Just two examples, all previously installed perl ports depend on the old perl, this on on the new. This will not work. Another thing you already seen yourself. PERL_VERSION will still be the old perl, which is why your pkg-plist doesn't work. If a perl module really depends on a newer version of perl (most can easily be patched, but I don't think this is one of them) then mark it IGNORE for lower version. See devel/p5-Test-Exception for an example. > post-patch: > - ${PERL} -pi -e 's,/usr/local/ncc/bin,${PREFIX}/bin,' ${WRKSRC}/Makefile.PL > + ${REINPLACE_CMD} -e 's,/usr/local/ncc/bin,${PREFIX}/bin,' ${WRKSRC}/Makefile.PL > Why? You already need perl, so no need to depend on textproc/sed_inplace. Cheers, -erwin -- _._ _,-'""`-._ Erwin Lansing (,-.`._,'( |\`-/| erwin@lansing.dk http://droso.org `-.-' \ )-`( , o o) erwin@FreeBSD.org -bf- `- \`_`"'-
On Tue, Jul 01, 2003 at 08:11:44AM +0200, Erwin Lansing wrote: > On Tue, Jul 01, 2003 at 11:23:29AM +0800, Foxfair Hu wrote: > > Hi Foxfair, > > Please don't do that, this gives more trouble than it's worth. Just two > examples, all previously installed perl ports depend on the old perl, > this on on the new. This will not work. Another thing you already seen > yourself. PERL_VERSION will still be the old perl, which is why your > pkg-plist doesn't work. If a perl module really depends on a newer > version of perl (most can easily be patched, but I don't think this is > one of them) then mark it IGNORE for lower version. See > devel/p5-Test-Exception for an example. > Ok, then it was a wrong approach. How about this one? See the attachment please. > Why? You already need perl, so no need to depend on > textproc/sed_inplace. > > Cheers, > -erwin >
Looking deeper into this, it turns out that the port actually does not need perl 5.8 :) Also, the post-patch wasn't needed. Please find attached revised diff againt current ports tree... Sorry for getting y'all upset :) /Lars
State Changed From-To: feedback->closed Committed, thanks!