Bug 55921 - [patch] add some pkg-plist checking to devel/portlint
Summary: [patch] add some pkg-plist checking to devel/portlint
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-24 12:20 UTC by Edwin Groothuis
Modified: 2003-10-26 21:28 UTC (History)
0 users

See Also:

Attachments
file.diff (884 bytes, patch)
2003-08-24 12:20 UTC, Edwin Groothuis 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Edwin Groothuis freebsd_committer freebsd_triage 2003-08-24 12:20:13 UTC 
Add some checking to portlint for the pkg-plist files:
- "@unexec rm " should have a %D in it to specify the prefix
- "@unexec rm " should have a redirection and or to true in it
- "@unexec rmdir" should have a %D in it to specify the prefix

How-To-Repeat: 
[/usr/ports/net/dhcpdump] root@k7>cat pkg-plist 
@unexec rm lib/xmms/General/libinfopipe.so
@unexec rm %D/lib/xmms/General/libinfopipe-1.3.so
@unexec rm %D/lib/xmms/General/libinfopipe-1.3.so 2>&1 >/dev/null || true
@unexec rmdir lib/xmms/General/libinfopipe.so
@unexec rmdir %D/lib/xmms/General/libinfopipe.so

[/usr/ports/net/dhcpdump] root@k7>portlint -a
WARN: pkg-plist:1 use "%D" to specify prefix.
WARN: pkg-plist:1 add "2>&1 >/dev/null || true" to "@unexec rm".
WARN: pkg-plist:2 add "2>&1 >/dev/null || true" to "@unexec rm".
WARN: pkg-plist:4 use "%D" to specify prefix.
WARN: pkg-plist:5 use "@dirrm" instead of "@unexec rmdir".
WARN: pkg-plist:5 use "@dirrm" instead of "@unexec rmdir".
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2003-08-24 12:24:12 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->marcus

Over to maintainer.
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-10-26 21:27:51 UTC 
State Changed
From-To: open->closed

Committed, thanks!