Bug 57045 - trpt(8) option -t was disabled on -current
Summary: trpt(8) option -t was disabled on -current
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 5.1-CURRENT
Hardware: Any Any
: Normal Affects Only Me
Assignee: Conrad Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-20 23:50 UTC by larse
Modified: 2018-02-15 18:29 UTC (History)
2 users (show)

See Also:


Attachments
patch to usr.sbin/trpt/ (1.87 KB, patch)
2018-02-10 18:37 UTC, Fernando Apesteguía
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description larse 2003-09-20 23:50:15 UTC
trpt(8) describes the -t option:

     -t      In addition to the normal output, print the values for all timers
             at each point in the trace.

Those timers don't exist anymore, and the corresponding code was
commented out by jlemon@ in revision 1.10 of src/usr.sbin/trpt/trpt.c

Fix: 

Remove -t flag documentation from the man page.
Remove -t flag remainders from the trpt.c code.
Comment 1 Ceri Davies freebsd_committer freebsd_triage 2003-10-01 21:36:26 UTC
Responsible Changed
From-To: gnats-admin->freebsd-bugs

Reassign misfiled PR.
Comment 2 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 08:00:50 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2018-02-10 18:37:16 UTC
Created attachment 190486 [details]
patch to usr.sbin/trpt/

The relevant code was commented out in r50680.

The attached patch removes it completely, including the relevant flag and the documentation. After applying the patch:

$ ./trpt -t
trpt: illegal option -- t
usage: trpt [-afjst] [-p hex-address] [system [core]]
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-02-15 18:27:28 UTC
A commit references this bug:

Author: cem
Date: Thu Feb 15 18:26:45 UTC 2018
New revision: 329331
URL: https://svnweb.freebsd.org/changeset/base/329331

Log:
  trpt(8): Fully remove and undocument '-t' option disabled in 1999

  The relevant code was commented out in r50680.

  PR:		57045
  Submitted by:	Fernando Apestegu?a <fernando.apesteguia AT gmail.com>

Changes:
  head/usr.sbin/trpt/trpt.8
  head/usr.sbin/trpt/trpt.c
Comment 5 Conrad Meyer freebsd_committer freebsd_triage 2018-02-15 18:29:56 UTC
Thanks!