Bug 57450 - [update orphaned port] mail/ssmtp: update to 2.60.4 and take maintainership
Summary: [update orphaned port] mail/ssmtp: update to 2.60.4 and take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-01 13:00 UTC by Clement Laforet
Modified: 2003-10-02 00:08 UTC (History)
1 user (show)

See Also:


Attachments
ssmtp.diff (1.48 KB, patch)
2003-10-01 13:00 UTC, Clement Laforet
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Clement Laforet 2003-10-01 13:00:28 UTC
	Changelog:
		- update to 2.60.
		- USE_OPENSSL hook
		- take maintainership

How-To-Repeat: 	N/A.
Comment 1 Oliver Eikemeier 2003-10-01 13:14:16 UTC
Clement Laforet wrote:

>>Synopsis:       [update orphaned port] mail/ssmtp: update to 2.60.4 and take maintainership
The port isn't as orphaned as it seems, but I'm happy that you would like to maintain it.

> 		- update to 2.60.
> 		- USE_OPENSSL hook
> 		- take maintainership

Ok, I see that update to 2.60.4, but where do you use USE_OPENSSL?

> +.include <bsd.port.pre.mk>
> +
> [...]
> -.include <bsd.port.mk>
> +.include <bsd.port.post.mk>
> +

Why do you do this?
Comment 2 Clement Laforet 2003-10-01 13:19:53 UTC
On Wed, 01 Oct 2003 14:14:16 +0200
Oliver Eikemeier <eikemeier@fillmore-labs.com> wrote:

> Clement Laforet wrote:
> 
> Ok, I see that update to 2.60.4, but where do you use USE_OPENSSL?
USE_OPENSSL is already defined.

If my memory serves me right, in order to use correctly USE_OPENSSL hook you need:
* use bsd.port.pre.mk/bsd.port.post.mk
or
* include <bsd.openssl.mk>

I prefer the first one. :)

> > +.include <bsd.port.pre.mk>
> > +
> > [...]
> > -.include <bsd.port.mk>
> > +.include <bsd.port.post.mk>
> > +
> 
> Why do you do this?
now you know ;o)

regards,
clem
Comment 3 Oliver Eikemeier 2003-10-01 13:31:28 UTC
Clement Laforet wrote:

> On Wed, 01 Oct 2003 14:14:16 +0200
> Oliver Eikemeier <eikemeier@fillmore-labs.com> wrote:
> 
>>Clement Laforet wrote:
>>
>>Ok, I see that update to 2.60.4, but where do you use USE_OPENSSL?
> 
> USE_OPENSSL is already defined.
> 
> If my memory serves me right, in order to use correctly USE_OPENSSL hook you need:
> * use bsd.port.pre.mk/bsd.port.post.mk
> or
> * include <bsd.openssl.mk>
> 
> I prefer the first one. :)

.include <bsd.port.mk> is just fine. You may have to fiddle around a bit to
get the program actually to link with OpenSSL from a port. Does it work?

>>>+.include <bsd.port.pre.mk>
>>>+
>>>[...]
>>>-.include <bsd.port.mk>
>>>+.include <bsd.port.post.mk>
>>>+
>>
>>Why do you do this?
> 
> now you know ;o)

Ok, you don't need to do that. You'll get
   .include "${PORTSDIR}/Mk/bsd.openssl.mk"
for free from bsd.port.mk...
Comment 4 Clement Laforet 2003-10-01 16:01:45 UTC
Here's a more "correct" patch.
Thanks to Oliver Eikemeier for his pointing.

Index: ssmtp/Makefile
===================================================================
RCS file: /WORK/REPO/ports/mail/ssmtp/Makefile,v
retrieving revision 1.11
diff -u -r1.11 Makefile
--- ssmtp/Makefile	4 Aug 2003 10:47:28 -0000	1.11
+++ ssmtp/Makefile	1 Oct 2003 14:56:22 -0000
@@ -6,12 +6,12 @@
 #
 
 PORTNAME=	ssmtp
-PORTVERSION=	2.60.3
-CATEGORIES=	mail
+PORTVERSION=	2.60.4
+CATEGORIES=	mail ipv6
 MASTER_SITES=	${MASTER_SITE_DEBIAN_POOL}
 DISTNAME=	${PORTNAME}_${PORTVERSION}
 
-MAINTAINER=	ports@FreeBSD.org
+MAINTAINER=	sheepkiller@cultdeadsheep.org
 COMMENT=	Extremely simple MTA to get mail off the system to a mail hub
 
 WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION:C/\.[0-9]+$//}
@@ -23,6 +23,8 @@
 USE_REINPLACE=	yes
 
 CONFIGURE_ARGS=	--enable-ssl --enable-inet6
+CFLAGS+=	-I${OPENSSLINC}
+LDFLAGS+=	-L${OPENSSLLIB}
 MAILERCONF=	/etc/mail/mailer.conf
 TRUE=		/usr/bin/true
 
Index: ssmtp/distinfo
===================================================================
RCS file: /WORK/REPO/ports/mail/ssmtp/distinfo,v
retrieving revision 1.2
diff -u -r1.2 distinfo
--- ssmtp/distinfo	14 Apr 2003 01:29:12 -0000	1.2
+++ ssmtp/distinfo	1 Oct 2003 14:55:50 -0000
@@ -1 +1 @@
-MD5 (ssmtp_2.60.3.tar.gz) = b9b1c07f513ff2b46ae8a09eaf3e04e5
+MD5 (ssmtp_2.60.4.tar.gz) = 88fff70f14a001e09b713aa6326162cf
Index: ssmtp/files/patch-configure
===================================================================
RCS file: /WORK/REPO/ports/mail/ssmtp/files/patch-configure,v
retrieving revision 1.1
diff -u -r1.1 patch-configure
--- ssmtp/files/patch-configure	14 Apr 2003 01:29:12 -0000	1.1
+++ ssmtp/files/patch-configure	1 Oct 2003 14:59:24 -0000
@@ -1,11 +1,11 @@
 --- configure.orig	Fri Sep 27 14:47:52 2002
-+++ configure	Mon Apr  7 01:03:46 2003
++++ configure	Wed Oct  1 16:42:07 2003
 @@ -1340,7 +1340,7 @@
  #define HAVE_SSL 1
  EOF
  
 -	LIBS="$LIBS -lssl"
-+	LIBS="$LIBS -lssl -lcrypto"
++	LIBS="$LIBS $LDFLAGS -lssl -lcrypto"
  fi
  enableval=""
Comment 5 Clement Laforet 2003-10-01 16:01:45 UTC
Here's a more "correct" patch.
Thanks to Oliver Eikemeier for his pointing.

Index: ssmtp/Makefile
===================================================================
RCS file: /WORK/REPO/ports/mail/ssmtp/Makefile,v
retrieving revision 1.11
diff -u -r1.11 Makefile
--- ssmtp/Makefile	4 Aug 2003 10:47:28 -0000	1.11
+++ ssmtp/Makefile	1 Oct 2003 14:56:22 -0000
@@ -6,12 +6,12 @@
 #
 
 PORTNAME=	ssmtp
-PORTVERSION=	2.60.3
-CATEGORIES=	mail
+PORTVERSION=	2.60.4
+CATEGORIES=	mail ipv6
 MASTER_SITES=	${MASTER_SITE_DEBIAN_POOL}
 DISTNAME=	${PORTNAME}_${PORTVERSION}
 
-MAINTAINER=	ports@FreeBSD.org
+MAINTAINER=	sheepkiller@cultdeadsheep.org
 COMMENT=	Extremely simple MTA to get mail off the system to a mail hub
 
 WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION:C/\.[0-9]+$//}
@@ -23,6 +23,8 @@
 USE_REINPLACE=	yes
 
 CONFIGURE_ARGS=	--enable-ssl --enable-inet6
+CFLAGS+=	-I${OPENSSLINC}
+LDFLAGS+=	-L${OPENSSLLIB}
 MAILERCONF=	/etc/mail/mailer.conf
 TRUE=		/usr/bin/true
 
Index: ssmtp/distinfo
===================================================================
RCS file: /WORK/REPO/ports/mail/ssmtp/distinfo,v
retrieving revision 1.2
diff -u -r1.2 distinfo
--- ssmtp/distinfo	14 Apr 2003 01:29:12 -0000	1.2
+++ ssmtp/distinfo	1 Oct 2003 14:55:50 -0000
@@ -1 +1 @@
-MD5 (ssmtp_2.60.3.tar.gz) = b9b1c07f513ff2b46ae8a09eaf3e04e5
+MD5 (ssmtp_2.60.4.tar.gz) = 88fff70f14a001e09b713aa6326162cf
Index: ssmtp/files/patch-configure
===================================================================
RCS file: /WORK/REPO/ports/mail/ssmtp/files/patch-configure,v
retrieving revision 1.1
diff -u -r1.1 patch-configure
--- ssmtp/files/patch-configure	14 Apr 2003 01:29:12 -0000	1.1
+++ ssmtp/files/patch-configure	1 Oct 2003 14:59:24 -0000
@@ -1,11 +1,11 @@
 --- configure.orig	Fri Sep 27 14:47:52 2002
-+++ configure	Mon Apr  7 01:03:46 2003
++++ configure	Wed Oct  1 16:42:07 2003
 @@ -1340,7 +1340,7 @@
  #define HAVE_SSL 1
  EOF
  
 -	LIBS="$LIBS -lssl"
-+	LIBS="$LIBS -lssl -lcrypto"
++	LIBS="$LIBS $LDFLAGS -lssl -lcrypto"
  fi
  enableval=""
Comment 6 Christian Weisgerber freebsd_committer freebsd_triage 2003-10-02 00:08:14 UTC
State Changed
From-To: open->closed

Committed, thanks.