Bug 59289 - [bktr] [patch] ioctl METEORGBRIG in bktr_core.c forgets to add 128 to value
Summary: [bktr] [patch] ioctl METEORGBRIG in bktr_core.c forgets to add 128 to value
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 5.1-RELEASE
Hardware: Any Any
: Normal Affects Only Me
Assignee: Josh Paetzel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-14 15:10 UTC by Daan Vreeken [PA4DAN]
Modified: 2017-06-27 03:59 UTC (History)
1 user (show)

See Also:

Attachments
diff (403 bytes, patch)
2003-11-14 15:10 UTC, Daan Vreeken [PA4DAN] 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daan Vreeken [PA4DAN] 2003-11-14 15:10:12 UTC 
In bktr_core.c the ioctl METEORSBRIG substracts 128 from the given value
before storing it in the right brightness register, but METEORGBRIG doesn't
add 128 to the value it gets out of the register.

Fix: The following patch is agains -CURRENT and simply adds +128 to the value
that's read from the register.
How-To-Repeat: wantedvalue=129;
ioctl(bktr,METEORSBRIG,&wantedvalue);
ioctl(bktr,METEORGBRIG,&returnedvalue);

if (returnedvalue!=wantedvalue)
        printf("EEK!\n");
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2004-08-31 01:09:35 UTC 
Responsible Changed
From-To: freebsd-bugs->roger

Over to bktr maintainer.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2004-11-04 08:22:19 UTC 
Responsible Changed
From-To: roger->freebsd-bugs

Assignee is currently away from doing FreeBSD work at the moment, so 
at his request, return this one to the pool.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-06-27 03:58:18 UTC 
A commit references this bug:

Author: jpaetzel
Date: Tue Jun 27 03:57:31 UTC 2017
New revision: 320394
URL: https://svnweb.freebsd.org/changeset/base/320394

Log:
  ioctl METEORGBRIG in bktr_core.c forgets to add 128 to value

  PR:	59289
  Submitted by:	Danovitsch@Vitsch.net

Changes:
  head/sys/dev/bktr/bktr_core.c
Comment 4 Josh Paetzel freebsd_committer freebsd_triage 2017-06-27 03:58:48 UTC 
13 years later...committed, thanks!