Bug 60410 - Port Update: Proc-ProcessTable 0.38 -> 0.39
Summary: Port Update: Proc-ProcessTable 0.38 -> 0.39
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-12-20 04:10 UTC by Michael Johnson
Modified: 2005-05-04 23:30 UTC (History)
0 users

See Also:


Attachments
file.diff (778 bytes, patch)
2003-12-20 04:10 UTC, Michael Johnson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Johnson 2003-12-20 04:10:21 UTC

    
Comment 1 Pete Fritchman freebsd_committer freebsd_triage 2003-12-21 05:35:11 UTC
State Changed
From-To: open->feedback

I can't build this on 4.x: 
ProcessTable.xs: In function `ppt_warn': 
ProcessTable.xs:60: `dTHX' undeclared (first use in this function) 
ProcessTable.xs:60: (Each undeclared identifier is reported only once 
ProcessTable.xs:60: for each function it appears in.) 
ProcessTable.xs:61: syntax error before `args' 
ProcessTable.xs:62: `args' undeclared (first use in this function) 
ProcessTable.xs: In function `ppt_croak': 
ProcessTable.xs:69: `dTHX' undeclared (first use in this function) 
ProcessTable.xs:70: syntax error before `args' 
ProcessTable.xs:71: `args' undeclared (first use in this function) 
*** Error code 1
Comment 2 Michael Johnson 2003-12-21 08:40:08 UTC
tested on 4.9 and 5.2


diff -ruN devel/p5-Proc-ProcessTable.orig/files/patch-processtable.xs 
devel/p5-Proc-ProcessTable/files/patch-processtable.xs
--- devel/p5-Proc-ProcessTable.orig/files/patch-processtable.xs	Thu Jan 
  1 00:00:00 1970
+++ devel/p5-Proc-ProcessTable/files/patch-processtable.xs	Sun Dec 21 
01:17:01 2003
@@ -0,0 +1,33 @@
+--- ProcessTable.xs.orig	Sat May 31 13:05:56 2003
++++ ProcessTable.xs	Sat Dec 20 20:16:41 2003
+@@ -32,7 +32,6 @@
+ #include <stdarg.h>
+
+ /* prototypes to make the compiler shut up */
+-void ppt_warn(const char*, ...);
+ void ppt_die(const char*, ...);
+ void store_ttydev(HV*, unsigned long);
+ void bless_into_proc(char* , char**, ...);
+@@ -56,22 +55,7 @@
+  * croak() in perl 5.8?? warn and croak exist in 5.6, but don't
+  * seem to accept format args.
+  */
+-void ppt_warn(const char *pat, ...) {
+-    dTHX;
+-    va_list args;
+-    va_start(args, pat);
+-    vwarn(pat, &args);
+-    va_end(args);
+-}
+
+-/* same with croak */
+-void ppt_croak(const char *pat, ...) {
+-    dTHX;
+-    va_list args;
+-    va_start(args, pat);
+-    vcroak(pat, &args);
+-    va_end(args);
+-}
+
+ /* Look up the tty device, given the ttynum and store it */
+ void store_ttydev( HV* myhash, unsigned long ttynum ){
Comment 3 Pete Fritchman freebsd_committer freebsd_triage 2003-12-21 17:03:59 UTC
State Changed
From-To: feedback->closed

Committed, thanks.
Comment 4 nwu 2005-05-04 23:25:45 UTC
Hello,

 

I try to install perl ProcessTable module,
Proc-ProcessTable-0.39.tar.gz
<http://search.cpan.org/CPAN/authors/id/D/DU/DURIST/Proc-ProcessTable-0.
39.tar.gz>  downloaded from
http://search.cpan.org/~durist/Proc-ProcessTable-0.39/ProcessTable.pm,
onto FreeBSD 4.11-RELEASE. 

 

"perl Makefile.PL" generates results:

Processing hints file hints/freebsd.pl

Warning: prerequisite Storable 0 not found at (eval 1) line 219.

Writing Makefile for Proc::ProcessTable::Process

Writing Makefile for Proc::ProcessTable

Is the warning OK?

 

When I try to "make", it gave error:

cc -c        -DVERSION=\"0.39\"  -DXS_VERSION=\"0.39\" -DPIC -fpic
-I/usr/libdata/perl/5.00503/mach/CORE  OS.c  ProcessTable.c

ProcessTable.xs: In function `ppt_warn':

ProcessTable.xs:60: `dTHX' undeclared (first use in this function)

ProcessTable.xs:60: (Each undeclared identifier is reported only once

ProcessTable.xs:60: for each function it appears in.)

ProcessTable.xs:61: syntax error before `args'

ProcessTable.xs:62: `args' undeclared (first use in this function)

ProcessTable.xs: In function `ppt_croak':

ProcessTable.xs:69: `dTHX' undeclared (first use in this function)

ProcessTable.xs:70: syntax error before `args'

ProcessTable.xs:71: `args' undeclared (first use in this function)

*** Error code 1

 

Stop in /usr/home/nwu/Proc-ProcessTable-0.39.

 

I found your posting at:
http://www.freebsd.org/cgi/query-pr.cgi?pr=60410

No changes made in devel/p5-Proc-ProcessTable.orig/Makefile and
devel/p5-Proc-ProcessTable/distinfo, since the current version is 0.39.
The changes made inside
devel/p5-Proc-ProcessTable/files/patch-processtable.xs as following:

 

+++FreeBSD:
ports/devel/p5-Proc-ProcessTable/files/patch-processtable.xs,v 1.1 2

003/12/21 17:03:51 petef Exp $

 

+--- ProcessTable.xs.orig       Sat May 31 13:05:56 2003

++++ ProcessTable.xs    Sat Dec 20 20:16:41 2003

+@@ -32,7 +32,6 @@

+ #include <stdarg.h>

+

+ /* prototypes to make the compiler shut up */

+-void ppt_warn(const char*, ...);

+ void ppt_die(const char*, ...);

+ void store_ttydev(HV*, unsigned long);

+ void bless_into_proc(char* , char**, ...);

+@@ -56,22 +55,7 @@

+  * croak() in perl 5.8?? warn and croak exist in 5.6, but don't

+  * seem to accept format args.

+  */

+-void ppt_warn(const char *pat, ...) {

+-    dTHX;

+-    va_list args;

+-    va_start(args, pat);

+-    vwarn(pat, &args);

+-    va_end(args);

+-}

+

+-/* same with croak */

+-void ppt_croak(const char *pat, ...) {

+-    dTHX;

+-    va_list args;

+-    va_start(args, pat);

+-    vcroak(pat, &args);

+-    va_end(args);

+-}

+

+ /* Look up the tty device, given the ttynum and store it */

+ void store_ttydev( HV* myhash, unsigned long ttynum ){

 

But the make results are the same. Could you help me to get out of this?

 

Thanks in advance,

 

Na