Bug 61741 - bsd.java.mk gives wrong advice re: NEED_JAVAC
Summary: bsd.java.mk gives wrong advice re: NEED_JAVAC
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: java (show other bugs)
Version: 4.9-STABLE
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ernst de Haan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-22 18:00 UTC by stolz
Modified: 2004-01-23 07:44 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description stolz 2004-01-22 18:00:29 UTC 
From /usr/share/Mk/bsd.java.mk:

# The default value for NEED_JAVAC is temporarily (!) YES
# This will change as soon as the affecting ports have NEED_JAVAC=YES
.               if !defined(NEED_JAVAC)
NEED_JAVAC=     NO
.               endif

Obviously NEED_JAVAC defaults to NO. Either to comment above is incorrect
or the default setting is. The comment in rev. 1.9 clearly indicates that the
default changed to NO deliberately.

Fix: 

Remove offending comment.
How-To-Repeat: Trying to use ${JAVAC} in a port-makefile without setting NEED_JAVAC to "yes" first
leaves ${JAVAC} undefined.
Comment 1 Ernst de Haan freebsd_committer freebsd_triage 2004-01-23 07:40:41 UTC 
Responsible Changed
From-To: freebsd-java->znerd

My call.
Comment 2 Ernst de Haan freebsd_committer freebsd_triage 2004-01-23 07:43:28 UTC 
State Changed
From-To: open->closed

Fix committed, thanks!