Bug 6341 - make install uses ``make'' instead of ${MAKE} causing package registration to fail
Summary: make install uses ``make'' instead of ${MAKE} causing package registration to...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Steve Price
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 1998-04-18 17:20 UTC by rotel
Modified: 1998-05-04 10:41 UTC (History)
0 users

See Also:


Attachments
file.diff (1.46 KB, patch)
1998-04-18 17:20 UTC, rotel
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rotel 1998-04-18 17:20:02 UTC
On my system /usr/local/bin/make is a symlink to /usr/local/bin/gmake,
/usr/local/bin/pmake is a symlink to /usr/bin/make and /usr/local/bin
comes before /usr/bin in my PATH.  Therefore ``make'' executes GNU
make and ``pmake'' executes PMake.

When installing a port I ``pmake all install'', however since
bsd.port.mk executes ``make'' instead of ``${MAKE}'' in some places,
package registration fails GNU make is invoked and it doesn't grok
the Makefiles used in the ports system

Fix: Fix bsd.port.mk to use ${MAKE} instead of make by applying this patch:

How-To-Repeat: 
$ cd /usr/local/bin
$ ln gmake make
$ ln -s /usr/bin/make pmake
$ cd /usr/ports/lang/perl
$ PATH=/usr/local/bin:$PATH pmake all install
 
[...]
 
===>   Compressing manual pages for perl-5.00404
===>  Registering installation for perl-5.00404
Makefile:70: *** missing separator.  Stop.
$
Comment 1 Satoshi Asami freebsd_committer freebsd_triage 1998-04-19 10:00:52 UTC
 * On my system /usr/local/bin/make is a symlink to /usr/local/bin/gmake,
 * /usr/local/bin/pmake is a symlink to /usr/bin/make and /usr/local/bin
 * comes before /usr/bin in my PATH.  Therefore ``make'' executes GNU
 * make and ``pmake'' executes PMake.

I certainly won't object changing bsd.port.mk (thanks for the patch),
but having /usr/local/bin in front of /usr/bin is a good way to get
your build killed in any case.  I am surprised that the make symlink
is the only one that tripped you up. :)

Satoshi
Comment 2 Steve Price freebsd_committer freebsd_triage 1998-05-04 05:04:07 UTC
State Changed
From-To: open->feedback

Satoshi seemed to approve of this, so let's go ahead and 
put it in -current and see how things fare. :) 


Comment 3 Steve Price freebsd_committer freebsd_triage 1998-05-04 05:04:07 UTC
Responsible Changed
From-To: freebsd-ports->steve

So I get the blame if it doesn't work. 
Comment 4 Steve Price freebsd_committer freebsd_triage 1998-05-04 10:40:34 UTC
State Changed
From-To: feedback->closed

Merged to RELENG_2_2 and RELENG_2_1_0 at Satoshi's request.