Bug 7488 - Typos in catman/makewhatis perl scripts
Summary: Typos in catman/makewhatis perl scripts
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: gnu (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 1998-08-04 11:10 UTC by lhecking
Modified: 1998-08-05 04:45 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description lhecking 1998-08-04 11:10:00 UTC
1) Typo in help for makewhatis.perl

2) Typo (?) in chmod invocation in catman.perl. Potentially harmful.

Fix: Ad1)


Ad2)--- catman.perl Tue Aug  4 10:46:10 1998
+++ catman.perl.new     Tue Aug  4 11:00:44 1998
@@ -176,7 +176,7 @@
     $catdir = &man2cat($subdir);
     if (-d $catdir) {
        return 1 if -w _;
-       if (!chmod(755, $catdir)) {
+       if (!chmod(0755, $catdir)) {
            warn "Cannot write $catdir, chmod: $!\n";
            $exit = 1;
            return 0;--bTi9ohpV9OET4abQsAtwNsFP8VneDzYmSHcIBqEhRr7JAuRe
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- makewhatis.perl     Tue Aug  4 10:46:20 1998
+++ makewhatis.perl.new Tue Aug  4 10:59:42 1998
@@ -32,7 +32,7 @@
 sub usage {
 
     warn <<EOF;
-usage: makewhatis [-a|-append ] [-h|-help] [-i|-indent colum]
+usage: makewhatis [-a|-append ] [-h|-help] [-i|-indent column]
                   [-n|-name name] [-o|-outfile file] [-v|-verbose] 
                   [directories ...]
 EOF
How-To-Repeat: vi +35 catman.perl 
vi +179 makewhatis.perl
;)
Comment 1 thepish freebsd_committer freebsd_triage 1998-08-04 13:09:21 UTC
State Changed
From-To: open->closed

patches applied. Thanks 
Comment 2 Bruce Evans freebsd_committer freebsd_triage 1998-08-04 18:27:59 UTC
State Changed
From-To: closed->open

Patches not applied to -current. 
Comment 3 thepish freebsd_committer freebsd_triage 1998-08-05 04:45:08 UTC
State Changed
From-To: open->closed

merge from stable to current. Thanks to bde for the reminder