Bug 7560 - [PATCH] format string problems in sysinstall
Summary: [PATCH] format string problems in sysinstall
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 3.0-CURRENT
Hardware: Any Any
: Normal Affects Only Me
Assignee: jkh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 1998-08-10 20:10 UTC by Stefan Eggers
Modified: 1998-09-14 20:13 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (657 bytes, patch)
1998-08-10 20:10 UTC, Stefan Eggers 		no flags Details | Diff
file.diff (567 bytes, patch)
1998-08-10 20:10 UTC, Stefan Eggers 		no flags Details | Diff
file.diff (1.16 KB, patch)
1998-08-10 20:10 UTC, Stefan Eggers 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Eggers 1998-08-10 20:10:00 UTC 
	While compiling sysinstall I notieced several warnings about
format string errors.  Turned out they are harmless with gcc on a
little endian machine as long as the values printed are small enough
and that's probably why nobody noticed a malfunction due to them.

	The ones in ufs.c are harmless I think but annoying.  Adding
casts makes them go away.

Fix: Actually three - one for each affected file.
How-To-Repeat: 
	Try compiling sysinstall.  You'll see warnings from gcc about
wrong format strings.
Comment 1 Wolfram Schneider freebsd_committer freebsd_triage 1998-08-12 09:35:42 UTC 
Responsible Changed
From-To: freebsd-bugs->jkh

Jordans area.
Comment 2 Poul-Henning Kamp freebsd_committer freebsd_triage 1998-08-14 07:15:22 UTC 
State Changed
From-To: open->suspended

awaiting jordans attention
Comment 3 jkh freebsd_committer freebsd_triage 1998-09-14 20:03:42 UTC 
State Changed
From-To: suspended->closed

Applied, thanks!