Bug 84644 - Java port lies about what files to fetch
Summary: Java port lies about what files to fetch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alexey Zelkin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-07 15:40 UTC by Bill Fenner
Modified: 2005-12-14 16:52 UTC (History)
0 users

See Also:


Attachments
file.diff (3.14 KB, patch)
2005-08-07 15:40 UTC, Bill Fenner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bill Fenner 2005-08-07 15:40:08 UTC
	
When trying to build jdk14 on a fresh system, it first says
"You have the source, but have to fetch the patches."
Then it says "You have to fetch the binary stuff."
Then it says "You have to fetch the source stuff."
If you find the manual fetching annoying in the first
place, you're likely to get even more annoyed by the
fact that it first lies ("You have the source...") and
then forces you to try building 3 times before it
works.

Fix: Here's my proposed fix.  I've tested it with several combinations
of files present or not.

It also updates the wording to reflect the current organization
of the Sun download page more closely.

Note that this problem appears to exist with all of the java ports;
I've only fixed jdk14 because this was the one that pissed me off,
but obviously the others could use the fix too.

How-To-Repeat: 	
rm /usr/ports/distfiles/jdk14* /usr/ports/distfiles/bsd*jdk14*
cd /usr/ports/java/jdk14
make
<fetch patch file, wonder why it says you have the sources
 when you clearly don't>
make
<fetch binary file, wonder why it didn't say that you would
 have to fetch this one too>
make
<fetch source file, wonder why in the world the port is written
 this way>
make
<success>
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2005-08-10 08:03:13 UTC
Responsible Changed
From-To: freebsd-ports-bugs->phantom

Over to maintainer.
Comment 2 Greg Lewis freebsd_committer freebsd_triage 2005-12-14 16:52:52 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!