Bug 86686 - fix emulators/qemu on 4.x, and fix (forced) package
Summary: fix emulators/qemu on 4.x, and fix (forced) package
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Marcus Alves Grando
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-28 21:50 UTC by Juergen Lock
Modified: 2005-10-01 14:25 UTC (History)
0 users

See Also:

Attachments
file.diff (7.56 KB, patch)
2005-09-28 21:50 UTC, Juergen Lock 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Juergen Lock 2005-09-28 21:50:14 UTC 
	make it work on 4.x again (at least in qemu :)
	fix (forced) package
	(use the old distfile, Fabrice didnt commit anything since then)

How-To-Repeat: 	n/a
Comment 1 Marcus Alves Grando freebsd_committer freebsd_triage 2005-09-30 18:16:23 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->mnag

I'll take it.
Comment 2 Marcus Alves Grando freebsd_committer freebsd_triage 2005-09-30 19:23:26 UTC 
State Changed
From-To: open->feedback

Ask to fix 4.x
Comment 3 Marcus Alves Grando freebsd_committer freebsd_triage 2005-09-30 19:25:09 UTC 
Dear maintainer,

Can you fix this error when compile on 4.x?

http://marcus.grupos.com.br:8080/logs/4-STABLE-FreeBSD/qemu-0.7.2s.20050909_1.log

Thanks

-- 
Marcus Alves Grando
Grupos Internet S/A
marcus(at)corp.grupos.com.br
  mnag(at)FreeBSD.org
Comment 4 Juergen Lock 2005-09-30 22:19:53 UTC 
On Fri, Sep 30, 2005 at 03:25:09PM -0300, Marcus Alves Grando wrote:
> Dear maintainer,
> 
> Can you fix this error when compile on 4.x?
> 
> http://marcus.grupos.com.br:8080/logs/4-STABLE-FreeBSD/qemu-0.7.2s.20050909_1.log

Hmm, 404 :(

 Anyway you did apply the patch from the pr?

	Juergen
Comment 5 Juergen Lock 2005-10-01 00:13:43 UTC 
On Fri, Sep 30, 2005 at 03:25:09PM -0300, Marcus Alves Grando wrote:
> Dear maintainer,
> 
> Can you fix this error when compile on 4.x?
> 
> http://marcus.grupos.com.br:8080/logs/4-STABLE-FreeBSD/qemu-0.7.2s.20050909_1.log

[Cc'ing bug-followup@ so the pr gets the file too:]

 Seems I forgot to post one file:

Index: files/patch-libmath4
@@ -0,0 +1,45 @@
+Index: qemu/bsd/i386/s_ldexpl.c
+@@ -2,6 +2,30 @@
+ #include <errno.h>
+ #include <sysdep.h>
+ 
++/* 4.x doesnt have isfinite */
++#ifndef isfinite
++#define isfinite __isfinitel
++
++union IEEEl2bits {
++	long double	e;
++	struct {
++		unsigned int	manl	:32;
++		unsigned int	manh	:32;
++		unsigned int	exp	:15;
++		unsigned int	sign	:1;
++		unsigned int	junk	:16;
++	} bits;
++};
++
++static int __isfinitel(long double x)
++{
++	union IEEEl2bits u;
++
++	u.e = x;
++	return (u.bits.exp != 32767);
++}
++#endif
++
+ long double __ldexpl(long double x, int expn)
+ {
+   long double res;
+Index: qemu/bsd/i386/s_round.c
+@@ -29,6 +29,11 @@
+ 
+ #include <math.h>
+ 
++/* 4.x doesnt have isfinite */
++#ifndef isfinite
++#define isfinite(x) (!isnan(x) && !isinf(x))
++#endif
++
+ double
+ round(double x)
+ {

 Thanx again for the report,
	Juergen
Comment 6 Marcus Alves Grando freebsd_committer freebsd_triage 2005-10-01 14:25:54 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!