Bug 88878 - japanese/ipa-ttfonts: install fontconfig conf file and run fc-cache after installation
Summary: japanese/ipa-ttfonts: install fontconfig conf file and run fc-cache after ins...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Hiroki Sato
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-12 06:20 UTC by NIIMI Satoshi
Modified: 2005-11-13 19:05 UTC (History)
1 user (show)

See Also:


Attachments
ipa-ttfonts.diff (4.62 KB, patch)
2005-11-12 06:20 UTC, NIIMI Satoshi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description NIIMI Satoshi 2005-11-12 06:20:13 UTC
* fontconfig does not know about IPA TT fonts, so they are not used as
aliases of common "serif" "sans-serif" "monospace".

* fc-cache should be run after installing or deinstalling of this
package.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2005-11-12 06:22:51 UTC
Responsible Changed
From-To: freebsd-ports-bugs->hrs

Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=88878 
Adding to audit trail from misfiled PR ports/88915:

Date: Sun, 13 Nov 2005 20:08:27 +0900 (JST)
Comment 2 NIIMI Satoshi 2005-11-13 14:33:38 UTC
On 2005/11/13 20:08, Hiroki Sato wrote:
>  Do we really need to put fc-cahe into BUILD_DEPENDS?
>  I think it should be RUN_DEPENDS.

Only RUN_DEPENDS is sufficient.  I misunderstood that BUILD_DEPENDS is 
required for install.

>  Do you have any specific reasons to remove this?

So that next line
 >  @unexec rmdir %%X_FONTSDIR%% 2> /dev/null || true
can remove the directory if empty.

fc-cache does not remove fonts.cache-1 on empty directory.  But creates 
0-byte one.

-- 
NIIMI Satoshi
Comment 3 Hiroki Sato freebsd_committer freebsd_triage 2005-11-13 15:24:06 UTC
----Security_Multipart(Mon_Nov_14_00_24_06_2005_066)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

NIIMI Satoshi <sa2c@sa2c.net> wrote
  in <43774EC2.2090507@sa2c.net>:

sa> On 2005/11/13 20:08, Hiroki Sato wrote:
sa> >  Do you have any specific reasons to remove this?
sa>
sa> So that next line
sa>  >  @unexec rmdir %%X_FONTSDIR%% 2> /dev/null || true
sa> can remove the directory if empty.
sa>
sa> fc-cache does not remove fonts.cache-1 on empty directory.  But creates
sa> 0-byte one.

 I prefer the following conditional removal because in such a remove-and-
 recreate-forcibly way the 0-byte fonts.cache-1 will be left when
 there are no font and some non-font files in that directory:

 @unexec rm -f %%X_FONTSDIR%%/ipam.ttf
 @unexec rm -f %%X_FONTSDIR%%/ipamp.ttf
+@unexec %%X11BASE%%/bin/fc-cache -f -v %%X_FONTSDIR%% || true
+@unexec if [ -s %%X_FONTSDIR%%/fonts.cache-1 ]; then rm -f %%X_FONTSDIR%%/fonts.cache-1; fi
 @unexec rmdir %%X_FONTSDIR%% 2> /dev/null || true

 How about this?

--
| Hiroki SATO

----Security_Multipart(Mon_Nov_14_00_24_06_2005_066)--
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)

iD8DBQBDd1qWTyzT2CeTzy0RAgcdAJ9/ENSN1GROD9IvzNra8MNR3JO0aACcCYwc
eTdgm3d4unqp2nZ0+jmBTdc=
=INpf
-----END PGP SIGNATURE-----

----Security_Multipart(Mon_Nov_14_00_24_06_2005_066)----
Comment 4 NIIMI Satoshi 2005-11-13 18:46:05 UTC
On 2005/11/14 00:24, Hiroki Sato wrote:
>  I prefer the following conditional removal because in such a remove-and-
>  recreate-forcibly way the 0-byte fonts.cache-1 will be left when
>  there are no font and some non-font files in that directory:
> 
>  @unexec rm -f %%X_FONTSDIR%%/ipam.ttf
>  @unexec rm -f %%X_FONTSDIR%%/ipamp.ttf
> +@unexec %%X11BASE%%/bin/fc-cache -f -v %%X_FONTSDIR%% || true
> +@unexec if [ -s %%X_FONTSDIR%%/fonts.cache-1 ]; then rm -f %%X_FONTSDIR%%/fonts.cache-1; fi
>  @unexec rmdir %%X_FONTSDIR%% 2> /dev/null || true
> 
>  How about this?

I agree with your change.

-- 
NIIMI Satoshi
Comment 5 Hiroki Sato freebsd_committer freebsd_triage 2005-11-13 19:03:55 UTC
State Changed
From-To: open->closed

Committed with some modification.  Thank you for the submission!