Tiny ERP is an open source application written in python running on postgresql
State Changed From-To: open->feedback Thanks for your PR. I have several remarks or questions: - CATEGORIES: python is not a main category. I have set misc, but finance might be better. - You don't need to depend on postgresql81-server, the database server could run on another machine, but a client is necessary (it is implied by the dependency towards databases/py-psycopg). - A dependency towards graphics/graphviz should be added. - Please try to install the docs under ${DOCSDIR} and use the macros %%PORTDOCS%% and %%DOCSDIR%%. - Do you plan to port the client? - Several fixes to pet portlint and fix man page installation. Could you please check the following patch? --- tinyerp.diff begins here --- diff -urN misc/tinyerp.orig/Makefile misc/tinyerp/Makefile --- misc/tinyerp.orig/Makefile Wed Mar 1 22:39:37 2006 +++ misc/tinyerp/Makefile Thu Mar 2 00:17:12 2006 @@ -1,34 +1,34 @@ -# New ports collection makefile for: tinyerp -# Date created: 22 February 2006 -# Whom: Jordi Haarman +# New ports collection makefile for: tinyerp +# Date created: 22 February 2006 +# Whom: Jordi Haarman # # $FreeBSD$ # -PORTNAME= tinyerp-server -PORTVERSION= 3.2.1 -CATEGORIES= python -MASTER_SITES= http://tinyerp.org/download/sources/ -DISTNAME= ${PORTNAME}-${PORTVERSION} +PORTNAME= tinyerp-server +PORTVERSION= 3.2.1 +CATEGORIES= misc python +MASTER_SITES= http://tinyerp.org/download/sources/ +DISTNAME= ${PORTNAME}-${PORTVERSION} EXTRACT_SUFX= .tgz -MAINTAINER= jhaarman-keyword-tinyerpPort.fd583c@projects.synantics.net -COMMENT= Open source application ERP & CRM in Python using Postgresql +MAINTAINER= jhaarman-keyword-tinyerpPort.fd583c@projects.synantics.net +COMMENT= Open source application ERP & CRM in Python using Postgresql -BUILD_DEPENDS= postgres:${PORTSDIR}/databases/postgresql81-server - ${PYTHON_SITELIBDIR}/PIL/__init__.py:${PORTSDIR}/graphics/py-imaging +BUILD_DEPENDS= ${PYTHON_SITELIBDIR}/PIL/__init__.py:${PORTSDIR}/graphics/py-imaging ${PYTHON_SITELIBDIR}/libxml2.py:${PORTSDIR}/textproc/py-libxml2 ${PYTHON_SITELIBDIR}/libxslt.py:${PORTSDIR}/textproc/py-libxslt ${PYTHON_SITELIBDIR}/mx/__init__.py:${PORTSDIR}/lang/py-mx-base ${PYTHON_SITELIBDIR}/pyparsing.py:${PORTSDIR}/devel/py-parsing ${PYTHON_SITELIBDIR}/psycopgmodule.so:${PORTSDIR}/databases/py-psycopg ${PYTHON_SITELIBDIR}/reportlab/__init__.py:${PORTSDIR}/print/py-reportlab - -RUN_DEPENDS= ${BUILD_DEPENDS} +RUN_DEPENDS= ${BUILD_DEPENDS} WRKSRC= ${WRKDIR}/server -USE_PYTHON= 2.4+ +USE_PYTHON= 2.4+ USE_PYDISTUTILS=yes + +MAN1= tinyerp-server.1 .include <bsd.port.mk> diff -urN misc/tinyerp.orig/files/patch-setup.py misc/tinyerp/files/patch-setup.py --- misc/tinyerp.orig/files/patch-setup.py Thu Jan 1 01:00:00 1970 +++ misc/tinyerp/files/patch-setup.py Wed Mar 1 23:55:20 2006 @@ -0,0 +1,11 @@ +--- ./setup.py.orig Mon Jan 23 10:43:47 2006 ++++ ./setup.py Wed Mar 1 23:54:43 2006 +@@ -59,7 +59,7 @@ + + def data_files(): + '''Build list of data files to be installed''' +- files = [(opj('share', 'man', 'man1'), ++ files = [(opj('man', 'man1'), + ['man/tinyerp-server.1']), + (opj('share','doc', 'tinyerp-server-%s' % version), + [f for f in glob.glob('doc/*') if os.path.isfile(f)]), diff -urN misc/tinyerp.orig/pkg-descr misc/tinyerp/pkg-descr --- misc/tinyerp.orig/pkg-descr Wed Mar 1 22:39:37 2006 +++ misc/tinyerp/pkg-descr Thu Mar 2 00:17:40 2006 @@ -3,4 +3,4 @@ It connects and improves business processes; sales, finance, supply chain, project management, inventory control, ... -WWW: http://tinyerp.org +WWW: http://tinyerp.org/ diff -urN misc/tinyerp.orig/pkg-plist misc/tinyerp/pkg-plist --- misc/tinyerp.orig/pkg-plist Wed Mar 1 22:39:37 2006 +++ misc/tinyerp/pkg-plist Wed Mar 1 22:57:46 2006 @@ -1126,8 +1126,6 @@ share/doc/tinyerp-server-3.2.0/INSTALL share/doc/tinyerp-server-3.2.0/README share/doc/tinyerp-server-3.2.0/README.pychart -share/man/man1/tinyerp-server.1 -@exec mkdir -p %D/share/doc/tinyerp-server-3.2.0/i18n @dirrm share/doc/tinyerp-server-3.2.0/i18n @dirrm share/doc/tinyerp-server-3.2.0 @dirrm %%PYTHON_SITELIBDIR%%/tinyerp-server/workflow @@ -1336,5 +1334,3 @@ @dirrm %%PYTHON_SITELIBDIR%%/tinyerp-server/addons/account @dirrm %%PYTHON_SITELIBDIR%%/tinyerp-server/addons @dirrm %%PYTHON_SITELIBDIR%%/tinyerp-server -@dirrmtry %%PYTHON_SITELIBDIR%% -@dirrmtry lib/python2.4 diff -urN misc/tinyerp.orig/tinyerp-port misc/tinyerp/tinyerp-port --- misc/tinyerp.orig/tinyerp-port Wed Mar 1 22:39:37 2006 +++ misc/tinyerp/tinyerp-port Thu Jan 1 01:00:00 1970 @@ -1,55 +0,0 @@ -# This is a shell archive. Save it in a file, remove anything before -# this line, and then unpack it by entering "sh file". Note, it may -# create directories; files and directories will be owned by you and -# have default permissions. -# -# This archive contains: -# -# /usr/ports/misc/tinyerp/ -# /usr/ports/misc/tinyerp/Makefile -# /usr/ports/misc/tinyerp/tinyerp-port -# /usr/ports/misc/tinyerp/pkg-descr -# /usr/ports/misc/tinyerp/distinfo -# /usr/ports/misc/tinyerp/pkg-plist -# -echo c - /usr/ports/misc/tinyerp/ -mkdir -p /usr/ports/misc/tinyerp/ > /dev/null 2>&1 -echo x - /usr/ports/misc/tinyerp/Makefile -sed 's/^X//' >/usr/ports/misc/tinyerp/Makefile << 'END-of-/usr/ports/misc/tinyerp/Makefile' -X# New ports collection makefile for: tinyerp -X# Date created: 22 February 2006 -X# Whom: Jordi Haarman -X# -X# $FreeBSD$ -X# -X -XPORTNAME= tinyerp-server -XPORTVERSION= 3.2.1 -XCATEGORIES= python -XMASTER_SITES= http://tinyerp.org/download/sources/ -XDISTNAME= ${PORTNAME}-${PORTVERSION} -XEXTRACT_SUFX= .tgz -X -XMAINTAINER= jhaarman-keyword-tinyerpPort.fd583c@projects.synantics.net -XCOMMENT= Open source application ERP & CRM in Python using Postgresql -X -XBUILD_DEPENDS= postgres:${PORTSDIR}/databases/postgresql81-server -X ${PYTHON_SITELIBDIR}/PIL/__init__.py:${PORTSDIR}/graphics/py-imaging -X ${PYTHON_SITELIBDIR}/libxml2.py:${PORTSDIR}/textproc/py-libxml2 -X ${PYTHON_SITELIBDIR}/libxslt.py:${PORTSDIR}/textproc/py-libxslt -X ${PYTHON_SITELIBDIR}/mx/__init__.py:${PORTSDIR}/lang/py-mx-base -X ${PYTHON_SITELIBDIR}/pyparsing.py:${PORTSDIR}/devel/py-parsing -X ${PYTHON_SITELIBDIR}/psycopgmodule.so:${PORTSDIR}/databases/py-psycopg -X ${PYTHON_SITELIBDIR}/reportlab/__init__.py:${PORTSDIR}/print/py-reportlab -X -XRUN_DEPENDS= ${BUILD_DEPENDS} -X -XWRKSRC= ${WRKDIR}/server -X -XUSE_PYTHON= 2.4+ -XUSE_PYDISTUTILS=yes -X -X.include <bsd.port.mk> -END-of-/usr/ports/misc/tinyerp/Makefile -echo x - /usr/ports/misc/tinyerp/tinyerp-port -sed 's/^X//' >/usr/ports/misc/tinyerp/tinyerp-port << 'END-of-/usr/ports/misc/tinyerp/tinyerp-port' --- tinyerp.diff ends here ---
Responsible Changed From-To: freebsd-ports-bugs->thierry Take it.
On Sat 11 mar 06 at 9:46:00 +0100, Jordi Haarman <j.haarman@synantics.com> wrote: > Sorry for the late response. Below the answers and some questions also ;-) > > What should I do next? Just answer to this mail, with your new shar file attached (I have set Reply-To: to FreeBSD-gnats-submit, thus your mail will be treated as a follow-up to the PR). > (is my first port that I actually submitted ;-) ) Welcome! > >Thanks for your PR. I have several remarks or questions: > > > >- CATEGORIES: python is not a main category. I have set misc, but > > finance might be better. > finance sounds fine (even better ;-) ) > > >- You don't need to depend on postgresql81-server, the database server > > could run on another machine, but a client is necessary (it is > > implied by the dependency towards databases/py-psycopg). > ok > > >- A dependency towards graphics/graphviz should be added. > I did not see > > >- Please try to install the docs under ${DOCSDIR} and use the macros > > %%PORTDOCS%% and %%DOCSDIR%%. > Where can I find more info on how to do that? This is described in the "Porter's Handbook": <http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-documentation.html> You'll have to patch in order to remove the version string (this is cleaner, but not mandatory). > >- Do you plan to port the client? > Nope: I don't have a FreeBSD desktop at the moment (still to much > trouble to get Flash and Java going). Further I have some other ports I > have to make first TinyERP is a very interesting port, but without the client part, it is mostly unuseful on FreeBSD... > >- Several fixes to pet portlint and fix man page installation. > ok > > >Could you please check the following patch? > it seems to work. Only since you removed the line: > -@exec mkdir -p %D/share/doc/tinyerp-server-3.2.0/i18n > it now complains that it can't remove that. Suppose that: > @dirrm share/doc/tinyerp-server-3.2.0/i18n > also has to go then. OK, to be fixed with ${DOCSDIR}. Best regards, -- Th. Thomas.
OK. next version. -- Groet, Jordi http://synantics.nl http://startu.net - esperanto startpagina Thierry Thomas wrote: > On Sat 11 mar 06 at 9:46:00 +0100, Jordi Haarman <j.haarman@synantics.com> > wrote: >> Sorry for the late response. Below the answers and some questions also ;-) >> >> What should I do next? > > Just answer to this mail, with your new shar file attached (I have set > Reply-To: to FreeBSD-gnats-submit, thus your mail will be treated as a > follow-up to the PR). > >> (is my first port that I actually submitted ;-) ) > > Welcome! > >>> Thanks for your PR. I have several remarks or questions: >>> >>> - CATEGORIES: python is not a main category. I have set misc, but >>> finance might be better. >> finance sounds fine (even better ;-) ) >> >>> - You don't need to depend on postgresql81-server, the database server >>> could run on another machine, but a client is necessary (it is >>> implied by the dependency towards databases/py-psycopg). >> ok >> >>> - A dependency towards graphics/graphviz should be added. >> I did not see >> >>> - Please try to install the docs under ${DOCSDIR} and use the macros >>> %%PORTDOCS%% and %%DOCSDIR%%. >> Where can I find more info on how to do that? > > This is described in the "Porter's Handbook": > <http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-documentation.html> > > You'll have to patch in order to remove the version string (this is > cleaner, but not mandatory). > >>> - Do you plan to port the client? >> Nope: I don't have a FreeBSD desktop at the moment (still to much >> trouble to get Flash and Java going). Further I have some other ports I >> have to make first > > TinyERP is a very interesting port, but without the client part, it is > mostly unuseful on FreeBSD... > >>> - Several fixes to pet portlint and fix man page installation. >> ok >> >>> Could you please check the following patch? >> it seems to work. Only since you removed the line: >> -@exec mkdir -p %D/share/doc/tinyerp-server-3.2.0/i18n >> it now complains that it can't remove that. Suppose that: >> @dirrm share/doc/tinyerp-server-3.2.0/i18n >> also has to go then. > > OK, to be fixed with ${DOCSDIR}. > > Best regards,
State Changed From-To: feedback->closed New ports added, thanks! Don't forget to port the client side when you'll find some time ;-)