Bug 9616 - New port: math/abs
Summary: New port: math/abs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 1999-01-22 08:40 UTC by Gianmarco Giovannelli
Modified: 1999-01-26 03:43 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gianmarco Giovannelli 1999-01-22 08:40:00 UTC
	Abs is a free spreadsheet with graphical user interface.
	It has a programming language with the same 
	syntax as Microsoft Visual Basic. 

	http://www.ping.be/bertin/abs.shtml

Fix: 

Best Regards,
Gianmarco Giovannelli (http://www.giovannelli.it/~gmarco)
"Unix expert since yesterday"--9xdVmaRPCaXESU0WpD5UftpuYMOQhpdOblywXRydAqBqR1C9
Content-Type: text/plain; name="file.shar"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.shar"

# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#       abs
#       abs/files
#       abs/files/md5
#       abs/pkg
#       abs/pkg/COMMENT
#       abs/pkg/DESCR
#       abs/pkg/PLIST
#       abs/patches
#       abs/patches/patch-aa
#       abs/patches/patch-ab
#       abs/patches/patch-ac
#       abs/Makefile
#
echo c - abs
mkdir -p abs > /dev/null 2>&1
echo c - abs/files
mkdir -p abs/files > /dev/null 2>&1
echo x - abs/files/md5
sed 's/^X//' >abs/files/md5 << 'END-of-abs/files/md5'
XMD5 (abs-src-0.5.tar.gz) = ee3f6312009d76bac8fdb73c978511e8
END-of-abs/files/md5
echo c - abs/pkg
mkdir -p abs/pkg > /dev/null 2>&1
echo x - abs/pkg/COMMENT
sed 's/^X//' >abs/pkg/COMMENT << 'END-of-abs/pkg/COMMENT'
Xa free spreadsheet with graphical user interface
END-of-abs/pkg/COMMENT
echo x - abs/pkg/DESCR
sed 's/^X//' >abs/pkg/DESCR << 'END-of-abs/pkg/DESCR'
XAbs is a free spreadsheet with graphical user interface.
XIt has a programming language with the same 
Xsyntax as Microsoft Visual Basic. 
X
Xhttp://www.ping.be/bertin/abs.shtml
X
X- Gianmarco
Xgmarco@giovannelli.it
END-of-abs/pkg/DESCR
echo x - abs/pkg/PLIST
sed 's/^X//' >abs/pkg/PLIST << 'END-of-abs/pkg/PLIST'
Xbin/abs
END-of-abs/pkg/PLIST
echo c - abs/patches
mkdir -p abs/patches > /dev/null 2>&1
echo x - abs/patches/patch-aa
sed 's/^X//' >abs/patches/patch-aa << 'END-of-abs/patches/patch-aa'
X--- Makefile.orig      Fri Jan 22 00:04:47 1999
X+++ Makefile   Fri Jan 22 00:11:01 1999
X@@ -4,6 +4,10 @@
X 
X MAKE =        make
X 
X+CFLAGS = -I$(X11BASE)/include
X+
X+CC ?= cc
X+
X LIBS = -L /lib/X11 -L /usr/X11R6/lib -lXaw -lX11 -lm -lXt -lXmu -lXext 
X 
X SRCS  =       \
X@@ -105,7 +109,7 @@
X       $(MAKE) all); \
X       fi \
X       done
X-      cc -o abs ./TextField-1.0/*.o $(OBJS) ./Xpm/libxpm.a $(LIBS) 
X+      $(CC) $(CFLAGS) -o abs ./TextField-1.0/*.o $(OBJS) ./Xpm/libxpm.a
$(LIBS)
X 
X clean::
X       rm -f *.o */*.o */*.a
END-of-abs/patches/patch-aa
echo x - abs/patches/patch-ab
sed 's/^X//' >abs/patches/patch-ab << 'END-of-abs/patches/patch-ab'
X--- Xpm/Makefile.orig  Fri Jan 22 00:12:39 1999
X+++ Xpm/Makefile       Fri Jan 22 00:15:57 1999
X@@ -16,7 +16,7 @@
X #################################
X ### C Compiler
X CC            = cc 
X-CFLAGS                =  -O
X+CFLAGS                +=  -O -I$(X11BASE)/include
X 
X ### C++ Compiler
X CCC           = xlC 
END-of-abs/patches/patch-ab
echo x - abs/patches/patch-ac
sed 's/^X//' >abs/patches/patch-ac << 'END-of-abs/patches/patch-ac'
X--- TextField-1.0/Makefile.orig        Fri Jan 22 00:16:23 1999
X+++ TextField-1.0/Makefile     Fri Jan 22 00:19:15 1999
X@@ -3,7 +3,7 @@
X ATHENALIBS = -lXaw -lXmu -lXt -lX11 -lm
X CFLAGS = $(DEFINES) $(CDEBUGFLAGS)
X CDEBUGFLAGS =
X-DEFINES =
X+DEFINES += -I$(X11BASE)/include
X RM = rm -f
X 
X WIDGET = TextField
END-of-abs/patches/patch-ac
echo x - abs/Makefile
sed 's/^X//' >abs/Makefile << 'END-of-abs/Makefile'
X# New ports collection makefile for:   abs
X# Version required:    0.5
X# Date created:        20 January 1999
X# Whom:                gmarco
X#
X# $Id$
X#
X
XDISTNAME=  abs-src-0.5
XPKGNAME=   abs-0.5
XCATEGORIES=    math
XMASTER_SITES=  http://www.ping.be/bertin/
X
XMAINTAINER=    freebsd@scotty.masternet.it
X
Xdo-install:
X
X       ${INSTALL_PROGRAM} ${WRKSRC}/abs ${PREFIX}/bin
X
X.include <bsd.port.mk>
END-of-abs/Makefile
exit
Comment 1 onemo 1999-01-22 22:59:22 UTC
*Potential commiters*

I decided to play with this one, it compiled/installed with the
following changes - for one reason or another the patches needed tabs
for white space rather then spaces.

portlint also passes without problems although make uninstall doesn't
work.

MO!


diff -ruN abs.orig/Makefile abs/Makefile
--- abs.orig/Makefile   Fri Jan 22 14:48:38 1999
+++ abs/Makefile        Fri Jan 22 13:49:13 1999
@@ -15,6 +15,6 @@

 do-install:

-       ${INSTALL_PROGRAM} ${WRKSRC}/abs ${PREFIX}/bin
+       @ ${INSTALL_PROGRAM} ${WRKSRC}/abs ${PREFIX}/bin

 .include <bsd.port.mk>
diff -ruN abs.orig/patches/patch-aa abs/patches/patch-aa
--- abs.orig/patches/patch-aa   Fri Jan 22 14:48:38 1999
+++ abs/patches/patch-aa        Fri Jan 22 14:25:44 1999
@@ -1,8 +1,8 @@
---- Makefile.orig      Fri Jan 22 00:04:47 1999
-+++ Makefile   Fri Jan 22 00:11:01 1999
+--- Makefile.orig      Fri Jan 22 00:04:47 1999
++++ Makefile   Fri Jan 22 00:11:01 1999
 @@ -4,6 +4,10 @@

- MAKE =        make
+ MAKE =        make

 +CFLAGS = -I$(X11BASE)/include
 +
@@ -10,14 +10,13 @@
 +
  LIBS = -L /lib/X11 -L /usr/X11R6/lib -lXaw -lX11 -lm -lXt -lXmu -lXext


- SRCS  =       \
+ SRCS  =       \
 @@ -105,7 +109,7 @@
-       $(MAKE) all); \
-       fi \
-       done
--      cc -o abs ./TextField-1.0/*.o $(OBJS) ./Xpm/libxpm.a $(LIBS)
-+      $(CC) $(CFLAGS) -o abs ./TextField-1.0/*.o $(OBJS)
./Xpm/libxpm.a
-$(LIBS)
+       $(MAKE) all); \
+       fi \
+       done
+-      cc -o abs ./TextField-1.0/*.o $(OBJS) ./Xpm/libxpm.a $(LIBS)
++      $(CC) $(CFLAGS) -o abs ./TextField-1.0/*.o $(OBJS)
./Xpm/libxpm.a $(LIBS)

  clean::
-       rm -f *.o */*.o */*.a
+       rm -f *.o */*.o */*.a
diff -ruN abs.orig/patches/patch-ab abs/patches/patch-ab
--- abs.orig/patches/patch-ab   Fri Jan 22 14:48:38 1999
+++ abs/patches/patch-ab        Fri Jan 22 14:29:45 1999
@@ -3,9 +3,9 @@
 @@ -16,7 +16,7 @@
  #################################
  ### C Compiler
- CC            = cc
--CFLAGS                =  -O
-+CFLAGS                +=  -O -I$(X11BASE)/include
+ CC            = cc
+-CFLAGS                =  -O
++CFLAGS                +=  -O -I$(X11BASE)/include

  ### C++ Compiler
- CCC           = xlC
+ CCC           = xlC
Comment 2 Gianmarco Giovannelli 1999-01-23 00:16:47 UTC
At 14.59 22/01/99 -0800, ONE-MO wrote:
>*Potential commiters*
>
>I decided to play with this one, it compiled/installed with the
>following changes - for one reason or another the patches needed tabs
>for white space rather then spaces.
>
>portlint also passes without problems although make uninstall doesn't
>work.

Here we tried in two person without any problems, can you explain what's is
wrong .. because I tried to make install, package, deinstall etc etc
without any problem at all and it was the first port I made :-)
But we can test it only on 4.0-current ...


Thanks...

Best Regards,
Gianmarco Giovannelli (http://www.giovannelli.it/~gmarco)
"Unix expert since yesterday"
Comment 3 Gianmarco Giovannelli 1999-01-23 00:26:41 UTC
At 14.59 22/01/99 -0800, ONE-MO wrote:
>*Potential commiters*
>
>I decided to play with this one, it compiled/installed with the
>following changes - for one reason or another the patches needed tabs
>for white space rather then spaces.
>
>portlint also passes without problems although make uninstall doesn't
>work.

I tried it again but look :

gmarco:/var/tmp/abs# make install
===>  Extracting for abs-0.5
>> Checksum OK for abs-src-0.5.tar.gz.
===>  Patching for abs-0.5
===>  Applying FreeBSD patches for abs-0.5
===>  Configuring for abs-0.5
===>  Building for abs-0.5
cc -I/usr/X11R6/include -c applic.c
cc -I/usr/X11R6/include -c buildall.c
cc -I/usr/X11R6/include -c buttonbar.c
cc -I/usr/X11R6/include -c callback.c
cc -I/usr/X11R6/include -c cb.c
[...]
Loading libxpm.a ...
done
making all in ./TextField-1.0...
cc -I/usr/X11R6/include  -c TextField.c
cc -I/usr/X11R6/include -o abs ./TextField-1.0/*.o applic.o  buildall.o
buttonbar.o  callback.o  cb.o  cl.o  cldlg.o  commandline.o  cursor.o
date.o  drw.o  fig.o  file_selector.o  gr_interf.o  chrt.o  info_dialog.o
lex.yy.o  macro.o  macrodialog.o  main.o  memory.o  menubar.o  mydialog.o
myscroll.o  newplot.o  operation.o  param.o  pldlg.o  post.o  printdialog.o
 range.o  routine.o  scale.o  selection.o  stack.o  startplug.o  style.o
title.o  toto.o  widget_makerX11.o  wkb.o  wks.o  y.tab.o ./Xpm/libxpm.a -L
/lib/X11 -L /usr/X11R6/lib -lXaw -lX11 -lm -lXt -lXmu -lXext
===>  Installing for abs-0.5
install -c -s -o root -g wheel -m 555 /var/tmp/abs/work/abs-src-0.5/abs
/usr/local/bin
===>   Generating temporary packing list
===>   Registering installation for abs-0.5
gmarco:/var/tmp/abs# make deinstall
===>  Deinstalling for abs-0.5
gmarco:/var/tmp/abs# 

using the original port ...

Thanks again for attention...
But please let me know...



Best Regards,
Gianmarco Giovannelli (http://www.giovannelli.it/~gmarco)
"Unix expert since yesterday"
Comment 4 onemo 1999-01-23 04:50:29 UTC
Gianmarco Giovannelli wrote:

> At 14.59 22/01/99 -0800, ONE-MO wrote:
> >*Potential commiters*
> >
> >I decided to play with this one, it compiled/installed with the
> >following changes - for one reason or another the patches needed tabs
> >for white space rather then spaces.
> >
> >portlint also passes without problems although make uninstall doesn't
> >work.
>
> Here we tried in two person without any problems, can you explain what's is
> wrong .. because I tried to make install, package, deinstall etc etc
> without any problem at all and it was the first port I made :-)
> But we can test it only on 4.0-current ...
>
> Thanks...
>
> Best Regards,
> Gianmarco Giovannelli (http://www.giovannelli.it/~gmarco)
> "Unix expert since yesterday"

OK, here's what I get:

With everything as originally submitted -

mars:/usr/ports/math/abs# make install
"Makefile", line 18: Need an operator
make: fatal errors encountered -- cannot continue

After adding an '@' to the top-level Makefile as follows:

...
do-install:

        @ ${INSTALL_PROGRAM} ${WRKSRC}/abs ${PREFIX}/bin
...

mars:/usr/ports/math/abs# make install
===>  Extracting for abs-0.5
>> Checksum OK for abs-src-0.5.tar.gz.
===>  Patching for abs-0.5
===>  Applying FreeBSD patches for abs-0.5
patch: **** malformed patch at line 20: $(LIBS)
*** Error code 1

Stop.
*** Error code 1

Stop.
*** Error code 1

Stop.
*** Error code 1

Stop.
*** Error code 1

Stop.

This I've tried with Patch v2.1 and v2.5, and bash, sh, ksh, and csh. Until I
changed the whitespace in the patches to tabs, I couldn't get the patches to
apply. What I had done earlier was manually modify the sources based on your
patches and then run a diff -ruN against my changes. When I diff'd my patches
against your patches, the only difference was that the source and I used tabs
and your patches used spaces (perhaps due to Netscape's File Save function if
you originally used tabs).

I'm no expert on ports either - that's why I decided to test other's
submissions and do some minor updating (I did the initial update of
WindowMaker to 0.50.x and submitted my diffs to the maintainer).

Just trying to help, if it turns out I've got something weird happening on my
end - I hope to find out now before I actually 'do' start porting things on my
own... ;-)

Michael (MO!)
Comment 5 Steve Price freebsd_committer freebsd_triage 1999-01-26 03:43:13 UTC
State Changed
From-To: open->closed

New port committed, thanks!