Bug 97790 - [maintainer update] net-im/gloox: BROKEN on 4.x
Summary: [maintainer update] net-im/gloox: BROKEN on 4.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Roman Bogorodskiy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-24 16:40 UTC by trasz
Modified: 2006-05-31 06:00 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description trasz 2006-05-24 16:40:13 UTC 
According to http://people.freebsd.org/~fenner/errorlogs/trasz@pin.if.uz.zgora.pl.html, gloox fails to build
on FreeBSD 4.  I'm not sure if the patch attached is correct (don't have any FreeBSD 4 machine) or optimal
(it seems to be a compiler problem, not a problem with operating system itself), but i hope it will do ;-)

--- Makefile.orig       Sun May 21 11:27:29 2006
+++ Makefile    Sun May 21 11:46:12 2006
@@ -24,10 +24,16 @@
                LDFLAGS="-L${LOCALBASE}/lib"
 INSTALLS_SHLIB=        yes
 
+.include <bsd.port.pre.mk>
+
+.if (${OSVERSION} < 500000)
+BROKEN= Does not build on FreeBSD < 5.x.
+.endif
+
 post-install:
        @${FIND} ${PREFIX}/include/gloox ! -type d | \
                ${SED} "s,${PREFIX}/,," >> ${TMPPLIST}
        @${FIND} ${PREFIX}/include/gloox -type d | ${SORT} -r | \
                ${SED} "s,${PREFIX}/,@dirrm ," >> ${TMPPLIST}
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
Comment 1 Roman Bogorodskiy freebsd_committer freebsd_triage 2006-05-31 05:50:20 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->novel

I will take it.
Comment 2 Roman Bogorodskiy freebsd_committer freebsd_triage 2006-05-31 05:59:14 UTC 
State Changed
From-To: open->closed

Committed, thanks! 

BTW, patches are supposed to be in a "Fix" section, not in 
"Description".