+    '-Wno-unused-parameter',

@@ -889,9 +881,7 @@ env.AppendUnique(CXXFLAGS = [

     '-Wwrite-strings',

     '-Wcast-qual',

     '-Wpointer-arith',

-    '-Wcast-align',

     '-Woverloaded-virtual',

-    '-ftemplate-depth-25',

     '-pipe',

     ])

--- cli/libtecla/cplfile.c.orig	2018-07-11 16:49:26 UTC

+++ cli/libtecla/cplfile.c

@@ -314,7 +314,7 @@ int _cf_complete_file(WordCompletion *cp

  * might be the start of the last component, and mark the character

  * that follows it as the start of the name that is to be completed.

  */

-      if(nleft >= FS_DIR_SEP_LEN &&

+      if((unsigned long)(nleft) >= FS_DIR_SEP_LEN &&

 	 strncmp(lptr + seglen, FS_DIR_SEP, FS_DIR_SEP_LEN)==0) {

 	word_start = (lptr + seglen) - line + FS_DIR_SEP_LEN;

       };

@@ -394,12 +394,12 @@ int _cf_complete_file(WordCompletion *cp

 /*

  * Prevent extra directory separators from being added.

  */

-	if(nleft >= FS_DIR_SEP_LEN &&

+	if((unsigned long)(nleft) >= FS_DIR_SEP_LEN &&

 	   strcmp(cf->path->name, FS_ROOT_DIR) == 0 &&

 	   strncmp(lptr, FS_DIR_SEP, FS_DIR_SEP_LEN) == 0) {

 	  lptr += FS_DIR_SEP_LEN;

 	  nleft -= FS_DIR_SEP_LEN;

-	} else if(vlen > FS_DIR_SEP_LEN &&

+	} else if((unsigned long)(vlen) > FS_DIR_SEP_LEN &&

 		  strcmp(value + vlen - FS_DIR_SEP_LEN, FS_DIR_SEP)==0) {

 	  cf->path->name[vlen-FS_DIR_SEP_LEN] = '\0';

 	};

@@ -781,7 +781,7 @@ static char *cf_read_name(CompleteFile *

  * Get the environment variable name that follows the dollar.

  */

   for(sptr=string,namlen=0;

-      namlen < nmax && (slen-namlen < FS_DIR_SEP_LEN ||

+      namlen < nmax && ((unsigned long)(slen-namlen) < FS_DIR_SEP_LEN ||

 			strncmp(sptr, FS_DIR_SEP, FS_DIR_SEP_LEN) != 0);

       namlen++) {

     nambuf[namlen] = *sptr++;

--- cli/libtecla/expand.c.orig	2018-07-11 16:57:16 UTC

+++ cli/libtecla/expand.c

@@ -322,7 +322,7 @@ FileExpansion *ef_expand_file(ExpandFile

  * If the caller specified that the whole of path[] be matched,

  * work out the corresponding length.

  */

-  if(pathlen < 0 || pathlen > strlen(path))

+  if(pathlen < 0 || (unsigned long)(pathlen) > strlen(path))

     pathlen = strlen(path);

 /*

  * Discard previous expansion results.

--- cli/libtecla/getline.c.orig	2018-07-11 18:33:06 UTC

+++ cli/libtecla/getline.c

@@ -2180,7 +2180,7 @@ static int gl_add_char_to_line(GetLine *

  * If not, simply return, leaving it up to the calling program

  * to check for the absence of a newline character.

  */

-  if((gl->insert || buff_curpos >= gl->ntotal) && gl->ntotal >= gl->linelen)

+  if((gl->insert || buff_curpos >= gl->ntotal) && (unsigned long)(gl->ntotal) >= gl->linelen)

     return 0;

 /*

  * Are we adding characters to the line (ie. inserting or appending)?

@@ -2310,7 +2310,7 @@ static int gl_add_string_to_line(GetLine

  * If not, simply return, leaving it up to the calling program

  * to check for the absence of a newline character.

  */

-  if(gl->ntotal + buff_slen > gl->linelen)

+  if((unsigned long)((gl->ntotal + buff_slen)) > gl->linelen)

     return 0;

 /*

  * Move the characters that follow the cursor in the buffer by

@@ -4581,7 +4581,7 @@ static KT_KEY_FN(gl_complete_word)

 /*

  * Will there be space for the expansion in the line buffer?

  */

-      if(gl->ntotal + nextra < gl->linelen) {

+      if((unsigned long)((gl->ntotal + nextra)) < gl->linelen) {

 /*

  * Make room to insert the filename extension.

  */

@@ -4726,7 +4726,7 @@ static KT_KEY_FN(gl_expand_filename)

 /*

  * Will there be space for the expansion in the line buffer?

  */

-  if(gl->ntotal + nextra >= gl->linelen) {

+  if((unsigned long)((gl->ntotal + nextra)) >= gl->linelen) {

     fprintf(stderr, "\r\nInsufficient room in line for file expansion.\r\n");

     redisplay = 1;

   } else {

@@ -7104,7 +7104,7 @@ static int gl_interpret_char(GetLine *gl

  * input line buffer, and watch for the end of the line.

  */

   if(gl->editor == GL_NO_EDITOR) {

-    if(gl->ntotal >= gl->linelen) {

+    if((unsigned long)(gl->ntotal) >= gl->linelen) {

       ret = 0;

       goto ret_label;

     }

@@ -7813,7 +7813,7 @@ int gl_group_history(GetLine *gl, unsign

 /*

  * If the group isn't being changed, do nothing.

  */

-  if(_glh_get_group(gl->glh) == id)

+  if((unsigned int)((_glh_get_group(gl->glh))) == id)

     return 0;

 /*

  * Establish the new group.

--- cli/libtecla/history.c.orig	2018-07-11 18:08:59 UTC

+++ cli/libtecla/history.c

@@ -253,7 +253,7 @@ int _glh_add_history(GlHistory *glh, con

 /*

  * If the line is too big to fit in the buffer, truncate it.

  */

-  if(nchar > glh->buflen)

+  if((unsigned long)(nchar) > glh->buflen)

     nchar = glh->buflen;

 /*

  * Is the line empty?

@@ -272,7 +272,7 @@ int _glh_add_history(GlHistory *glh, con

  * don't add it again, unless explicitly told to.

  */

   if(!force &&

-     list->tail && strlen(glh->buffer + list->tail->start) == nchar-1 &&

+     list->tail && strlen(glh->buffer + list->tail->start) == (unsigned long)((nchar-1)) &&

      strncmp(line, glh->buffer + list->tail->start, nchar-1)==0)

     return 0;

 /*

@@ -311,7 +311,7 @@ int _glh_add_history(GlHistory *glh, con

  * at the end of the buffer, then shift the remaining contents

  * of the buffer to the end of the buffer.

  */

-    if(start + nchar >= glh->buflen) {

+    if(start + (unsigned long)(nchar) >= glh->buflen) {

       GlLineNode *last; /* The last line in the buffer */

       GlLineNode *ln;   /* A member of the list of line locations */

       int shift;        /* The shift needed to move the contents of the */

@@ -1897,15 +1897,15 @@ static GlLineNode *_glh_find_id(GlHistor

 /*

  * Search forwards from 'node'?

  */

-  if(node->id < id) {

-    while(node && node->id != id)

+  if((unsigned long)(node->id) < id) {

+    while(node && (unsigned long)(node->id) != id)

       node = node->next;

     glh->id_node = node ? node : glh->list.tail;

 /*

  * Search backwards from 'node'?

  */

   } else {

-    while(node && node->id != id)

+    while(node && (unsigned long)(node->id) != id)

       node = node->prev;

     glh->id_node = node ? node : glh->list.head;

   };

--- cli/libtecla/homedir.c.orig	2018-07-11 18:41:32 UTC

+++ cli/libtecla/homedir.c

@@ -146,7 +146,7 @@ HomeDir *_new_HomeDir(void)

  * a pathname, increase its length.

  */

   pathlen = _pu_pathname_dim();

-  if(pathlen > home->buflen)

+  if(pathlen > (unsigned long)(home->buflen))

     home->buflen = pathlen;

 /*

  * Allocate a work buffer.

--- fea/data_plane/io/io_ip_socket.cc.orig	2018-07-10 15:49:50 UTC

+++ fea/data_plane/io/io_ip_socket.cc

@@ -2293,10 +2293,10 @@ IoIpSocket::send_packet(const string& if

 	    //

 	    struct sockaddr_in sin;

 	    src_address.copy_out(sin);

-	    if (bind(_proto_socket_out,

+	    bind(_proto_socket_out,

 		     reinterpret_cast<struct sockaddr*>(&sin),

-		     sizeof(sin))

-		< 0) {

+		     sizeof(sin));

+		if ( reinterpret_cast<struct sockaddr*>(&sin) < ((void*)0)) {

 		error_msg = c_format("raw socket bind(%s) failed: %s",

 				     cstring(src_address), XSTRERROR);

 		XLOG_ERROR("%s", error_msg.c_str());

--- policy/backend/lex.yy_policy_backend_parser.cc.orig	2018-07-10 15:46:56 UTC

+++ policy/backend/lex.yy_policy_backend_parser.cc

@@ -728,9 +728,9 @@ extern int yy_policy_backend_parserlex (

  */

 YY_DECL

 {

-	register yy_state_type yy_current_state;

-	register char *yy_cp, *yy_bp;

-	register int yy_act;

+	yy_state_type yy_current_state;

+	char *yy_cp, *yy_bp;

+	int yy_act;

 #line 40 "backend.l"

@@ -779,7 +779,7 @@ YY_DECL

 yy_match:

 		do

 			{

-			register YY_CHAR yy_c = yy_ec[YY_SC_TO_UI(*yy_cp)];

+			YY_CHAR yy_c = yy_ec[YY_SC_TO_UI(*yy_cp)];

 			if ( yy_accept[yy_current_state] )

 				{

 				(yy_last_accepting_state) = yy_current_state;

@@ -1171,9 +1171,9 @@ case YY_STATE_EOF(STR):

  */

 static int yy_get_next_buffer (void)

 {

-    	register char *dest = YY_CURRENT_BUFFER_LVALUE->yy_ch_buf;

-	register char *source = (yytext_ptr);

-	register int number_to_move, i;

+    	char *dest = YY_CURRENT_BUFFER_LVALUE->yy_ch_buf;

+	char *source = (yytext_ptr);

+	int number_to_move, i;

 	int ret_val;

 	if ( (yy_c_buf_p) > &YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[(yy_n_chars) + 1] )

@@ -1297,14 +1297,14 @@ static int yy_get_next_buffer (void)

     static yy_state_type yy_get_previous_state (void)

 {

-	register yy_state_type yy_current_state;

-	register char *yy_cp;

+	yy_state_type yy_current_state;

+	char *yy_cp;

 	yy_current_state = (yy_start);

 	for ( yy_cp = (yytext_ptr) + YY_MORE_ADJ; yy_cp < (yy_c_buf_p); ++yy_cp )

 		{

-		register YY_CHAR yy_c = (*yy_cp ? yy_ec[YY_SC_TO_UI(*yy_cp)] : 1);

+		YY_CHAR yy_c = (*yy_cp ? yy_ec[YY_SC_TO_UI(*yy_cp)] : 1);

 		if ( yy_accept[yy_current_state] )

 			{

 			(yy_last_accepting_state) = yy_current_state;

@@ -1329,10 +1329,10 @@ static int yy_get_next_buffer (void)

  */

     static yy_state_type yy_try_NUL_trans  (yy_state_type yy_current_state )

 {

-	register int yy_is_jam;

-    	register char *yy_cp = (yy_c_buf_p);

+	int yy_is_jam;

+    	char *yy_cp = (yy_c_buf_p);

-	register YY_CHAR yy_c = 1;

+	YY_CHAR yy_c = 1;

 	if ( yy_accept[yy_current_state] )

 		{

 		(yy_last_accepting_state) = yy_current_state;

@@ -1933,7 +1933,7 @@ int yy_policy_backend_parserlex_destroy 

 #ifndef yytext_ptr

 static void yy_flex_strncpy (char* s1, yyconst char * s2, int n )

 {

-	register int i;

+	int i;

 	for ( i = 0; i < n; ++i )

 		s1[i] = s2[i];

 }

@@ -1942,7 +1942,7 @@ static void yy_flex_strncpy (char* s1, y

 #ifdef YY_NEED_STRLEN

 static int yy_flex_strlen (yyconst char * s )

 {

-	register int n;

+	int n;

 	for ( n = 0; s[n]; ++n )

 		;

@@ -88,8 +88,8 @@ IpHeader4::fragment(size_t mtu, list<vec

     //

     memcpy(&frag_buf[0], _data, IpHeader4::SIZE);

     {

-	register const u_char *cp;

-	register u_char *dp;

+	const u_char *cp;

+	u_char *dp;

 	int opt, optlen, cnt;

 	cp = (const u_char *)(orig_ip4.data() + orig_ip4.size());

--- cli/libtecla/pathutil.c.orig	2018-07-10 13:09:21 UTC

+++ cli/libtecla/pathutil.c

@@ -168,7 +168,7 @@ char *_pn_append_to_path(PathName *path,

 /*

  * How many characters should be appended?

  */

-  if(slen < 0 || slen > strlen(string))

+  if(slen < 0 || (unsigned long)(slen) > strlen(string))

     slen = strlen(string);

 /*

  * Resize the pathname if needed.

@@ -239,7 +239,7 @@ char *_pn_prepend_to_path(PathName *path

 /*

  * How many characters should be appended?

  */

-  if(slen < 0 || slen > strlen(string))

+  if(slen < 0 || (unsigned long)(slen) > strlen(string))

     slen = strlen(string);

 /*

  * Work out how far we need to shift the original path string to make

@@ -494,7 +494,7 @@ char *_pu_start_of_path(const char *stri

 	break;

     };

   };

-  return (char *)string + i + 1;

+  return (char *)(string + i + 1);

 }

 /*.......................................................................

@@ -534,7 +534,7 @@ char *_pu_end_of_path(const char *string

       escaped = 1;

     };

   };

-  return (char *)string + i;

+  return (char *)(string + i);

 }

 /*.......................................................................

--- cli/libtecla/pcache.c.orig	2018-07-11 18:23:55 UTC

+++ cli/libtecla/pcache.c

@@ -601,7 +601,7 @@ static int pca_extract_dir(PathCache *pc

  */

   {

     int dirlen = strlen(pc->path->name);

-    if(dirlen < FS_DIR_SEP_LEN ||

+    if((unsigned long)(dirlen) < FS_DIR_SEP_LEN ||

        strncmp(pc->path->name + dirlen - FS_DIR_SEP_LEN, FS_DIR_SEP,

 	       FS_DIR_SEP_LEN) != 0) {

       if(_pn_append_to_path(pc->path, FS_DIR_SEP, FS_DIR_SEP_LEN, 0) == NULL) {

@@ -1500,7 +1500,7 @@ static int cpa_cmd_contains_path(const c

  * If the filename starts with the root directory, then it obviously

  * starts with a pathname.

  */

-  if(prefix_len >= FS_ROOT_DIR_LEN && 

+  if((unsigned long)(prefix_len) >= FS_ROOT_DIR_LEN && 

      strncmp(prefix, FS_ROOT_DIR, FS_ROOT_DIR_LEN) == 0)

     return 1;

 /*

@@ -1509,7 +1509,7 @@ static int cpa_cmd_contains_path(const c

  * starts with a pathname specification (valid or otherwise).

  */

   for(i=0; i<prefix_len; i++) {

-    if(prefix_len - i >= FS_DIR_SEP_LEN &&

+    if((unsigned long)((prefix_len - i)) >= FS_DIR_SEP_LEN &&

        strncmp(prefix + i, FS_DIR_SEP, FS_DIR_SEP_LEN) == 0)

       return 1;

   };

@@ -1653,7 +1653,7 @@ static int pca_expand_tilde(PathCache *p

  * skip over it so that it doesn't get copied into the output pathname

  */

   if(homedir && strcmp(homedir, FS_ROOT_DIR) == 0 &&

-     (pptr-path) + FS_DIR_SEP_LEN < pathlen &&

+     (pptr-path) + FS_DIR_SEP_LEN < (unsigned long)(pathlen) &&

      strncmp(pptr, FS_DIR_SEP, FS_DIR_SEP_LEN) == 0) {

     pptr += FS_DIR_SEP_LEN;

   };

--- libxorp/popen.cc.orig	2018-07-10 12:54:42 UTC

+++ libxorp/popen.cc

@@ -424,7 +424,7 @@ popen2(const string& command, const list

 int

 pclose2(FILE *iop_out, bool dont_wait)

 {

-    register struct pid_s *cur, *last;

+    struct pid_s *cur, *last;

     int pstat = 0;

     pid_t pid = 0;

--- libxorp/strptime.c.orig	2018-07-10 12:54:53 UTC

+++ libxorp/strptime.c

@@ -85,10 +85,10 @@

 #define TM_YEAR_BASE 1900

 #endif

-static inline void *

+static inline const char *

 UNCONST(const void *a)

 {

-	return ((const char *)a - (const char *)0) + (char *)0;

+	return ((const char *)a - sizeof((const char *)0)) + sizeof((char *)0);

 }