Removed
Link Here
|
1 |
--- ./src/rdist.c.ORI 2012-06-12 07:35:16.000000000 +0200 |
2 |
+++ ./src/rdist.c 2012-06-12 07:49:18.000000000 +0200 |
3 |
@@ -62,8 +62,8 @@ |
4 |
char *distfile = NULL; /* Name of distfile to use */ |
5 |
int maxchildren = MAXCHILDREN; /* Max no of concurrent PIDs */ |
6 |
int nflag = 0; /* Say without doing */ |
7 |
-long min_freespace = 0; /* Min filesys free space */ |
8 |
-long min_freefiles = 0; /* Min filesys free # files */ |
9 |
+int64_t min_freespace = 0; /* Min filesys free space */ |
10 |
+int64_t min_freefiles = 0; /* Min filesys free # files */ |
11 |
FILE *fin = NULL; /* Input file pointer */ |
12 |
struct group *gr = NULL; /* Static area for getgrent */ |
13 |
char localmsglist[] = "stdout=all:notify=all:syslog=nerror,ferror"; |
14 |
@@ -109,6 +109,7 @@ |
15 |
register char *cp; |
16 |
int cmdargs = 0; |
17 |
int c; |
18 |
+ const char *errstr; |
19 |
|
20 |
/* |
21 |
* We initialize progname here instead of init() because |
22 |
@@ -178,10 +179,20 @@ |
23 |
error("\"%s\" is not a number.", optarg); |
24 |
usage(); |
25 |
} |
26 |
- if (c == 'a') |
27 |
- min_freespace = atoi(optarg); |
28 |
- else if (c == 'A') |
29 |
- min_freefiles = atoi(optarg); |
30 |
+ if (c == 'a') { |
31 |
+ min_freespace = (int64_t)strtonum(optarg, |
32 |
+ 0, LLONG_MAX, &errstr); |
33 |
+ if (errstr) |
34 |
+ fatalerr("Minimum free space is %s: " |
35 |
+ "'%s'", errstr, optarg); |
36 |
+ } |
37 |
+ else if (c == 'A') { |
38 |
+ min_freefiles = (int64_t)strtonum(optarg, |
39 |
+ 0, LLONG_MAX, &errstr); |
40 |
+ if (errstr) |
41 |
+ fatalerr("Minimum free files is %s: " |
42 |
+ "'%s'", errstr, optarg); |
43 |
+ } |
44 |
else if (c == 'M') |
45 |
maxchildren = atoi(optarg); |
46 |
else if (c == 't') |
47 |
--- ./src/server.c.ORI 2012-06-12 07:35:16.000000000 +0200 |
48 |
+++ ./src/server.c 2012-06-12 08:14:41.651950502 +0200 |
49 |
@@ -62,8 +62,8 @@ |
50 |
int catname = 0; /* cat name to target name */ |
51 |
char *sptarget[32]; /* stack of saved ptarget's for directories */ |
52 |
char *fromhost = NULL; /* Client hostname */ |
53 |
-static long min_freespace = 0; /* Minimium free space on a filesystem */ |
54 |
-static long min_freefiles = 0; /* Minimium free # files on a filesystem */ |
55 |
+static int64_t min_freespace = 0; /* Minimium free space on a filesystem */ |
56 |
+static int64_t min_freefiles = 0; /* Minimium free # files on a filesystem */ |
57 |
int oumask; /* Old umask */ |
58 |
|
59 |
/* |
60 |
@@ -645,8 +645,8 @@ |
61 |
case S_IFLNK: |
62 |
case S_IFDIR: |
63 |
case S_IFREG: |
64 |
- (void) sendcmd(QC_YES, "%ld %ld %o %s %s", |
65 |
- (long) stb.st_size, |
66 |
+ (void) sendcmd(QC_YES, "%lld %ld %o %s %s", |
67 |
+ (long long) stb.st_size, |
68 |
stb.st_mtime, |
69 |
stb.st_mode & 07777, |
70 |
getusername(stb.st_uid, target, options), |
71 |
@@ -783,13 +783,13 @@ |
72 |
wrerr = 0; |
73 |
olderrno = 0; |
74 |
for (i = 0; i < size; i += BUFSIZ) { |
75 |
- int amt = BUFSIZ; |
76 |
+ off_t amt = BUFSIZ; |
77 |
|
78 |
cp = buf; |
79 |
if (i + amt > size) |
80 |
amt = size - i; |
81 |
do { |
82 |
- int j; |
83 |
+ ssize_t j; |
84 |
|
85 |
j = readrem(cp, amt); |
86 |
if (j <= 0) { |
87 |
@@ -1306,6 +1306,7 @@ |
88 |
{ |
89 |
register char *cp = cmd; |
90 |
char *estr; |
91 |
+ const char *errstr; |
92 |
|
93 |
switch (*cp++) { |
94 |
case SC_HOSTNAME: /* Set hostname */ |
95 |
@@ -1322,19 +1323,15 @@ |
96 |
break; |
97 |
|
98 |
case SC_FREESPACE: /* Minimium free space */ |
99 |
- if (!isdigit(*cp)) { |
100 |
- fatalerr("Expected digit, got '%s'.", cp); |
101 |
- return; |
102 |
- } |
103 |
- min_freespace = (unsigned long) atoi(cp); |
104 |
+ min_freespace = (int64_t)strtonum(cp, 0, LLONG_MAX, &errstr); |
105 |
+ if (errstr) |
106 |
+ fatalerr("Minimum free space is %s: '%s'", errstr, optarg); |
107 |
break; |
108 |
|
109 |
case SC_FREEFILES: /* Minimium free files */ |
110 |
- if (!isdigit(*cp)) { |
111 |
- fatalerr("Expected digit, got '%s'.", cp); |
112 |
- return; |
113 |
- } |
114 |
- min_freefiles = (unsigned long) atoi(cp); |
115 |
+ min_freefiles = (int64_t)strtonum(cp, 0, LLONG_MAX, &errstr); |
116 |
+ if (errstr) |
117 |
+ fatalerr("Minimum free files is %s: '%s'", errstr, optarg); |
118 |
break; |
119 |
|
120 |
case SC_LOGGING: /* Logging options */ |
121 |
@@ -1364,7 +1361,7 @@ |
122 |
time_t mtime, atime; |
123 |
char *owner, *group, *file; |
124 |
char new[MAXPATHLEN]; |
125 |
- long freespace = -1, freefiles = -1; |
126 |
+ int64_t freespace = -1, freefiles = -1; |
127 |
char *cp = cmd; |
128 |
|
129 |
/* |
130 |
@@ -1388,7 +1385,7 @@ |
131 |
/* |
132 |
* Get file size |
133 |
*/ |
134 |
- size = strtol(cp, &cp, 10); |
135 |
+ size = (off_t) strtoll(cp, &cp, 10); |
136 |
if (*cp++ != ' ') { |
137 |
error("recvit: size not delimited"); |
138 |
return; |
139 |
@@ -1397,7 +1394,7 @@ |
140 |
/* |
141 |
* Get modification time |
142 |
*/ |
143 |
- mtime = strtol(cp, &cp, 10); |
144 |
+ mtime = (time_t) strtol(cp, &cp, 10); |
145 |
if (*cp++ != ' ') { |
146 |
error("recvit: mtime not delimited"); |
147 |
return; |
148 |
@@ -1441,8 +1438,8 @@ |
149 |
} |
150 |
|
151 |
debugmsg(DM_MISC, |
152 |
- "recvit: opts = %04o mode = %04o size = %d mtime = %d", |
153 |
- opts, mode, size, mtime); |
154 |
+ "recvit: opts = %04o mode = %04o size = %lld mtime = %d", |
155 |
+ opts, mode, (long long) size, mtime); |
156 |
debugmsg(DM_MISC, |
157 |
"recvit: owner = '%s' group = '%s' file = '%s' catname = %d isdir = %d", |
158 |
owner, group, file, catname, (type == S_IFDIR) ? 1 : 0); |
159 |
@@ -1486,7 +1483,7 @@ |
160 |
*/ |
161 |
if (min_freespace || min_freefiles) { |
162 |
/* Convert file size to kilobytes */ |
163 |
- long fsize = (long) (size / 1024); |
164 |
+ int64_t fsize = (int64_t)size / 1024; |
165 |
|
166 |
if (getfilesysinfo(target, &freespace, &freefiles) != 0) |
167 |
return; |
168 |
@@ -1498,15 +1495,15 @@ |
169 |
if (min_freespace && (freespace >= 0) && |
170 |
(freespace - fsize < min_freespace)) { |
171 |
error( |
172 |
- "%s: Not enough free space on filesystem: min %d free %d", |
173 |
- target, min_freespace, freespace); |
174 |
+ "%s: Not enough free space on filesystem: min %lld " |
175 |
+ "free %lld", target, min_freespace, freespace); |
176 |
return; |
177 |
} |
178 |
if (min_freefiles && (freefiles >= 0) && |
179 |
(freefiles - 1 < min_freefiles)) { |
180 |
error( |
181 |
- "%s: Not enough free files on filesystem: min %d free %d", |
182 |
- target, min_freefiles, freefiles); |
183 |
+ "%s: Not enough free files on filesystem: min %lld free " |
184 |
+ "%lld", target, min_freefiles, freefiles); |
185 |
return; |
186 |
} |
187 |
} |
188 |
--- ./src/docmd.c.ORI 2012-06-12 07:35:16.000000000 +0200 |
189 |
+++ ./src/docmd.c 2012-06-12 08:11:29.000000000 +0200 |
190 |
@@ -102,7 +102,8 @@ |
191 |
register struct namelist *to; |
192 |
time_t lmod; |
193 |
{ |
194 |
- register int fd, len; |
195 |
+ register int fd; |
196 |
+ ssize_t len; |
197 |
FILE *pf, *popen(); |
198 |
struct stat stb; |
199 |
static char buf[BUFSIZ]; |
200 |
@@ -325,7 +326,7 @@ |
201 |
register char *ruser, *cp; |
202 |
static char *cur_host = NULL; |
203 |
extern char *locuser; |
204 |
- extern long min_freefiles, min_freespace; |
205 |
+ extern int64_t min_freefiles, min_freespace; |
206 |
extern char *remotemsglist; |
207 |
char tuser[BUFSIZ], buf[BUFSIZ]; |
208 |
u_char respbuff[BUFSIZ]; |
209 |
@@ -416,13 +417,13 @@ |
210 |
return(0); |
211 |
} |
212 |
if (min_freespace) { |
213 |
- (void) sendcmd(C_SETCONFIG, "%c%d", SC_FREESPACE, |
214 |
+ (void) sendcmd(C_SETCONFIG, "%c%lld", SC_FREESPACE, |
215 |
min_freespace); |
216 |
if (response() < 0) |
217 |
return(0); |
218 |
} |
219 |
if (min_freefiles) { |
220 |
- (void) sendcmd(C_SETCONFIG, "%c%d", SC_FREEFILES, |
221 |
+ (void) sendcmd(C_SETCONFIG, "%c%lld", SC_FREEFILES, |
222 |
min_freefiles); |
223 |
if (response() < 0) |
224 |
return(0); |
225 |
--- ./src/common.c.ORI 2012-06-12 07:35:16.000000000 +0200 |
226 |
+++ ./src/common.c 2012-06-12 08:01:34.000000000 +0200 |
227 |
@@ -379,14 +379,14 @@ |
228 |
*/ |
229 |
static u_char rembuf[BUFSIZ]; |
230 |
static u_char *remptr; |
231 |
-static int remleft; |
232 |
+static ssize_t remleft; |
233 |
|
234 |
#define remc() (--remleft < 0 ? remmore() : *remptr++) |
235 |
|
236 |
/* |
237 |
* Back end to remote read() |
238 |
*/ |
239 |
-static int remread(fd, buf, bufsiz) |
240 |
+static ssize_t remread(fd, buf, bufsiz) |
241 |
int fd; |
242 |
u_char *buf; |
243 |
int bufsiz; |
244 |
@@ -480,7 +480,7 @@ |
245 |
/* |
246 |
* Non-line-oriented remote read. |
247 |
*/ |
248 |
-readrem(p, space) |
249 |
+ssize_t readrem(p, space) |
250 |
char *p; |
251 |
register int space; |
252 |
{ |
253 |
@@ -878,7 +878,7 @@ |
254 |
extern POINTER *malloc(); |
255 |
|
256 |
if ((ptr = (char *)malloc(amt)) == NULL) |
257 |
- fatalerr("Cannot malloc %d bytes of memory.", amt); |
258 |
+ fatalerr("Cannot malloc %zu bytes of memory.", amt); |
259 |
|
260 |
return(ptr); |
261 |
} |
262 |
@@ -894,7 +894,7 @@ |
263 |
extern POINTER *realloc(); |
264 |
|
265 |
if ((new = (char *)realloc(baseptr, amt)) == NULL) |
266 |
- fatalerr("Cannot realloc %d bytes of memory.", amt); |
267 |
+ fatalerr("Cannot realloc %zu bytes of memory.", amt); |
268 |
|
269 |
return(new); |
270 |
} |
271 |
@@ -910,7 +910,7 @@ |
272 |
extern POINTER *calloc(); |
273 |
|
274 |
if ((ptr = (char *)calloc(num, esize)) == NULL) |
275 |
- fatalerr("Cannot calloc %d * %d = %d bytes of memory.", |
276 |
+ fatalerr("Cannot calloc %zu * %zu = %zu bytes of memory.", |
277 |
num, esize, num * esize); |
278 |
|
279 |
return(ptr); |
280 |
--- ./src/filesys.c.ORI 2012-06-12 07:35:16.000000000 +0200 |
281 |
+++ ./src/filesys.c 2012-06-12 08:12:20.000000000 +0200 |
282 |
@@ -434,8 +434,8 @@ |
283 |
*/ |
284 |
int getfilesysinfo(file, freespace, freefiles) |
285 |
char *file; |
286 |
- long *freespace; |
287 |
- long *freefiles; |
288 |
+ int64_t *freespace; |
289 |
+ int64_t *freefiles; |
290 |
{ |
291 |
#if defined(STATFS_TYPE) |
292 |
static statfs_t statfsbuf; |
293 |
--- ./config/config-data.h.ORI 1998-11-10 04:59:47.000000000 +0100 |
294 |
+++ ./config/config-data.h 2012-06-12 07:55:48.000000000 +0200 |
295 |
@@ -58,10 +58,10 @@ |
296 |
* Set default write(2) return and amount types. |
297 |
*/ |
298 |
#if !defined(WRITE_RETURN_T) |
299 |
-#define WRITE_RETURN_T int /* What write() returns */ |
300 |
+#define WRITE_RETURN_T ssize_t /* What write() returns */ |
301 |
#endif /* WRITE_RETURN_T */ |
302 |
#if !defined(WRITE_AMT_T) |
303 |
-#define WRITE_AMT_T int /* Amount to write */ |
304 |
+#define WRITE_AMT_T size_t /* Amount to write */ |
305 |
#endif /* WRITE_AMT_T */ |
306 |
|
307 |
#endif /* __configdata_h__ */ |
308 |
--- ./src/client.c.ORI 2012-06-12 08:26:35.000000000 +0200 |
309 |
+++ ./src/client.c 2012-06-12 08:57:34.000000000 +0200 |
310 |
@@ -399,9 +399,9 @@ |
311 |
/* |
312 |
* Send file info |
313 |
*/ |
314 |
- (void) sendcmd(C_RECVREG, "%o %04o %ld %ld %ld %s %s %s", |
315 |
+ (void) sendcmd(C_RECVREG, "%o %04o %lld %ld %ld %s %s %s", |
316 |
opts, stb->st_mode & 07777, |
317 |
- (long) stb->st_size, |
318 |
+ (long long) stb->st_size, |
319 |
stb->st_mtime, stb->st_atime, |
320 |
user, group, rname); |
321 |
if (response() < 0) { |
322 |
@@ -409,8 +409,8 @@ |
323 |
return(-1); |
324 |
} |
325 |
|
326 |
- debugmsg(DM_MISC, "Send file '%s' %d bytes\n", |
327 |
- rname, (long) stb->st_size); |
328 |
+ debugmsg(DM_MISC, "Send file '%s' %ld bytes\n", |
329 |
+ rname, (long long) stb->st_size); |
330 |
|
331 |
/* |
332 |
* Set remote time out alarm handler. |
333 |
@@ -661,9 +661,9 @@ |
334 |
/* |
335 |
* Gather and send basic link info |
336 |
*/ |
337 |
- (void) sendcmd(C_RECVSYMLINK, "%o %04o %ld %ld %ld %s %s %s", |
338 |
+ (void) sendcmd(C_RECVSYMLINK, "%o %04o %lld %ld %ld %s %s %s", |
339 |
opts, stb->st_mode & 07777, |
340 |
- (long) stb->st_size, |
341 |
+ (long long) stb->st_size, |
342 |
stb->st_mtime, stb->st_atime, |
343 |
user, group, rname); |
344 |
if (response() < 0) |
345 |
@@ -843,7 +843,7 @@ |
346 |
/* |
347 |
* Parse size |
348 |
*/ |
349 |
- size = strtol(cp, &cp, 10); |
350 |
+ size = strtoll(cp, &cp, 10); |
351 |
if (*cp++ != ' ') { |
352 |
error("update: size not delimited"); |
353 |
return(US_NOTHING); |
354 |
@@ -895,8 +895,8 @@ |
355 |
|
356 |
debugmsg(DM_MISC, "update(%s,) local mode %04o remote mode %04o\n", |
357 |
rname, lmode, rmode); |
358 |
- debugmsg(DM_MISC, "update(%s,) size %d mtime %d owner '%s' grp '%s'\n", |
359 |
- rname, (int) size, mtime, owner, group); |
360 |
+ debugmsg(DM_MISC, "update(%s,) size %lld mtime %d owner '%s' grp '%s'\n", |
361 |
+ rname, (long long) size, mtime, owner, group); |
362 |
|
363 |
if (statp->st_mtime != mtime) { |
364 |
if (statp->st_mtime < mtime && IS_ON(opts, DO_YOUNGER)) { |
365 |
@@ -922,8 +922,8 @@ |
366 |
} |
367 |
|
368 |
if (statp->st_size != size) { |
369 |
- debugmsg(DM_MISC, "size does not match (%d != %d).\n", |
370 |
- (int) statp->st_size, size); |
371 |
+ debugmsg(DM_MISC, "size does not match (%lld != %lld).\n", |
372 |
+ (long long) statp->st_size, (long long)size); |
373 |
return(US_OUTDATE); |
374 |
} |
375 |
|
376 |
--- ./src/child.c.ORI 1998-11-10 05:18:57.000000000 +0100 |
377 |
+++ ./src/child.c 2012-06-12 08:58:16.000000000 +0200 |
378 |
@@ -189,7 +189,7 @@ |
379 |
CHILD *child; |
380 |
{ |
381 |
char rbuf[BUFSIZ]; |
382 |
- int amt; |
383 |
+ ssize_t amt; |
384 |
|
385 |
debugmsg(DM_CALL, "[readchild(%s, %d, %d) start]", |
386 |
child->c_name, child->c_pid, child->c_readfd); |
387 |
@@ -208,7 +208,7 @@ |
388 |
*/ |
389 |
while ((amt = read(child->c_readfd, rbuf, sizeof(rbuf))) > 0) { |
390 |
/* XXX remove these debug calls */ |
391 |
- debugmsg(DM_MISC, "[readchild(%s, %d, %d) got %d bytes]", |
392 |
+ debugmsg(DM_MISC, "[readchild(%s, %d, %d) got %lld bytes]", |
393 |
child->c_name, child->c_pid, child->c_readfd, amt); |
394 |
|
395 |
(void) xwrite(fileno(stdout), rbuf, amt); |
396 |
@@ -217,7 +217,7 @@ |
397 |
child->c_name, child->c_pid, child->c_readfd); |
398 |
} |
399 |
|
400 |
- debugmsg(DM_MISC, "readchild(%s, %d, %d) done: amt = %d errno = %d\n", |
401 |
+ debugmsg(DM_MISC, "readchild(%s, %d, %d) done: amt = %lld errno = %d\n", |
402 |
child->c_name, child->c_pid, child->c_readfd, amt, errno); |
403 |
|
404 |
/* |