View | Details | Raw Unified | Return to bug 99864 | Differences between
and this patch

Collapse All | Expand All

(-)Makefile (-72 / +65 lines)
Lines 5-24 Link Here
5
# $FreeBSD: ports/audio/xmms2/Makefile,v 1.12 2006/06/25 03:06:20 itetcu Exp $
5
# $FreeBSD: ports/audio/xmms2/Makefile,v 1.12 2006/06/25 03:06:20 itetcu Exp $
6
#
6
#
7
7
8
PORTNAME=	xmms2
8
PORTNAME?=	xmms2
9
PORTVERSION=	0.2.d.4
9
PORTVERSION=	0.2.d.5
10
PORTREVISION=	5
10
CATEGORIES?=	audio
11
CATEGORIES=	audio
12
MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
11
MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
13
MASTER_SITE_SUBDIR=	${PORTNAME}
12
MASTER_SITE_SUBDIR=	${PORTNAME}
14
DISTNAME=	${PORTNAME}-0.2DrDolittle
13
DISTNAME=	${PORTNAME}-0.2DrEvil
15
14
16
MAINTAINER=	alex@foxybanana.com
15
MAINTAINER=	alex@foxybanana.com
17
.if !defined(XMMS2_SLAVE)
16
COMMENT?=	Rewrite of xmms as a client/server system (developer release)
18
COMMENT=	Rewrite of xmms as a client/server system (developer release)
19
.endif
20
17
21
BUILD_DEPENDS+=	scons:${PORTSDIR}/devel/scons
22
.if !defined(XMMS2_SLAVE)
18
.if !defined(XMMS2_SLAVE)
23
LIB_DEPENDS=	mad.2:${PORTSDIR}/audio/libmad \
19
LIB_DEPENDS=	mad.2:${PORTSDIR}/audio/libmad \
24
		vorbis.3:${PORTSDIR}/audio/libvorbis
20
		vorbis.3:${PORTSDIR}/audio/libvorbis
Lines 28-50 Link Here
28
24
29
USE_PYTHON_BUILD=	yes
25
USE_PYTHON_BUILD=	yes
30
USE_BZIP2=	yes
26
USE_BZIP2=	yes
27
USE_SCONS=	yes
28
SCONS_ARGS=	EXCLUDE="${EXCLUDE}"
31
29
32
.if !defined(XMMS2_SLAVE)
30
.if !defined(XMMS2_SLAVE)
33
USE_GNOME=	glib20
31
USE_GNOME=	glib20
34
USE_SQLITE=	3
32
USE_SQLITE=	3
35
33
36
INSTALLS_SHLIB=	yes
34
USE_LDCONFIG=	yes
37
.endif
35
.endif
38
36
39
.if !defined(XMMS2_SLAVE)
37
.if !defined(XMMS2_SLAVE)
40
MAN1=		xmms2.1
38
MAN1=		xmms2.1 xmms2-et.1
41
MAN8=		xmms2d.8
39
MAN8=		xmms2d.8
42
MANCOMPRESSED=	yes
40
MANCOMPRESSED=	yes
43
.endif
41
.endif
44
42
45
SCONS_TARGET?=
43
OPTIONS=	FAAD "Support to playback AAC files" on \
44
		FLAC "Support to playback FLAC files" on \
45
		MODPLUG "Support to playback MOD files" off \
46
		MUSEPACK "Support to playback MPC files" off \
47
		SID "Support to playback SID files" off \
48
		WMA "Support to playback WMA files" off \
49
		CURL "Support to playback files via HTTP" on \
50
		GNOMEVFS "Support to playback files via GnomeVFS" off \
51
		MMS "Support to playback streams via MMS" off \
52
		SAMBA "Support to playback files via SMB" off \
53
		FAM "Support to update Media Library on file change" off \
54
		MDNS "Support to announce XMMS2d via mDNS" off #\
55
#		SDL "Support for visualization" on \
56
#		JACK "Support to output via the Jack output server" off
57
58
.include <bsd.port.pre.mk>
59
60
.if defined(XMMS2_SLAVE) && ${XMMS2_SLAVE} == "python"
61
EXCLUDE+=	ruby java xmmsclient-ecore xmmsclient++ xmmsclient++-glib
62
.elif defined(XMMS2_SLAVE) && ${XMMS2_SLAVE} == "ruby"
63
EXCLUDE+=	python java xmmsclient-ecore xmmsclient++ xmmsclient++-glib
64
.elif defined(XMMS2_SLAVE) && ${XMMS2_SLAVE} == "ruby-ecore"
65
EXCLUDE+=	python java xmmsclient++ xmmsclient++-glib
66
.elif defined(XMMS2_SLAVE) && ${XMMS2_SLAVE} == "java"
67
EXCLUDE+=	ruby python xmmsclient-ecore xmmsclient++ xmmsclient++-glib
68
.elif defined(XMMS2_SLAVE) && ${XMMS2_SLAVE} == "cpp"
69
EXCLUDE+=	ruby python java xmmsclient-ecore
70
.elif !defined(XMMS2_SLAVE)
71
EXCLUDE+=	python ruby java xmmsclient-ecore xmmsclient++ xmmsclient++-glib
72
.endif
46
73
47
.if defined(WITH_CURL)
74
.if !defined(XMMS2_SLAVE)
75
.if !defined(WITHOUT_CURL)
48
LIB_DEPENDS+=	curl.3:${PORTSDIR}/ftp/curl
76
LIB_DEPENDS+=	curl.3:${PORTSDIR}/ftp/curl
49
PLIST_SUB+=	CURL=""
77
PLIST_SUB+=	CURL=""
50
.else
78
.else
Lines 53-88 Link Here
53
.endif
81
.endif
54
82
55
.if defined(WITH_SID)
83
.if defined(WITH_SID)
56
LIB_DEPENDS+=	resid.[0-9]:${PORTSDIR}/audio/resid \
84
LIB_DEPENDS+=	sidplay2.[0-9]:${PORTSDIR}/audio/libsidplay2
57
		sidplay2.[0-9]:${PORTSDIR}/audio/libsidplay2
58
PLIST_SUB+=	SID=""
85
PLIST_SUB+=	SID=""
59
.else
86
.else
60
EXCLUDE+=	sid
87
EXCLUDE+=	sid
61
PLIST_SUB+=	SID="@comment "
88
PLIST_SUB+=	SID="@comment "
62
.endif
89
.endif
63
90
64
.if defined(XMMS2_SLAVE) && ${XMMS2_SLAVE} == "python"
91
.if !defined(WITHOUT_FLAC)
65
EXCLUDE+=	ruby java
66
.elif defined(XMMS2_SLAVE) && ${XMMS2_SLAVE} == "ruby"
67
EXCLUDE+=	python java
68
.elif defined(XMMS2_SLAVE) && ${XMMS2_SLAVE} == "ruby-ecore"
69
EXCLUDE+=	python java
70
WITH_ECORE=	yes
71
.elif defined(XMMS2_SLAVE) && ${XMMS2_SLAVE} == "java"
72
EXCLUDE+=	ruby python
73
.elif !defined(XMMS2_SLAVE)
74
EXCLUDE+=	python ruby java
75
.endif
76
77
.if defined(WITH_ECORE)
78
LIB_DEPENDS+=	ecore.1:${PORTSDIR}/x11/ecore
79
PLIST_SUB+=	ECORE=""
80
.else
81
EXCLUDE+=	xmmsclient-ecore
82
PLIST_SUB+=	ECORE="@comment "
83
.endif
84
85
.if defined(WITH_FLAC)
86
LIB_DEPENDS+=	FLAC.7:${PORTSDIR}/audio/flac
92
LIB_DEPENDS+=	FLAC.7:${PORTSDIR}/audio/flac
87
PLIST_SUB+=	FLAC=""
93
PLIST_SUB+=	FLAC=""
88
.else
94
.else
Lines 90-105 Link Here
90
PLIST_SUB+=	FLAC="@comment "
96
PLIST_SUB+=	FLAC="@comment "
91
.endif
97
.endif
92
98
93
.if defined(WITH_FAAD)
99
.if !defined(WITHOUT_FAAD)
94
LIB_DEPENDS+=	faad.0:${PORTSDIR}/audio/faad
100
LIB_DEPENDS+=	faad.0:${PORTSDIR}/audio/faad
95
PLIST_SUB+=	FAAD=""
101
PLIST_SUB+=	FAAD=""
96
#EXTRA_PATCHES+=	${FILESDIR}/extraPatch-src::clients::faad::Plugin
97
.else
102
.else
98
EXCLUDE+=	faad
103
EXCLUDE+=	faad
99
PLIST_SUB+=	FAAD="@comment "
104
PLIST_SUB+=	FAAD="@comment "
100
.endif
105
.endif
101
106
102
.if defined(WITH_SDL)
107
.if defined(WITH_WMA)
108
LIB_DEPENDS+=	avutil.1:${PORTSDIR}/multimedia/ffmpeg-devel
109
PLIST_SUB+=	WMA=""
110
.else
111
EXCLUDE+=	wma
112
PLIST_SUB+=	WMA="@comment "
113
.endif
114
115
.if !defined(WITHOUT_SDL) && defined(UNDEFINED)
116
IGNORE=		visualization has not been updated to the Transforms API
103
USE_SDL=	sdl ttf
117
USE_SDL=	sdl ttf
104
PLIST_SUB+=	SDL=""
118
PLIST_SUB+=	SDL=""
105
#EXTRA_PATCHES+=	${FILESDIR}/extraPatch-src::clients::sdl-vis::Program
119
#EXTRA_PATCHES+=	${FILESDIR}/extraPatch-src::clients::sdl-vis::Program
Lines 117-122 Link Here
117
.endif
131
.endif
118
132
119
.if defined(WITH_JACK)
133
.if defined(WITH_JACK)
134
IGNORE=		the Jack plugin has not been updated to the Transforms API
120
LIB_DEPENDS+=	jack.0:${PORTSDIR}/audio/jack
135
LIB_DEPENDS+=	jack.0:${PORTSDIR}/audio/jack
121
PLIST_SUB+=	JACK=""
136
PLIST_SUB+=	JACK=""
122
.else
137
.else
Lines 148-153 Link Here
148
PLIST_SUB+=	GNOMEVFS="@comment "
163
PLIST_SUB+=	GNOMEVFS="@comment "
149
.endif
164
.endif
150
165
166
.if defined(WITH_MMS)
167
LIB_DEPENDS+=	mms.0:${PORTSDIR}/net/libmms
168
PLIST_SUB+=	MMS=""
169
.else
170
EXCLUDE+=	mms
171
PLIST_SUB+=	MMS="@comment "
172
.endif
173
151
.if defined(WITH_FAM)
174
.if defined(WITH_FAM)
152
USE_FAM=	yes
175
USE_FAM=	yes
153
WANT_FAM_SYSTEM=gamin
176
WANT_FAM_SYSTEM=gamin
Lines 164-205 Link Here
164
EXCLUDE+=	mdns
187
EXCLUDE+=	mdns
165
PLIST_SUB+=	MDNS="@comment "
188
PLIST_SUB+=	MDNS="@comment "
166
.endif
189
.endif
167
190
.endif
168
.include <bsd.port.pre.mk>
169
191
170
.if defined(XMMS2_SLAVE) && ${XMMS2_SLAVE} != "java"
192
.if defined(XMMS2_SLAVE) && ${XMMS2_SLAVE} != "java"
171
.if ${OSVERSION} < 500000
193
.if ${OSVERSION} < 500000
172
BROKEN=	Broken on FreeBSD 4.x
194
IGNORE=	broken on FreeBSD 4.x
173
.endif
195
.endif
174
.endif
196
.endif
175
197
176
pre-everything::
177
.if defined(WITH_SAMBA)
178
	@${ECHO_MSG} "WARNING: Samba plugin is experimental and not fully working"
179
	@${ECHO_MSG} ""
180
.endif
181
.if defined(WITH_GNOMEVFS)
182
	@${ECHO_MSG} "WARNING: Gnome VFS plugin is experimental and not fully working"
183
	@${ECHO_MSG} ""
184
.endif
185
.if defined(WITH_FAM)
186
	@${ECHO_MSG} "WARNING: Fam plugin is experimental and not fully working"
187
	@${ECHO_MSG} ""
188
.endif
189
190
# Nasty fulhack here to deal with java port. We're dealing with this issue
191
# in xmms2 upstream land, so it hopefully won't be a problem next release.
192
193
do-build:
194
	cd ${WRKSRC} && \
195
		${SETENV} JAVA_HOME=${JAVA_HOME} scons CC=${CC} LINKFLAGS="${LDFLAGS}" CCFLAGS="${CFLAGS}" \
196
		LIBPATH=${LOCALBASE}/lib CPPPATH=${LOCALBASE}/include \
197
		PKGCONFIGDIR=${PREFIX}/libdata/pkgconfig EXCLUDE="${EXCLUDE}" \
198
		PREFIX="${PREFIX}" ${SCONS_TARGET}
199
200
.if !defined(XMMS2_SLAVE)
201
do-install:
202
	@cd ${WRKSRC} && scons install
203
.endif
204
205
.include <bsd.port.post.mk>
198
.include <bsd.port.post.mk>
(-)distinfo (-3 / +3 lines)
Lines 1-3 Link Here
1
SHA256 (xmms2-0.2DrDolittle.tar.bz2) = 896b3a63a2c0141c278a8ab0203f11ce8594e64e3bea9129db52388c00672535
1
MD5 (xmms2-0.2DrEvil.tar.bz2) = 110e1b5d3d5d89e64c2099cec4d0402b
2
MD5 (xmms2-0.2DrDolittle.tar.bz2) = 93daf53d21d198d8e05bf4de37976d7a
2
SHA256 (xmms2-0.2DrEvil.tar.bz2) = 1059fe1b6a03a40f8b680055c64e6475d769298983804f88ff6d38d88d514f28
3
SIZE (xmms2-0.2DrDolittle.tar.bz2) = 965031
3
SIZE (xmms2-0.2DrEvil.tar.bz2) = 1012538
(-)pkg-plist (-11 / +26 lines)
Lines 5-12 Link Here
5
%%MDNS%%bin/xmms2-mdns-avahi
5
%%MDNS%%bin/xmms2-mdns-avahi
6
bin/xmms2d
6
bin/xmms2d
7
include/xmms2/xmms/xmms_config.h
7
include/xmms2/xmms/xmms_config.h
8
include/xmms2/xmms/xmms_decoder.h
9
include/xmms2/xmms/xmms_decoderplugin.h
10
include/xmms2/xmms/xmms_defs.h
8
include/xmms2/xmms/xmms_defs.h
11
include/xmms2/xmms/xmms_effect.h
9
include/xmms2/xmms/xmms_effect.h
12
include/xmms2/xmms/xmms_effectplugin.h
10
include/xmms2/xmms/xmms_effectplugin.h
Lines 15-27 Link Here
15
include/xmms2/xmms/xmms_log.h
13
include/xmms2/xmms/xmms_log.h
16
include/xmms2/xmms/xmms_medialib.h
14
include/xmms2/xmms/xmms_medialib.h
17
include/xmms2/xmms/xmms_object.h
15
include/xmms2/xmms/xmms_object.h
18
include/xmms2/xmms/xmms_output.h
19
include/xmms2/xmms/xmms_outputplugin.h
16
include/xmms2/xmms/xmms_outputplugin.h
20
include/xmms2/xmms/xmms_plsplugins.h
17
include/xmms2/xmms/xmms_plsplugins.h
21
include/xmms2/xmms/xmms_plugin.h
18
include/xmms2/xmms/xmms_plugin.h
22
include/xmms2/xmms/xmms_sample.h
19
include/xmms2/xmms/xmms_sample.h
23
include/xmms2/xmms/xmms_transport.h
20
include/xmms2/xmms/xmms_streamtype.h
24
include/xmms2/xmms/xmms_transportplugin.h
21
include/xmms2/xmms/xmms_xformplugin.h
25
include/xmms2/xmmsc/xmmsc_asyncns.h
22
include/xmms2/xmmsc/xmmsc_asyncns.h
26
include/xmms2/xmmsc/xmmsc_errorcodes.h
23
include/xmms2/xmmsc/xmmsc_errorcodes.h
27
include/xmms2/xmmsc/xmmsc_idnumbers.h
24
include/xmms2/xmmsc/xmmsc_idnumbers.h
Lines 34-72 Link Here
34
include/xmms2/xmmsc/xmmsc_stringport.h
31
include/xmms2/xmmsc/xmmsc_stringport.h
35
include/xmms2/xmmsc/xmmsc_unistd.h
32
include/xmms2/xmmsc/xmmsc_unistd.h
36
include/xmms2/xmmsc/xmmsc_util.h
33
include/xmms2/xmmsc/xmmsc_util.h
34
include/xmms2/xmmsclient/xmmsclient++/client.h
35
include/xmms2/xmmsclient/xmmsclient++/config.h
36
include/xmms2/xmmsclient/xmmsclient++/dict.h
37
include/xmms2/xmmsclient/xmmsclient++/exceptions.h
38
include/xmms2/xmmsclient/xmmsclient++/helpers.h
39
include/xmms2/xmmsclient/xmmsclient++/list.h
40
include/xmms2/xmmsclient/xmmsclient++/listener.h
41
include/xmms2/xmmsclient/xmmsclient++/mainloop.h
42
include/xmms2/xmmsclient/xmmsclient++/medialib.h
43
include/xmms2/xmmsclient/xmmsclient++/playback.h
44
include/xmms2/xmmsclient/xmmsclient++/playlist.h
45
include/xmms2/xmmsclient/xmmsclient++/signal.h
46
include/xmms2/xmmsclient/xmmsclient++/stats.h
47
include/xmms2/xmmsclient/xmmsclient++/typedefs.h
48
include/xmms2/xmmsclient/xmmsclient++-glib.h
49
include/xmms2/xmmsclient/xmmsclient++.h
37
include/xmms2/xmmsclient/xmmsclient-cf.h
50
include/xmms2/xmmsclient/xmmsclient-cf.h
38
include/xmms2/xmmsclient/xmmsclient-ecore.h
51
include/xmms2/xmmsclient/xmmsclient-ecore.h
39
include/xmms2/xmmsclient/xmmsclient-glib.h
52
include/xmms2/xmmsclient/xmmsclient-glib.h
40
include/xmms2/xmmsclient/xmmsclient-qt.h
53
include/xmms2/xmmsclient/xmmsclient-qt.h
41
include/xmms2/xmmsclient/xmmsclient.h
54
include/xmms2/xmmsclient/xmmsclient.h
42
%%ECORE%%lib/libxmmsclient-ecore.a
43
%%ECORE%%lib/libxmmsclient-ecore.so
44
lib/libxmmsclient-glib.a
55
lib/libxmmsclient-glib.a
45
lib/libxmmsclient-glib.so
56
lib/libxmmsclient-glib.so
46
lib/libxmmsclient.a
57
lib/libxmmsclient.a
47
lib/libxmmsclient.so
58
lib/libxmmsclient.so
48
%%CURL%%lib/xmms2/libxmms_curl_http.so
59
%%CURL%%lib/xmms2/libxmms_curl_http.so
49
lib/xmms2/libxmms_diskwrite.so
60
lib/xmms2/libxmms_diskwrite.so
50
lib/xmms2/libxmms_eq.so
61
lib/xmms2/libxmms_equalizer.so
51
%%FAAD%%lib/xmms2/libxmms_faad.so
62
%%FAAD%%lib/xmms2/libxmms_faad.so
52
%%FLAC%%lib/xmms2/libxmms_flac.so
63
%%FLAC%%lib/xmms2/libxmms_flac.so
53
lib/xmms2/libxmms_file.so
64
lib/xmms2/libxmms_file.so
54
%%GNOMEVFS%%lib/xmms2/libxmms_gnomevfs.so
65
%%GNOMEVFS%%lib/xmms2/libxmms_gnomevfs.so
55
lib/xmms2/libxmms_html.so
66
lib/xmms2/libxmms_icymetaint.so
67
lib/xmms2/libxmms_id3v2.so
56
%%JACK%%lib/xmms2/libxmms_jack.so
68
%%JACK%%lib/xmms2/libxmms_jack.so
57
lib/xmms2/libxmms_m3u.so
58
lib/xmms2/libxmms_mad.so
69
lib/xmms2/libxmms_mad.so
70
%%MMS%%lib/xmms2/libxmms_mms.so
59
%%MODPLUG%%lib/xmms2/libxmms_modplug.so
71
%%MODPLUG%%lib/xmms2/libxmms_modplug.so
60
%%MUSEPACK%%lib/xmms2/libxmms_musepack.so
72
%%MUSEPACK%%lib/xmms2/libxmms_musepack.so
61
lib/xmms2/libxmms_null.so
73
lib/xmms2/libxmms_null.so
74
lib/xmms2/libxmms_nulstripper.so
62
lib/xmms2/libxmms_oss.so
75
lib/xmms2/libxmms_oss.so
63
lib/xmms2/libxmms_pls.so
64
lib/xmms2/libxmms_replaygain.so
76
lib/xmms2/libxmms_replaygain.so
65
%%SAMBA%%lib/xmms2/libxmms_samba.so
77
%%SAMBA%%lib/xmms2/libxmms_samba.so
66
%%SID%%lib/xmms2/libxmms_sid.so
78
%%SID%%lib/xmms2/libxmms_sid.so
67
lib/xmms2/libxmms_vorbisfile.so
79
lib/xmms2/libxmms_vorbisfile.so
68
lib/xmms2/libxmms_wave.so
80
lib/xmms2/libxmms_wave.so
81
%%WMA%%lib/xmms2/libxmms_wma.so
69
libdata/pkgconfig/xmms2-client-cpp.pc
82
libdata/pkgconfig/xmms2-client-cpp.pc
83
libdata/pkgconfig/xmms2-client-cpp-glib.pc
70
libdata/pkgconfig/xmms2-client-ecore.pc
84
libdata/pkgconfig/xmms2-client-ecore.pc
71
libdata/pkgconfig/xmms2-client-glib.pc
85
libdata/pkgconfig/xmms2-client-glib.pc
72
libdata/pkgconfig/xmms2-client.pc
86
libdata/pkgconfig/xmms2-client.pc
Lines 78-83 Link Here
78
@dirrm %%DATADIR%%/scripts
92
@dirrm %%DATADIR%%/scripts
79
@dirrm %%DATADIR%%
93
@dirrm %%DATADIR%%
80
@dirrm lib/xmms2
94
@dirrm lib/xmms2
95
@dirrm include/xmms2/xmmsclient/xmmsclient++
81
@dirrm include/xmms2/xmmsclient
96
@dirrm include/xmms2/xmmsclient
82
@dirrm include/xmms2/xmmsc
97
@dirrm include/xmms2/xmmsc
83
@dirrm include/xmms2/xmms
98
@dirrm include/xmms2/xmms
(-)files/patch-src_clients_lib_java_callbacks.c (-77 lines)
Removed Link Here
1
--- src/clients/lib/java/callbacks.c.orig	Mon Mar 27 11:34:45 2006
2
+++ src/clients/lib/java/callbacks.c	Sat Apr  8 00:27:56 2006
3
@@ -38,11 +38,12 @@
4
 }
5
 
6
 void io_want_out_callback(int val, void *error){
7
+	jobject callbackObject;
8
 	JNIEnv *environment = checkEnv();  
9
 	if (environment == NULL)
10
 		return;
11
 	
12
-	jobject callbackObject = (*environment)->NewLocalRef(environment, globalMainloopObj);
13
+	callbackObject = (*environment)->NewLocalRef(environment, globalMainloopObj);
14
 	if (io_want_out_mid == 0)
15
 		return;
16
 
17
@@ -117,6 +118,7 @@
18
 void callback_dict_foreach_function(const void *key, xmmsc_result_value_type_t type, const void *value, void *user_data){
19
 	jint jres_val = 0;
20
 	jstring jkey, jvalue;
21
+	jobject callbackObject;
22
 	JNIEnv *environment = checkEnv();
23
 	
24
 	if (key == NULL || value == NULL) return;
25
@@ -124,7 +126,7 @@
26
 	if (environment == NULL)
27
 		return;
28
 	
29
-	jobject callbackObject = (*environment)->NewLocalRef(environment, globalObj);
30
+	callbackObject = (*environment)->NewLocalRef(environment, globalObj);
31
 	if (dict_foreach_mid == 0)
32
 	        return;
33
 	
34
@@ -138,13 +140,14 @@
35
 void callback_propdict_foreach_function(const void *key, xmmsc_result_value_type_t type, const void *value, const char *source, void *user_data){
36
 	jint jres_val = 0;
37
 	jstring jkey, jvalue, jsource;
38
+	jobject callbackObject;
39
 	JNIEnv *environment = checkEnv();
40
 	if (environment == NULL)
41
 		return;
42
 		
43
 	if (key == NULL || value == NULL) return;
44
 	
45
-	jobject callbackObject = (*environment)->NewLocalRef(environment, globalObj);   
46
+	callbackObject = (*environment)->NewLocalRef(environment, globalObj);   
47
 	if (propdict_foreach_mid == 0)
48
 	        return;
49
 	
50
@@ -173,12 +176,13 @@
51
 
52
 void run_java_callback_result_void(xmmsc_result_t *res, jmethodID mid, void *user_data){
53
 	jlong jresult = 0;
54
+	jobject callbackObject;
55
 	JNIEnv *environment = checkEnv();
56
     
57
 	if (environment == NULL)
58
 		return;
59
 		
60
-	jobject callbackObject = (*environment)->NewLocalRef(environment, globalObj);   
61
+	callbackObject = (*environment)->NewLocalRef(environment, globalObj);   
62
 	if (mid == 0)
63
 	        return;
64
    
65
@@ -188,10 +192,11 @@
66
 
67
 void run_java_callback_void(void *v, jmethodID mid){
68
 	JNIEnv *environment = checkEnv();
69
+	jobject callbackObject;
70
 	if (environment == NULL)
71
 		return;
72
 	
73
-	jobject callbackObject = (*environment)->NewLocalRef(environment, globalObj);   
74
+	callbackObject = (*environment)->NewLocalRef(environment, globalObj);   
75
 	if (mid == 0)
76
         	return;
77
 
(-)files/patch-src_clients_lib_java_include_callbacks.h (-25 lines)
Removed Link Here
1
--- src/clients/lib/java/include/callbacks.h.orig	Mon Mar 27 11:34:45 2006
2
+++ src/clients/lib/java/include/callbacks.h	Sat Apr  8 00:27:56 2006
3
@@ -14,6 +14,13 @@
4
  *  Lesser General Public License for more details.
5
  */
6
 
7
+#ifndef __CALLBACKS_H__
8
+#define __CALLBACKS_H__
9
+
10
+#ifdef __cplusplus
11
+{
12
+#endif
13
+
14
 #include <xmmsclient/xmmsclient.h>
15
 #include <jni.h>
16
 
17
@@ -67,3 +74,8 @@
18
 extern void callback_dict_foreach_function(const void *key, xmmsc_result_value_type_t type, const void *value, void *user_data);
19
 extern void callback_propdict_foreach_function(const void *key, xmmsc_result_value_type_t type, const void *value, const char *source, void *user_data);
20
 
21
+#ifdef __cplusplus
22
+}
23
+#endif
24
+
25
+#endif
(-)files/patch-src_clients_lib_java_include_misc.h (-24 lines)
Removed Link Here
1
--- src/clients/lib/java/include/misc.h.orig	Mon Mar 27 11:34:45 2006
2
+++ src/clients/lib/java/include/misc.h	Sat Apr  8 00:27:56 2006
3
@@ -14,8 +14,21 @@
4
  *  Lesser General Public License for more details.
5
  */
6
 
7
+#ifndef __MISC_H__
8
+#define __MISC_H__
9
+
10
+#ifdef __cplusplus
11
+{
12
+#endif
13
+
14
 #include <xmmsclient/xmmsclient.h>
15
 #include <jni.h>
16
 
17
 extern xmmsc_result_t* getResultFromPointer(jlong val);
18
 extern jlong getPointerToConnection(xmmsc_connection_t *c);
19
+
20
+#ifdef __cplusplus
21
+}
22
+#endif
23
+
24
+#endif
(-)files/patch-src_clients_lib_java_misc.c (-32 lines)
Removed Link Here
1
--- src/clients/lib/java/misc.c.orig	Mon Mar 27 11:34:45 2006
2
+++ src/clients/lib/java/misc.c	Sat Apr  8 00:27:56 2006
3
@@ -37,11 +37,12 @@
4
 }
5
 
6
 JNIEXPORT void JNICALL Java_org_xmms2_SpecialJNI_setENV(JNIEnv *jenv, jclass cls, jobject myobject){
7
+	jclass clazz;
8
 	globalObj = (*jenv)->NewGlobalRef(jenv, myobject);
9
 	if (jvm == NULL)
10
 		(*jenv)->GetJavaVM(jenv,&jvm);
11
 
12
-	jclass clazz = (*jenv)->GetObjectClass(jenv, myobject);
13
+	clazz = (*jenv)->GetObjectClass(jenv, myobject);
14
 	disconnect_mid = get_method_id("callbackDisconnect", "(I)V", jenv, clazz);
15
 	lock_mid = get_method_id("lockFunction", "(I)V", jenv, clazz);
16
 	unlock_mid = get_method_id("unlockFunction", "(I)V", jenv, clazz);
17
@@ -71,13 +72,14 @@
18
 
19
 JNIEXPORT void JNICALL Java_org_xmms2_SpecialJNI_setupMainloop(JNIEnv *jenv, jclass cls, jobject myobject, jlong jarg1){
20
 	xmmsc_connection_t *conn_ptr = (xmmsc_connection_t *) 0;
21
+	jclass clazz;
22
 	conn_ptr = *(xmmsc_connection_t **)(void *)&jarg1;
23
 	globalMainloopObj = (*jenv)->NewGlobalRef(jenv, myobject);
24
 	
25
 	if (jvm == NULL)
26
 		(*jenv)->GetJavaVM(jenv,&jvm);
27
 
28
-	jclass clazz = (*jenv)->GetObjectClass(jenv, myobject);
29
+	clazz = (*jenv)->GetObjectClass(jenv, myobject);
30
 	io_want_out_mid = get_method_id("callbackIOWantOut", "(II)V", jenv, clazz);
31
 	
32
 	//xmmsc_io_need_out_callback_set(conn_ptr, io_want_out_callback, 0);
(-)files/patch-src_clients_lib_python_xmmsclient.pyx (-12 lines)
Removed Link Here
1
--- src/clients/lib/python/xmmsclient.pyx.orig	Tue May 23 01:02:46 2006
2
+++ src/clients/lib/python/xmmsclient.pyx	Tue May 23 01:03:14 2006
3
@@ -273,7 +273,8 @@
4
 						if k[1] == item:
5
 							return v
6
 				try:
7
-					return dict.__getitem__(self, (src, item))
8
+					x = dict.__getitem__(self, (src, item))
9
+					return x
10
 				except KeyError:
11
 					pass
12
 			raise KeyError, item
(-)files/patch-src_clients_sdl-vis_sdl-vis.c (-13 lines)
Removed Link Here
1
--- src/clients/sdl-vis/sdl-vis.c	Mon Mar 27 11:34:45 2006
2
+++ src/clients/sdl-vis/sdl-vis.c.orig	Sat Apr  1 18:21:01 2006
3
@@ -27,8 +27,8 @@
4
 #define FFT_BITS 10
5
 #define FFT_LEN (1<<FFT_BITS)
6
 
7
-#include <SDL/SDL.h>
8
-#include <SDL/SDL_ttf.h>
9
+#include <SDL.h>
10
+#include <SDL_ttf.h>
11
 #include <glib.h>
12
 #include <math.h>
13
 #include <stdlib.h>
(-)files/patch-src_plugins_faad_Plugin (-16 lines)
Removed Link Here
1
--- src/plugins/faad/Plugin.orig	Tue Dec 20 01:09:13 2005
2
+++ src/plugins/faad/Plugin	Tue Dec 20 01:09:48 2005
3
@@ -12,12 +12,7 @@
4
 	This function should return True if this module
5
 	is to be built otherwise False
6
 	"""
7
-	try:
8
-		env.checklib("faad", "faacDecInit2")
9
-	except ConfigError:
10
-		env.checklib("faad", "NeAACDecInit2")
11
-	except ConfigError:
12
-		raise ConfigError("Could not find libfaad")
13
+	env.Append (LIBS=["faad"])
14
 
15
 	env.Append (CCFLAGS = '-DUSE_TAGGING')
16
 
(-)files/patch-src_plugins_sid_Plugin (+9 lines)
Added Link Here
1
--- src/plugins/sid/Plugin.orig	Thu Jul  6 22:25:16 2006
2
+++ src/plugins/sid/Plugin	Thu Jul  6 22:27:29 2006
3
@@ -6,4 +6,5 @@
4
     builder_path = env.run("pkg-config libsidplay2 --variable=builders").strip()
5
     if builder_path:
6
         env.Append(LIBPATH=["-L%s" % builder_path])
7
-    env.checklib("resid-builder", "resid_version_string")
8
+	env.Append(LINKFLAGS=['-rpath=%s' % builder_path])
9
+	env.Append(LIBS=["resid-builder"])
(-)files/patch-src_xmms_Program (-3 / +3 lines)
Lines 1-5 Link Here
1
--- src/xmms/Program.orig	Sat Apr  1 17:55:42 2006
1
--- src/xmms/Program.orig	Thu Jul  6 15:35:55 2006
2
+++ src/xmms/Program	Sat Apr  1 17:55:56 2006
2
+++ src/xmms/Program	Thu Jul  6 17:36:50 2006
3
@@ -29,10 +29,10 @@
3
@@ -29,10 +29,10 @@
4
 	env.Append(LIBS=['xmmsipc'])
4
 	env.Append(LIBS=['xmmsipc'])
5
 	env.Append(LIBS=["xmmssocket"])
5
 	env.Append(LIBS=["xmmssocket"])
Lines 12-17 Link Here
12
+	env.pkgconfig("gmodule-2.0")
12
+	env.pkgconfig("gmodule-2.0")
13
+	env.pkgconfig("gthread-2.0")
13
+	env.pkgconfig("gthread-2.0")
14
+	env.pkgconfig("sqlite3")
14
+	env.pkgconfig("sqlite3")
15
 	
15
 
16
 	if env.platform != 'win32':
16
 	if env.platform != 'win32':
17
 		env.checklib("m", "sin", fail=True)
17
 		env.checklib("m", "sin", fail=True)
(-)files/patch-src_xmms_ipc.c (-12 lines)
Removed Link Here
1
--- src/xmms/ipc.c.orig	Sat Apr  1 23:59:54 2006
2
+++ src/xmms/ipc.c	Sun Apr  2 00:00:09 2006
3
@@ -795,8 +795,8 @@
4
 xmms_ipc_shutdown_server(xmms_ipc_t *ipc) 
5
 {
6
 	GList *c;
7
-	if(!ipc) return;
8
 	xmms_ipc_client_t *co;
9
+	if(!ipc) return;
10
 	
11
 	g_mutex_lock (ipc->mutex_lock);
12
 	g_source_remove_poll (ipc->source, ipc->pollfd);

Return to bug 99864