FreeBSD Bugzilla – Attachment 128710 Details for
Bug 172566
Fix analyzer warnings in /games
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
file.diff
file.diff (text/plain), 1.54 KB, created by
Erik Cederstrand
on 2012-10-10 12:00:00 UTC
(
hide
)
Description:
file.diff
Filename:
MIME Type:
Creator:
Erik Cederstrand
Created:
2012-10-10 12:00:00 UTC
Size:
1.54 KB
patch
obsolete
>Index: head/games/random/randomize_fd.c >=================================================================== >--- head/games/random/randomize_fd.c (revision 241370) >+++ head/games/random/randomize_fd.c (working copy) >@@ -207,6 +207,7 @@ > goto make_token; > } > >+ free(buf); > for (i = numnode; i > 0; i--) { > selected = random() % numnode; > >Index: head/games/fortune/fortune/fortune.c >=================================================================== >--- head/games/fortune/fortune/fortune.c (revision 241370) >+++ head/games/fortune/fortune/fortune.c (working copy) >@@ -576,6 +576,10 @@ > if (*head == NULL) > *head = *tail = fp; > else if (fp->percent == NO_PROB) { >+ if (*tail == NULL) { >+ fprintf(stderr, "No tail file given\n"); >+ exit(1); >+ } > (*tail)->next = fp; > fp->prev = *tail; > *tail = fp; >Index: head/games/bcd/bcd.c >=================================================================== >--- head/games/bcd/bcd.c (revision 241370) >+++ head/games/bcd/bcd.c (working copy) >@@ -129,9 +129,6 @@ > { > char cardline[80]; > >- /* revoke setgid privileges */ >- setgid(getgid()); >- > /* > * The original bcd prompts with a "%" when reading from stdin, > * but this seems kind of silly. So this one doesn't. >Index: head/games/caesar/caesar.c >=================================================================== >--- head/games/caesar/caesar.c (revision 241370) >+++ head/games/caesar/caesar.c (working copy) >@@ -82,9 +82,6 @@ > char *inbuf; > int obs[26], try, winner; > >- /* revoke setgid privileges */ >- setgid(getgid()); >- > if (argc > 1) > printit(argv[1]);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 172566
: 128710 |
128711