Attachment 145333 Details for Bug 192370 – Fix compiler warnings

[patch] Fix compiler warnings

tclX-warns.diff (text/plain), 5.82 KB, created by Pietro Cerutti on 2014-08-04 07:56:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pietro Cerutti

Created: 2014-08-04 07:56:33 UTC

Size: 5.82 KB

patch

obsolete

>Index: files/patch-generic_tclXchmod.c
>===================================================================
>--- files/patch-generic_tclXchmod.c	(revision 0)
>+++ files/patch-generic_tclXchmod.c	(working copy)
>@@ -0,0 +1,10 @@
>+--- generic/tclXchmod.c.orig	2014-07-30 17:45:54.000000000 +0200
>++++ generic/tclXchmod.c	2014-07-30 17:48:09.000000000 +0200
>+@@ -353,6 +353,7 @@
>+ 	modeInfo.absMode = modeBits;
>+         modeInfo.symMode = NULL;
>+     } else {
>++        modeInfo.absMode = 0; // not used, but keeps compilers happy
>+         modeInfo.symMode = modeString;
>+     }
>+ 
>
>Property changes on: files/patch-generic_tclXchmod.c
>___________________________________________________________________
>Added: svn:mime-type
>## -0,0 +1 ##
>+text/plain
>\ No newline at end of property
>Added: fbsd:nokeywords
>## -0,0 +1 ##
>+yes
>\ No newline at end of property
>Added: svn:eol-style
>## -0,0 +1 ##
>+native
>\ No newline at end of property
>Index: files/patch-generic_tclXdup.c
>===================================================================
>--- files/patch-generic_tclXdup.c	(revision 0)
>+++ files/patch-generic_tclXdup.c	(working copy)
>@@ -0,0 +1,11 @@
>+--- generic/tclXdup.c.orig	2014-07-30 16:44:06.000000000 +0200
>++++ generic/tclXdup.c	2014-07-30 16:45:30.000000000 +0200
>+@@ -128,7 +128,7 @@
>+     char       *targetChannelId;
>+ {
>+     Tcl_Channel srcChannel, newChannel = NULL;
>+-    Tcl_ChannelType *channelType;
>++    const Tcl_ChannelType *channelType;
>+     int mode;
>+ 
>+     srcChannel = Tcl_GetChannel (interp, srcChannelId, &mode);
>
>Property changes on: files/patch-generic_tclXdup.c
>___________________________________________________________________
>Added: fbsd:nokeywords
>## -0,0 +1 ##
>+yes
>\ No newline at end of property
>Added: svn:eol-style
>## -0,0 +1 ##
>+native
>\ No newline at end of property
>Added: svn:mime-type
>## -0,0 +1 ##
>+text/plain
>\ No newline at end of property
>Index: files/patch-generic_tclXfcntl.c
>===================================================================
>--- files/patch-generic_tclXfcntl.c	(revision 0)
>+++ files/patch-generic_tclXfcntl.c	(working copy)
>@@ -0,0 +1,12 @@
>+--- generic/tclXfcntl.c.orig	2014-07-30 16:45:58.000000000 +0200
>++++ generic/tclXfcntl.c	2014-07-30 16:46:21.000000000 +0200
>+@@ -162,7 +162,8 @@
>+     int          mode;
>+     int          attrib;
>+ {
>+-    int value, optValue;
>++    int value = 0;
>++    int optValue;
>+ 
>+     switch (attrib) {
>+       case ATTR_RDONLY:
>
>Property changes on: files/patch-generic_tclXfcntl.c
>___________________________________________________________________
>Added: svn:mime-type
>## -0,0 +1 ##
>+text/plain
>\ No newline at end of property
>Added: fbsd:nokeywords
>## -0,0 +1 ##
>+yes
>\ No newline at end of property
>Added: svn:eol-style
>## -0,0 +1 ##
>+native
>\ No newline at end of property
>Index: files/patch-generic_tclXhandles.c
>===================================================================
>--- files/patch-generic_tclXhandles.c	(revision 0)
>+++ files/patch-generic_tclXhandles.c	(working copy)
>@@ -0,0 +1,11 @@
>+--- generic/tclXhandles.c.orig	2014-07-30 17:35:38.000000000 +0200
>++++ generic/tclXhandles.c	2014-07-30 17:35:43.000000000 +0200
>+@@ -567,7 +567,7 @@
>+ 
>+     entryHdrPtr = HEADER_AREA (entryPtr);
>+     if (entryHdrPtr->freeLink != ALLOCATED_IDX)
>+-        panic ("Tcl_HandleFree: entry not allocated %x\n", entryHdrPtr);
>++        panic ("Tcl_HandleFree: entry not allocated %p\n", entryHdrPtr);
>+ 
>+     entryHdrPtr->freeLink = tblHdrPtr->freeHeadIdx;
>+     tblHdrPtr->freeHeadIdx =
>
>Property changes on: files/patch-generic_tclXhandles.c
>___________________________________________________________________
>Added: svn:mime-type
>## -0,0 +1 ##
>+text/plain
>\ No newline at end of property
>Added: fbsd:nokeywords
>## -0,0 +1 ##
>+yes
>\ No newline at end of property
>Added: svn:eol-style
>## -0,0 +1 ##
>+native
>\ No newline at end of property
>Index: files/patch-generic_tclXutil.c
>===================================================================
>--- files/patch-generic_tclXutil.c	(revision 0)
>+++ files/patch-generic_tclXutil.c	(working copy)
>@@ -0,0 +1,20 @@
>+--- generic/tclXutil.c.orig	2014-07-30 16:56:00.000000000 +0200
>++++ generic/tclXutil.c	2014-07-30 16:56:50.000000000 +0200
>+@@ -870,7 +870,7 @@
>+ TclX_IsNullObj (objPtr)
>+     Tcl_Obj *objPtr;
>+ {
>+-    static Tcl_ObjType *listType = NULL, *stringType = NULL;
>++    const static Tcl_ObjType *listType = NULL, *stringType = NULL;
>+     int length;
>+     
>+     /*
>+@@ -956,7 +956,7 @@
>+ {
>+     Tcl_Obj **saveObjv;
>+     int saveObjc;
>+-    long flags;
>++    long flags = 0;
>+ 
>+     if ((Tcl_ListObjGetElements (NULL, saveObjPtr, &saveObjc,
>+                                  &saveObjv) != TCL_OK) ||
>
>Property changes on: files/patch-generic_tclXutil.c
>___________________________________________________________________
>Added: svn:mime-type
>## -0,0 +1 ##
>+text/plain
>\ No newline at end of property
>Added: fbsd:nokeywords
>## -0,0 +1 ##
>+yes
>\ No newline at end of property
>Added: svn:eol-style
>## -0,0 +1 ##
>+native
>\ No newline at end of property
>Index: files/patch-unix_tclXunixDup.c
>===================================================================
>--- files/patch-unix_tclXunixDup.c	(revision 0)
>+++ files/patch-unix_tclXunixDup.c	(working copy)
>@@ -0,0 +1,11 @@
>+--- unix/tclXunixDup.c.orig	2014-07-30 16:57:13.000000000 +0200
>++++ unix/tclXunixDup.c	2014-07-30 17:00:42.000000000 +0200
>+@@ -84,7 +84,7 @@
>+     char       *targetChannelId;
>+ {
>+     ClientData handle;
>+-    Tcl_ChannelType *channelType;
>++    const Tcl_ChannelType *channelType;
>+     Tcl_Channel newChannel = NULL;
>+     int srcFileNum, newFileNum = -1;
>+ 
>
>Property changes on: files/patch-unix_tclXunixDup.c
>___________________________________________________________________
>Added: svn:mime-type
>## -0,0 +1 ##
>+text/plain
>\ No newline at end of property
>Added: fbsd:nokeywords
>## -0,0 +1 ##
>+yes
>\ No newline at end of property
>Added: svn:eol-style
>## -0,0 +1 ##
>+native
>\ No newline at end of property

Actions: View | Diff

Attachments on bug 192370: 145333