FreeBSD Bugzilla – Attachment 153321 Details for
Bug 197923
[patch] [sched] Fix comment in sched_balance_pair and move load check ahead of lock
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Updated Patch
fix_sched_balance_pair_comment_and_move_lock.diff (text/plain), 929 bytes, created by
Harrison Grundy
on 2015-02-22 16:53:01 UTC
(
hide
)
Description:
Updated Patch
Filename:
MIME Type:
Creator:
Harrison Grundy
Created:
2015-02-22 16:53:01 UTC
Size:
929 bytes
patch
obsolete
>Index: sys/kern/sched_ule.c >=================================================================== >--- sys/kern/sched_ule.c (revision 278968) >+++ sys/kern/sched_ule.c (working copy) >@@ -908,15 +909,21 @@ > { > int moved; > int cpu; >- >+ >+ /* >+ * Don't bother to lock if balancing doesn't make sense. >+ */ >+ >+ if (high->tdq_load <= low->tdq_load) >+ return(0); >+ > tdq_lock_pair(high, low); > moved = 0; > /* >- * Determine what the imbalance is and then adjust that to how many >- * threads we actually have to give up (transferable). >+ * Move one thread from high to low if high has atleast 1 >+ * transferrable thread. > */ >- if (high->tdq_transferable != 0 && high->tdq_load > low->tdq_load && >- (moved = tdq_move(high, low)) > 0) { >+ if (high->tdq_transferable == 0 && (moved = tdq_move(high, low)) > 0) { > /* > * In case the target isn't the current cpu IPI it to force a > * reschedule with the new workload.
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=153321">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 197923
:
153318
|
153321
|
212626