FreeBSD Bugzilla – Attachment 155955 Details for
Bug 199673
sysctl(8) suffers a multiplication overflow when formatting vm.vmtotal
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
sysctl-overflow.diff
sysctl-overflow.diff (text/plain), 1.24 KB, created by
Vitaly Magerya
on 2015-04-24 19:05:10 UTC
(
hide
)
Description:
sysctl-overflow.diff
Filename:
MIME Type:
Creator:
Vitaly Magerya
Created:
2015-04-24 19:05:10 UTC
Size:
1.24 KB
patch
obsolete
>--- sysctl.c.orig 2015-04-24 21:41:27.000000000 +0300 >+++ sysctl.c 2015-04-24 21:50:56.000000000 +0300 >@@ -530,7 +530,7 @@ > S_vmtotal(size_t l2, void *p) > { > struct vmtotal *v = (struct vmtotal *)p; >- int pageKilo = getpagesize() / 1024; >+ ssize_t pageKilo = getpagesize() / 1024; > > if (l2 != sizeof(*v)) { > warnx("S_vmtotal %zu != %zu", l2, sizeof(*v)); >@@ -546,15 +546,15 @@ > "%hd Sleep: %hd)\n", > v->t_rq, v->t_dw, v->t_pw, v->t_sl); > printf( >- "Virtual Memory:\t\t(Total: %dK Active: %dK)\n", >+ "Virtual Memory:\t\t(Total: %zdK Active: %zdK)\n", > v->t_vm * pageKilo, v->t_avm * pageKilo); >- printf("Real Memory:\t\t(Total: %dK Active: %dK)\n", >+ printf("Real Memory:\t\t(Total: %zdK Active: %zdK)\n", > v->t_rm * pageKilo, v->t_arm * pageKilo); >- printf("Shared Virtual Memory:\t(Total: %dK Active: %dK)\n", >+ printf("Shared Virtual Memory:\t(Total: %zdK Active: %zdK)\n", > v->t_vmshr * pageKilo, v->t_avmshr * pageKilo); >- printf("Shared Real Memory:\t(Total: %dK Active: %dK)\n", >+ printf("Shared Real Memory:\t(Total: %zdK Active: %zdK)\n", > v->t_rmshr * pageKilo, v->t_armshr * pageKilo); >- printf("Free Memory:\t%dK", v->t_free * pageKilo); >+ printf("Free Memory:\t%zdK", v->t_free * pageKilo); > > return (0); > }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 199673
: 155955