FreeBSD Bugzilla – Attachment 162117 Details for
Bug 201912
panic in smbfs during mount
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
fix a race between smb_iod_destroy() and the smd_iod thread that destroys mutexes and frees the iod structure prematurely
smbiod2.patch (text/plain), 688 bytes, created by
Rick Macklem
on 2015-10-16 12:54:24 UTC
(
hide
)
Description:
fix a race between smb_iod_destroy() and the smd_iod thread that destroys mutexes and frees the iod structure prematurely
Filename:
MIME Type:
Creator:
Rick Macklem
Created:
2015-10-16 12:54:24 UTC
Size:
688 bytes
patch
obsolete
>--- smb_iod.c.orig 2015-10-10 18:53:34.000000000 -0400 >+++ smb_iod.c 2015-10-12 20:30:00.000000000 -0400 >@@ -659,6 +659,11 @@ smb_iod_thread(void *arg) > break; > tsleep(&iod->iod_flags, PWAIT, "90idle", iod->iod_sleeptimo); > } >+ >+ /* We can now safely destroy the mutexes and free the iod structure. */ >+ smb_sl_destroy(&iod->iod_rqlock); >+ smb_sl_destroy(&iod->iod_evlock); >+ free(iod, M_SMBIOD); > mtx_unlock(&Giant); > kproc_exit(0); > } >@@ -695,9 +700,6 @@ int > smb_iod_destroy(struct smbiod *iod) > { > smb_iod_request(iod, SMBIOD_EV_SHUTDOWN | SMBIOD_EV_SYNC, NULL); >- smb_sl_destroy(&iod->iod_rqlock); >- smb_sl_destroy(&iod->iod_evlock); >- free(iod, M_SMBIOD); > return 0; > } >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=162117">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 201912
:
159559
|
162117
|
162138