Attachment 169220 Details for Bug 208725 – Replace abs() on unsigned arguments in dns/powerdns

[patch] Replace abs() on unsigned arguments in dns/powerdns

dns__powerdns-fix-abs-1.diff (text/plain), 1.35 KB, created by Dimitry Andric on 2016-04-11 18:41:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dimitry Andric

Created: 2016-04-11 18:41:14 UTC

Size: 1.35 KB

patch

obsolete

>Index: dns/powerdns/files/patch-pdns__dnspacket.cc
>===================================================================
>--- dns/powerdns/files/patch-pdns__dnspacket.cc	(nonexistent)
>+++ dns/powerdns/files/patch-pdns__dnspacket.cc	(working copy)
>@@ -0,0 +1,14 @@
>+--- pdns/dnspacket.cc.orig	2015-11-02 11:33:21.000000000 +0100
>++++ pdns/dnspacket.cc	2016-04-11 16:12:10.116338000 +0200
>+@@ -642,8 +642,9 @@ bool checkForCorrectTSIG(const DNSPacket
>+ 
>+   q->getTSIGDetails(trc, keyname, &message);
>+   uint64_t now = time(0);
>+-  if(abs(trc->d_time - now) > trc->d_fudge) {
>+-    L<<Logger::Error<<"Packet for '"<<q->qdomain<<"' denied: TSIG (key '"<<*keyname<<"') time delta "<< abs(trc->d_time - now)<<" > 'fudge' "<<trc->d_fudge<<endl;
>++  uint64_t diff = trc->d_time >= now ? trc->d_time - now : now - trc->d_time;
>++  if(diff > trc->d_fudge) {
>++    L<<Logger::Error<<"Packet for '"<<q->qdomain<<"' denied: TSIG (key '"<<*keyname<<"') time delta "<<diff<<" > 'fudge' "<<trc->d_fudge<<endl;
>+     return false;
>+   }
>+ 
>
>Property changes on: dns/powerdns/files/patch-pdns__dnspacket.cc
>___________________________________________________________________
>Added: fbsd:nokeywords
>## -0,0 +1 ##
>+yes
>\ No newline at end of property
>Added: svn:eol-style
>## -0,0 +1 ##
>+native
>\ No newline at end of property
>Added: svn:mime-type
>## -0,0 +1 ##
>+text/plain
>\ No newline at end of property

Actions: View | Diff

Attachments on bug 208725: 169220 | 169232