Attachment 170569 Details for Bug 209680 – ipfw: Prefill the dynamic rule zone and prevent uma from freeing unused items

[patch] ipfw: Prefill the dynamic rule zone and prevent uma from freeing unused items

ipfw-Prefill-the-dynamic-rule-zone-and-prevent-uma-f.diff (text/plain), 1.03 KB, created by Fabian Keil on 2016-05-23 14:48:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fabian Keil

Created: 2016-05-23 14:48:57 UTC

Size: 1.03 KB

patch

obsolete

>From 6c087580681929e7c4663301a9f25a9707cb8576 Mon Sep 17 00:00:00 2001
>From: Fabian Keil <fk@fabiankeil.de>
>Date: Sun, 22 May 2016 12:47:29 +0200
>Subject: [PATCH 6/7] ipfw: Prefill the dynamic rule zone and prevent uma from
> freeing unused items
>
>---
> sys/netpfil/ipfw/ip_fw_dynamic.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/sys/netpfil/ipfw/ip_fw_dynamic.c b/sys/netpfil/ipfw/ip_fw_dynamic.c
>index 53df5e2..b1f274b 100644
>--- a/sys/netpfil/ipfw/ip_fw_dynamic.c
>+++ b/sys/netpfil/ipfw/ip_fw_dynamic.c
>@@ -1400,11 +1400,14 @@ ipfw_dyn_init(struct ip_fw_chain *chain)
> 
> 	V_ipfw_dyn_rule_zone = uma_zcreate("IPFW dynamic rule",
> 	    sizeof(ipfw_dyn_rule), NULL, NULL, NULL, NULL,
>-	    UMA_ALIGN_PTR, 0);
>+	    UMA_ALIGN_PTR, UMA_ZONE_NOFREE);
> 
> 	/* Enforce limit on dynamic rules */
> 	uma_zone_set_max(V_ipfw_dyn_rule_zone, V_dyn_max);
> 
>+	/* Prefill the zone to make sure the limit is always reachable */
>+	uma_prealloc(V_ipfw_dyn_rule_zone, V_dyn_max);
>+
>         callout_init(&V_ipfw_timeout, 1);
> 
> 	/*
>-- 
>2.7.4
>

Actions: View | Diff

Attachments on bug 209680: 170568 | 170569