Attachment 173558 Details for Bug 209892 – patch to fix PID issue

[patch] patch to fix PID issue

zabbix24-209892.patch (text/plain), 11.10 KB, created by pg on 2016-08-11 23:10:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: pg

Created: 2016-08-11 23:10:49 UTC

Size: 11.10 KB

patch

obsolete

>diff -uNr zabbix24-server.orig/Makefile zabbix24-server/Makefile
>--- zabbix24-server.orig/Makefile	2016-08-02 11:23:04.942252397 +0300
>+++ zabbix24-server/Makefile	2016-08-12 02:01:14.926202055 +0300
>@@ -1,9 +1,9 @@
> # Created by: Pakhom Golynga <pakhom@pakhom.spb.ru>
>-# $FreeBSD: head/net-mgmt/zabbix24-server/Makefile 415742 2016-05-23 20:35:01Z amdmi3 $
>+# $FreeBSD: head/net-mgmt/zabbix24-server/Makefile 414094 2016-04-27 08:28:25Z robak $
> 
> PORTNAME=	zabbix24
> PORTVERSION=	2.4.8
>-PORTREVISION?=	0
>+PORTREVISION?=	1
> CATEGORIES=	net-mgmt
> MASTER_SITES=	SF/zabbix/ZABBIX%20Latest%20Stable/${PORTVERSION}
> PKGNAMESUFFIX?=	-server
>@@ -14,15 +14,13 @@
> 
> LICENSE=	GPLv2
> 
>-CONFLICTS=	${PKGBASE}-1.[0-8]*
>+LIB_DEPENDS=	libnetsnmp.so:net-mgmt/net-snmp
>+
>+CONFLICTS=	zabbix2${PKGNAMESUFFIX}-[0-9]* zabbix22${PKGNAMESUFFIX}[0-9]* zabbix3${PKGNAMESUFFIX}-[0-9]*
> 
> IGNORE_WITH_PHP=	52
> IGNORE_WITH_MYSQL=	41
> 
>-.if ${PKGNAMESUFFIX} != "-agent"
>-CONFLICTS+=	${PORTNAME}-1.[0-8]*
>-.endif
>-
> ZABBIX_BUILD=	${PKGNAMESUFFIX:S/^-//}
> 
> .if ${ZABBIX_BUILD} != "frontend" # frontend only needs the version/distribution settings
>@@ -60,7 +58,6 @@
> 			--with-iconv=${ICONV_PREFIX}
> 
> .if ${ZABBIX_BUILD} != "agent"
>-LIB_DEPENDS=	libnetsnmp.so:net-mgmt/net-snmp
> USES+=		execinfo
> 
> CPPFLAGS+=	${EXECINFO_CPPFLAGS}
>@@ -72,7 +69,7 @@
> 
> OPTIONS_DEFINE=		IPV6 FPING JABBER CURL LDAP IPMI SSH NMAP JAVAGW \
> 			LIBXML2
>-OPTIONS_DEFAULT=	FPING JABBER CURL UNIXODBC MYSQL SSH
>+OPTIONS_DEFAULT=	FPING CURL UNIXODBC MYSQL SSH
> OPTIONS_SUB=		yes
> 
> CURL_DESC=		Support for web monitoring
>@@ -91,13 +88,13 @@
> OPTIONS_SINGLE_ODBC=	IODBC UNIXODBC
> 
> MYSQL_CONFIGURE_WITH=	mysql
>-MYSQL_USE=		MYSQL=yes
>+USES+=			mysql
> 
> PGSQL_CONFIGURE_WITH=	postgresql
>-PGSQL_USES=		pgsql
>+USES+=			pgsql
> 
> SQLITE_CONFIGURE_WITH=	sqlite3
>-SQLITE_USES=		sqlite:3
>+USES+=			sqlite:3
> 
> ORACLE_CONFIGURE_WITH=	oracle
> 
>@@ -144,6 +141,21 @@
> 	@${REINPLACE_CMD} -e 's#/usr/sbin/fping#${LOCALBASE}/sbin/fping#g' \
> 		${WRKSRC}/conf/zabbix_*.conf
> 
>+.if ${ZABBIX_BUILD} == "server"
>+	@${REINPLACE_CMD} -e 's#PidFile=/tmp/zabbix_server.pid#PidFile=/var/run/zabbix/zabbix_server.pid#g' \
>+		${WRKSRC}/conf/zabbix_server*.conf
>+.endif
>+
>+.if ${ZABBIX_BUILD} == "proxy"
>+	@${REINPLACE_CMD} -e 's#PidFile=/tmp/zabbix_proxy.pid#PidFile=/var/run/zabbix/zabbix_proxy.pid#g' \
>+		${WRKSRC}/conf/zabbix_proxy*.conf
>+.endif
>+
>+.if ${ZABBIX_BUILD} == "agent"
>+	@${REINPLACE_CMD} -e 's#PidFile=/tmp/zabbix_agentd.pid#PidFile=/var/run/zabbix/zabbix_agentd.pid#g' \
>+		${WRKSRC}/conf/zabbix_agentd*.conf
>+.endif
>+
> .if ${ZABBIX_BUILD} != "agent"
> .  for d in mysql oracle postgresql sqlite3
> 	@${REINPLACE_CMD} \
>diff -uNr zabbix24-server.orig/files/patch-src-zabbix_agent_zabbix_agentd.c zabbix24-server/files/patch-src-zabbix_agent_zabbix_agentd.c
>--- zabbix24-server.orig/files/patch-src-zabbix_agent_zabbix_agentd.c	1970-01-01 03:00:00.000000000 +0300
>+++ zabbix24-server/files/patch-src-zabbix_agent_zabbix_agentd.c	2016-05-13 14:51:12.786550000 +0300
>@@ -0,0 +1,11 @@
>+--- src/zabbix_agent/zabbix_agentd.c.orig	2016-05-13 14:37:25.696606000 +0300
>++++ src/zabbix_agent/zabbix_agentd.c	2016-05-13 14:49:45.011554761 +0300
>+@@ -521,7 +521,7 @@
>+ 		CONFIG_LOAD_MODULE_PATH = zbx_strdup(CONFIG_LOAD_MODULE_PATH, LIBDIR "/modules");
>+ 
>+ 	if (NULL == CONFIG_PID_FILE)
>+-		CONFIG_PID_FILE = "/tmp/zabbix_agentd.pid";
>++		CONFIG_PID_FILE = "/var/run/zabbix/zabbix_agentd.pid";
>+ #endif
>+ 	if (NULL == CONFIG_LOG_TYPE_STR)
>+ 		CONFIG_LOG_TYPE_STR = zbx_strdup(CONFIG_LOG_TYPE_STR, ZBX_OPTION_LOGTYPE_FILE);
>diff -uNr zabbix24-server.orig/files/patch-src-zabbix_proxy_proxy.c zabbix24-server/files/patch-src-zabbix_proxy_proxy.c
>--- zabbix24-server.orig/files/patch-src-zabbix_proxy_proxy.c	1970-01-01 03:00:00.000000000 +0300
>+++ zabbix24-server/files/patch-src-zabbix_proxy_proxy.c	2016-05-13 14:47:29.182567000 +0300
>@@ -0,0 +1,11 @@
>+--- src/zabbix_proxy/proxy.c.orig	2016-04-20 12:51:20.000000000 +0300
>++++ src/zabbix_proxy/proxy.c	2016-05-13 14:46:44.193569184 +0300
>+@@ -389,7 +389,7 @@
>+ 		CONFIG_SNMPTRAP_FILE = zbx_strdup(CONFIG_SNMPTRAP_FILE, "/tmp/zabbix_traps.tmp");
>+ 
>+ 	if (NULL == CONFIG_PID_FILE)
>+-		CONFIG_PID_FILE = zbx_strdup(CONFIG_PID_FILE, "/tmp/zabbix_proxy.pid");
>++		CONFIG_PID_FILE = zbx_strdup(CONFIG_PID_FILE, "/var/run/zabbix/zabbix_proxy.pid");
>+ 
>+ 	if (NULL == CONFIG_TMPDIR)
>+ 		CONFIG_TMPDIR = zbx_strdup(CONFIG_TMPDIR, "/tmp");
>diff -uNr zabbix24-server.orig/files/patch-src-zabbix_server_server.c zabbix24-server/files/patch-src-zabbix_server_server.c
>--- zabbix24-server.orig/files/patch-src-zabbix_server_server.c	1970-01-01 03:00:00.000000000 +0300
>+++ zabbix24-server/files/patch-src-zabbix_server_server.c	2016-05-13 14:28:09.669645000 +0300
>@@ -0,0 +1,11 @@
>+--- src/zabbix_server/server.c.orig	2016-04-20 12:51:20.000000000 +0300
>++++ src/zabbix_server/server.c	2016-05-13 14:20:17.603677788 +0300
>+@@ -369,7 +369,7 @@
>+ 		CONFIG_SNMPTRAP_FILE = zbx_strdup(CONFIG_SNMPTRAP_FILE, "/tmp/zabbix_traps.tmp");
>+ 
>+ 	if (NULL == CONFIG_PID_FILE)
>+-		CONFIG_PID_FILE = zbx_strdup(CONFIG_PID_FILE, "/tmp/zabbix_server.pid");
>++		CONFIG_PID_FILE = zbx_strdup(CONFIG_PID_FILE, "/var/run/zabbix/zabbix_server.pid");
>+ 
>+ 	if (NULL == CONFIG_ALERT_SCRIPTS_PATH)
>+ 		CONFIG_ALERT_SCRIPTS_PATH = zbx_strdup(CONFIG_ALERT_SCRIPTS_PATH, DATADIR "/zabbix/alertscripts");
>diff -uNr zabbix24-server.orig/files/zabbix_agentd.in zabbix24-server/files/zabbix_agentd.in
>--- zabbix24-server.orig/files/zabbix_agentd.in	2016-08-02 11:23:04.987252822 +0300
>+++ zabbix24-server/files/zabbix_agentd.in	2016-05-13 15:05:56.061488000 +0300
>@@ -9,10 +9,10 @@
> #
> # zabbix_agentd_enable (bool): Set to NO by default.  Set it to YES to
> #         enable zabbix_agentd.
>-# zabbix_agentd_paths (string): Set to standard path by default.  Set a search
>-#         if you have custom userparams that need binaries elsewhere.
> # zabbix_agentd_config (string): Set to the standard config file path by
> #         default.
>+# zabbix_agentd_pidfile (string):    Location of the asterisk pid file
>+#                               Default is /var/run/zabbix/zabbix_agentd.pid
> #
> 
> . /etc/rc.subr
>@@ -22,22 +22,27 @@
> 
> load_rc_config $name
> 
>-: ${zabbix_agentd_enable="NO"}
>-: ${zabbix_agentd_paths=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin}
>-: ${zabbix_agentd_config="%%ETCDIR%%/${name}.conf"}
>+: ${zabbix_agentd_enable:=NO}
>+: ${zabbix_agentd_config:=%%ETCDIR%%/${name}.conf}
>+: ${zabbix_agentd_pidfile:=/var/run/zabbix/zabbix_agentd.pid}
> 
> command="%%PREFIX%%/sbin/${name}"
> required_files="${zabbix_agentd_config}"
>-start_precmd="find_pidfile"
>-status_precmd="find_pidfile"
>-stop_precmd="find_pidfile"
> 
>-find_pidfile()
>+start_precmd=zabbix_agentd_precmd 
>+status_precmd=zabbix_agentd_precmd
>+stop_precmd=zabbix_agentd_precmd
>+
>+zabbix_agentd_precmd()
> {
> 	if get_pidfile_from_conf PidFile ${zabbix_agentd_config}; then
> 		pidfile="$_pidfile_from_conf"
> 	else
>-		pidfile="/tmp/${name}.pid"
>+		pidfile=${zabbix_agentd_pidfile}
>+		local rundir=${zabbix_agentd_pidfile%/*}
>+		if [ ! -d $rundir ] ; then
>+			install -d -m 0755 -o zabbix -g zabbix $rundir
>+		fi
> 	fi
> 
> 	# This shouldn't be necessary with pidfile, but empirically it was the
>@@ -47,6 +52,4 @@
> 	rc_pid=$(check_pidfile ${pidfile} ${command})
> }
> 
>-export PATH="${zabbix_agentd_paths}"
>-
> run_rc_command "$1"
>diff -uNr zabbix24-server.orig/files/zabbix_proxy.in zabbix24-server/files/zabbix_proxy.in
>--- zabbix24-server.orig/files/zabbix_proxy.in	2016-08-02 11:23:04.986253264 +0300
>+++ zabbix24-server/files/zabbix_proxy.in	2016-05-13 14:44:17.197578000 +0300
>@@ -11,10 +11,10 @@
> #
> # zabbix_proxy_enable (bool): Set to NO by default.  Set it to YES to
> #         enable zabbix_proxy.
>-# zabbix_proxy_paths (string): Set to standard path by default.  Set a search
>-#         if you have custom externals that need binaries elsewhere.
> # zabbix_proxy_config (string): Set to the standard config file path by
> #         default.
>+# zabbix_proxy_pidfile (string):    Location of the asterisk pid file
>+#                               Default is /var/run/zabbix/zabbix_proxy.pid
> #
> 
> . /etc/rc.subr
>@@ -24,22 +24,27 @@
> 
> load_rc_config $name
> 
>-: ${zabbix_proxy_enable="NO"}
>-: ${zabbix_proxy_paths=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin}
>-: ${zabbix_proxy_config="%%ETCDIR%%/${name}.conf"}
>+: ${zabbix_proxy_enable:=NO}
>+: ${zabbix_proxy_config:=%%ETCDIR%%/${name}.conf}
>+: ${zabbix_proxy_pidfile:=/var/run/zabbix/zabbix_proxy.pid}
> 
> command="%%PREFIX%%/sbin/${name}"
> required_files="${zabbix_proxy_config}"
>-start_precmd="find_pidfile"
>-status_precmd="find_pidfile"
>-stop_precmd="find_pidfile"
> 
>-find_pidfile()
>+start_precmd=zabbix_proxy_precmd 
>+status_precmd=zabbix_proxy_precmd
>+stop_precmd=zabbix_proxy_precmd
>+
>+zabbix_proxy_precmd()
> {
>-	if get_pidfile_from_conf PidFile ${zabbix_agentd_config}; then
>+	if get_pidfile_from_conf PidFile ${zabbix_proxy_config}; then
> 		pidfile="$_pidfile_from_conf"
> 	else
>-		pidfile="/tmp/${name}.pid"
>+		pidfile=${zabbix_proxy_pidfile}
>+		local rundir=${zabbix_proxy_pidfile%/*}
>+		if [ ! -d $rundir ] ; then
>+			install -d -m 0755 -o zabbix -g zabbix $rundir
>+		fi
> 	fi
> 
> 	# This shouldn't be necessary with pidfile, but empirically it was the
>@@ -49,6 +54,4 @@
> 	rc_pid=$(check_pidfile ${pidfile} ${command})
> }
> 
>-export PATH="${zabbix_proxy_paths}"
>-
> run_rc_command "$1"
>diff -uNr zabbix24-server.orig/files/zabbix_server.in zabbix24-server/files/zabbix_server.in
>--- zabbix24-server.orig/files/zabbix_server.in	2016-08-02 11:23:04.979252224 +0300
>+++ zabbix24-server/files/zabbix_server.in	2016-05-13 14:26:40.145651000 +0300
>@@ -11,10 +11,10 @@
> #
> # zabbix_server_enable (bool): Set to NO by default.  Set it to YES to
> #         enable zabbix_server.
>-# zabbix_server_paths (string): Set to standard path by default.  Set a search
>-#         if you have custom externals that need binaries elsewhere.
> # zabbix_server_config (string): Set to the standard config file path by
> #         default.
>+# zabbix_server_pidfile (string):    Location of the asterisk pid file
>+#                               Default is /var/run/zabbix/zabbix_server.pid
> #
> 
> . /etc/rc.subr
>@@ -24,22 +24,27 @@
> 
> load_rc_config $name
> 
>-: ${zabbix_server_enable="NO"}
>-: ${zabbix_server_paths=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin}
>-: ${zabbix_server_config="%%ETCDIR%%/${name}.conf"}
>+: ${zabbix_server_enable:=NO}
>+: ${zabbix_server_config:=%%ETCDIR%%/${name}.conf}
>+: ${zabbix_server_pidfile:=/var/run/zabbix/zabbix_server.pid}
> 
> command="%%PREFIX%%/sbin/${name}"
> required_files="${zabbix_server_config}"
>-start_precmd="find_pidfile"
>-status_precmd="find_pidfile"
>-stop_precmd="find_pidfile"
> 
>-find_pidfile()
>+start_precmd=zabbix_server_precmd 
>+status_precmd=zabbix_server_precmd
>+stop_precmd=zabbix_server_precmd
>+
>+zabbix_server_precmd()
> {
> 	if get_pidfile_from_conf PidFile ${zabbix_server_config}; then
> 		pidfile="$_pidfile_from_conf"
> 	else
>-		pidfile="/tmp/${name}.pid"
>+		pidfile=${zabbix_server_pidfile}
>+		local rundir=${zabbix_server_pidfile%/*}
>+		if [ ! -d $rundir ] ; then
>+			install -d -m 0755 -o zabbix -g zabbix $rundir
>+		fi
> 	fi
> 
> 	# This shouldn't be necessary with pidfile, but empirically it was the
>@@ -49,6 +54,4 @@
> 	rc_pid=$(check_pidfile ${pidfile} ${command})
> }
> 
>-export PATH="${zabbix_server_paths}"
>-
> run_rc_command "$1"

Flags:

pg: maintainer-approval+

Actions: View | Diff

Attachments on bug 209892: 170868 | 171541 | 173558 | 173559