FreeBSD Bugzilla – Attachment 180348 Details for
Bug 217401
Deadlock in if_clone.c
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Fix for deadlock in if_clone.c
if_clone_deadlock_fix_2017_02_24.diff (text/plain), 766 bytes, created by
Daan Vreeken
on 2017-02-27 19:50:30 UTC
(
hide
)
Description:
Fix for deadlock in if_clone.c
Filename:
MIME Type:
Creator:
Daan Vreeken
Created:
2017-02-27 19:50:30 UTC
Size:
766 bytes
patch
obsolete
>Index: sys/net/if_clone.c >=================================================================== >--- sys/net/if_clone.c (revision 299060) >+++ sys/net/if_clone.c (working copy) >@@ -606,7 +606,7 @@ > ifc_alloc_unit(struct if_clone *ifc, int *unit) > { > char name[IFNAMSIZ]; >- int wildcard; >+ int wildcard, result; > > wildcard = (*unit < 0); > retry: >@@ -617,8 +617,8 @@ > if (*unit == -1) > return (ENOSPC); > } else { >- *unit = alloc_unr_specific(ifc->ifc_unrhdr, *unit); >- if (*unit == -1) { >+ result = alloc_unr_specific(ifc->ifc_unrhdr, *unit); >+ if (result == -1) { > if (wildcard) { > (*unit)++; > goto retry; >@@ -625,6 +625,7 @@ > } else > return (EEXIST); > } >+ *unit = result; > } > > snprintf(name, IFNAMSIZ, "%s%d", ifc->ifc_name, *unit);
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=180348">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 217401
: 180348